mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
James M Snell
e48d58b8b2
Using `assert.AssertionError()` without the `new` keyword results
in a non-intuitive error:
```js
> assert.AssertionError({})
TypeError: Cannot assign to read only property 'name' of function 'function ok(value, message) {
if (!value) fail(value, true, message, '==', assert.ok);
}'
at Function.AssertionError (assert.js:45:13)
at repl:1:8
at realRunInThisContextScript (vm.js:22:35)
at sigintHandlersWrap (vm.js:98:12)
at ContextifyScript.Script.runInThisContext (vm.js:24:12)
at REPLServer.defaultEval (repl.js:346:29)
at bound (domain.js:280:14)
at REPLServer.runBound [as eval] (domain.js:293:12)
at REPLServer.onLine (repl.js:545:10)
at emitOne (events.js:101:20)
>
```
The `assert.AssertionError()` can only be used correctly with `new`,
so this converts it into a proper ES6 class that will give an
appropriate error message.
This also associates the appropriate internal/errors code with all
`assert.AssertionError` instances and updates the appropriate test
cases.
PR-URL: https://github.com/nodejs/node/pull/12651
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
67 lines
2.2 KiB
JavaScript
67 lines
2.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
|
|
// Template tag function turning an error message into a RegExp
|
|
// for assert.throws()
|
|
function re(literals, ...values) {
|
|
let result = literals[0];
|
|
for (const [i, value] of values.entries()) {
|
|
const str = util.inspect(value);
|
|
// Need to escape special characters.
|
|
result += str.replace(/[\\^$.*+?()[\]{}|=!<>:-]/g, '\\$&');
|
|
result += literals[i + 1];
|
|
}
|
|
return common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: new RegExp(`^${result}$`)
|
|
});
|
|
}
|
|
|
|
// Turn off no-restricted-properties because we are testing deepEqual!
|
|
/* eslint-disable no-restricted-properties */
|
|
|
|
// See https://github.com/nodejs/node/issues/10258
|
|
{
|
|
const date = new Date('2016');
|
|
function FakeDate() {}
|
|
FakeDate.prototype = Date.prototype;
|
|
const fake = new FakeDate();
|
|
|
|
assert.doesNotThrow(() => assert.deepEqual(date, fake));
|
|
assert.doesNotThrow(() => assert.deepEqual(fake, date));
|
|
|
|
// For deepStrictEqual we check the runtime type,
|
|
// then reveal the fakeness of the fake date
|
|
assert.throws(() => assert.deepStrictEqual(date, fake),
|
|
re`${date} deepStrictEqual Date {}`);
|
|
assert.throws(() => assert.deepStrictEqual(fake, date),
|
|
re`Date {} deepStrictEqual ${date}`);
|
|
}
|
|
|
|
{ // At the moment global has its own type tag
|
|
const fakeGlobal = {};
|
|
Object.setPrototypeOf(fakeGlobal, Object.getPrototypeOf(global));
|
|
for (const prop of Object.keys(global)) {
|
|
fakeGlobal[prop] = global[prop];
|
|
}
|
|
assert.doesNotThrow(() => assert.deepEqual(fakeGlobal, global));
|
|
// Message will be truncated anyway, don't validate
|
|
assert.throws(() => assert.deepStrictEqual(fakeGlobal, global),
|
|
assert.AssertionError);
|
|
}
|
|
|
|
{ // At the moment process has its own type tag
|
|
const fakeProcess = {};
|
|
Object.setPrototypeOf(fakeProcess, Object.getPrototypeOf(process));
|
|
for (const prop of Object.keys(process)) {
|
|
fakeProcess[prop] = process[prop];
|
|
}
|
|
assert.doesNotThrow(() => assert.deepEqual(fakeProcess, process));
|
|
// Message will be truncated anyway, don't validate
|
|
assert.throws(() => assert.deepStrictEqual(fakeProcess, process),
|
|
assert.AssertionError);
|
|
}
|
|
/* eslint-enable */
|