mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Rajaram Gaunker
06a617aa21
This commit contains three separate changes: - Always return a string from ToUnicode no matter if an error occurred. - Disable CheckHyphens boolean flag. This flag will soon be enabled in the URL Standard, but is implemented manually by selectively ignoring certain errors. - Enable CheckBidi boolean flag per URL Standard update. This allows domain names with hyphens at 3 and 4th position, as well as those with leading and trailing hyphens. They are technically invalid, but seen in the wild. Tests are updated and simplified accordingly. PR-URL: https://github.com/nodejs/node/pull/12966 Fixes: https://github.com/nodejs/node/issues/12965 Refs: https://github.com/whatwg/url/pull/309 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
36 lines
1.1 KiB
JavaScript
36 lines
1.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasIntl) {
|
|
common.skip('missing Intl');
|
|
return;
|
|
}
|
|
|
|
const icu = process.binding('icu');
|
|
const assert = require('assert');
|
|
|
|
const tests = require('../fixtures/url-idna.js');
|
|
|
|
{
|
|
for (const [i, { ascii, unicode }] of tests.valid.entries()) {
|
|
assert.strictEqual(ascii, icu.toASCII(unicode), `toASCII(${i + 1})`);
|
|
assert.strictEqual(unicode, icu.toUnicode(ascii), `toUnicode(${i + 1})`);
|
|
assert.strictEqual(ascii, icu.toASCII(icu.toUnicode(ascii)),
|
|
`toASCII(toUnicode(${i + 1}))`);
|
|
assert.strictEqual(unicode, icu.toUnicode(icu.toASCII(unicode)),
|
|
`toUnicode(toASCII(${i + 1}))`);
|
|
}
|
|
}
|
|
|
|
{
|
|
for (const [i, url] of tests.invalid.entries()) {
|
|
assert.throws(() => icu.toASCII(url),
|
|
/^Error: Cannot convert name to ASCII$/,
|
|
`ToASCII invalid case ${i + 1}`);
|
|
assert.doesNotThrow(() => icu.toASCII(url, true),
|
|
`ToASCII invalid case ${i + 1} in lenient mode`);
|
|
assert.doesNotThrow(() => icu.toUnicode(url),
|
|
`ToUnicode invalid case ${i + 1}`);
|
|
}
|
|
}
|