BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 22:37:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

CIFS: Fix readpages retrying on reconnects

Browse Source 
If we got a reconnect error from async readv we re-add pages back
to page_list and continue loop. That is wrong because these pages
have been already added to the pagecache but page_list has pages that
have not been added to the pagecache yet. This ends up with a general
protection fault in put_pages after readpages. Fix it by not retrying
the read of these pages and falling back to readpage instead.

Fixes debian bug 762306

Signed-off-by: Pavel Shilovsky <[email protected]>
Signed-off-by: Steve French <[email protected]>
Tested-by: Arthur Marsh <[email protected]>
This commit is contained in:
Pavel Shilovsky authored and Steve French committed 2014-10-02 14:17:41 -05:00
1 parent 19e81573fc
commit 1209bbdff2
1 file changed
+1 -7
Download Patch File Download Diff File Expand all files Collapse all files
fs/cifs/file.c
+1 -7
View File
@@ -3568,15 +3568,9 @@ static int cifs_readpages(struct file *file, struct address_space *mapping,
lru_cache_add_file(page);
unlock_page(page);
page_cache_release(page);
if (rc == -EAGAIN)
list_add_tail(&page->lru, &tmplist);
}
/* Fallback to the readpage in error/reconnect cases */
kref_put(&rdata->refcount, cifs_readdata_release);
if (rc == -EAGAIN) {
/* Re-add pages to the page_list and retry */
list_splice(&tmplist, page_list);
continue;
}
break;
}