BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

md: simplify sync_page_io

Browse Source 
Use an on-stack bio and biovec for the single page synchronous I/O.

Signed-off-by: Christoph Hellwig <[email protected]>
Acked-by: Song Liu <[email protected]>
Reviewed-by: Johannes Thumshirn <[email protected]>
Reviewed-by: Chaitanya Kulkarni <[email protected]>
Acked-by: Damien Le Moal <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
This commit is contained in:
Christoph Hellwig authored and Jens Axboe committed 2021-01-27 09:51:48 -07:00
1 parent a78f18da66
commit 32637385b8
1 file changed
+13 -13
Download Patch File Download Diff File Expand all files Collapse all files
drivers/md/md.c
+13 -13
View File
@@ -1021,29 +1021,29 @@ int md_super_wait(struct mddev *mddev)
int sync_page_io(struct md_rdev *rdev, sector_t sector, int size,
struct page *page, int op, int op_flags, bool metadata_op)
{
struct bio *bio = md_bio_alloc_sync(rdev->mddev);
int ret;
struct bio bio;
struct bio_vec bvec;
bio_init(&bio, &bvec, 1);
if (metadata_op && rdev->meta_bdev)
bio_set_dev(bio, rdev->meta_bdev);
bio_set_dev(&bio, rdev->meta_bdev);
else
bio_set_dev(bio, rdev->bdev);
bio_set_op_attrs(bio, op, op_flags);
bio_set_dev(&bio, rdev->bdev);
bio.bi_opf = op | op_flags;
if (metadata_op)
bio->bi_iter.bi_sector = sector + rdev->sb_start;
bio.bi_iter.bi_sector = sector + rdev->sb_start;
else if (rdev->mddev->reshape_position != MaxSector &&
(rdev->mddev->reshape_backwards ==
(sector >= rdev->mddev->reshape_position)))
bio->bi_iter.bi_sector = sector + rdev->new_data_offset;
bio.bi_iter.bi_sector = sector + rdev->new_data_offset;
else
bio->bi_iter.bi_sector = sector + rdev->data_offset;
bio_add_page(bio, page, size, 0);
bio.bi_iter.bi_sector = sector + rdev->data_offset;
bio_add_page(&bio, page, size, 0);
submit_bio_wait(bio);
submit_bio_wait(&bio);
ret = !bio->bi_status;
bio_put(bio);
return ret;
return !bio.bi_status;
}
EXPORT_SYMBOL_GPL(sync_page_io);