BackPup/Linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-25 21:21:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: tlv320aic32x4: pll: Remove impossible condition in clk_aic32x4_pll_determine_rate()

Browse Source 
Smatch warns:

sound/soc/codecs/tlv320aic32x4-clk.c:219 clk_aic32x4_pll_determine_rate() warn: unsigned 'rate' is never less than zero.

Cc: Maxime Ripard <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 25d43ec352 ("ASoC: tlv320aic32x4: pll: Switch to determine_rate")
Signed-off-by: Stephen Boyd <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Maxime Ripard <[email protected]>
This commit is contained in:
Stephen Boyd
2023-06-13 12:00:55 -07:00
parent be8fa5fd0a
commit 3e253b2169
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sound/soc/codecs/tlv320aic32x4-clk.c
+1 -5
View File
@@ -208,18 +208,14 @@ static int clk_aic32x4_pll_determine_rate(struct clk_hw *hw,
struct clk_rate_request *req)
{
struct clk_aic32x4_pll_muldiv settings;
unsigned long rate;
int ret;
ret = clk_aic32x4_pll_calc_muldiv(&settings, req->rate, req->best_parent_rate);
if (ret < 0)
return -EINVAL;
rate = clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate);
if (rate < 0)
return rate;
req->rate = clk_aic32x4_pll_calc_rate(&settings, req->best_parent_rate);
req->rate = rate;
return 0;
}