BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()

Browse Source 
Commit cdb42becdd ("scsi: lpfc: Replace io_channels for nvme and fcp with
general hdw_queues per cpu") has introduced static checker warnings for
potential null dereferences in 'lpfc_sli4_hba_unset()' and commit 1ffdd2c044
("scsi: lpfc: resolve static checker warning in lpfc_sli4_hba_unset") has
tried to fix it.  However, yet another potential null dereference is
remaining.  This commit fixes it.

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Link: https://lore.kernel.org/r/[email protected]
Fixes: 1ffdd2c044 ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")
Fixes: cdb42becdd ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu")
Reviewed-by: James Smart <[email protected]>
Signed-off-by: SeongJae Park <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
This commit is contained in:
SeongJae Park authored and Martin K. Petersen committed 2020-06-23 23:56:52 -04:00
1 parent aad4b4d15f
commit 46da547e21
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/scsi/lpfc/lpfc_init.c
+2 -1
View File
@@ -11878,7 +11878,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba)
lpfc_sli4_xri_exchange_busy_wait(phba);
/* per-phba callback de-registration for hotplug event */
lpfc_cpuhp_remove(phba);
if (phba->pport)
lpfc_cpuhp_remove(phba);
/* Disable PCI subsystem interrupt */
lpfc_sli4_disable_intr(phba);