BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

fbdev: p9100: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Helge Deller <[email protected]>
This commit is contained in:
Uwe Kleine-König authored and Helge Deller committed 2023-04-24 11:48:31 +02:00
1 parent dc6b77badc
commit 4d7960389f
1 file changed
+2 -4
Download Patch File Download Diff File Expand all files Collapse all files
drivers/video/fbdev/p9100.c
+2 -4
View File
@@ -327,7 +327,7 @@ out_err:
return err;
}
static int p9100_remove(struct platform_device *op)
static void p9100_remove(struct platform_device *op)
{
struct fb_info *info = dev_get_drvdata(&op->dev);
struct p9100_par *par = info->par;
@@ -339,8 +339,6 @@ static int p9100_remove(struct platform_device *op)
of_iounmap(&op->resource[2], info->screen_base, info->fix.smem_len);
framebuffer_release(info);
return 0;
}
static const struct of_device_id p9100_match[] = {
@@ -357,7 +355,7 @@ static struct platform_driver p9100_driver = {
.of_match_table = p9100_match,
},
.probe = p9100_probe,
.remove = p9100_remove,
.remove_new = p9100_remove,
};
static int __init p9100_init(void)