mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 05:31:08 -04:00
perf tui: Reset use_browser if stdout is not a tty
The newt initialization routines weren't being called because the output was a file (perf annotate > /tmp/bla) but use_browser was still 1, because ~/.perfconfig had it as 'on', so, later on newt routines segfaulted. Cc: Frédéric Weisbecker <[email protected]> Cc: Mike Galbraith <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Cc: Tom Zanussi <[email protected]> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
This commit is contained in:
1 parent
49c177461b
commit
62e3436b5f
2 files changed
+2
-1
No files matched your search
@@ -343,7 +343,7 @@ find_next:
|
||||
continue;
|
||||
}
|
||||
|
||||
if (use_browser) {
|
||||
if (use_browser > 0) {
|
||||
key = hist_entry__tui_annotate(he);
|
||||
if (is_exit_key(key))
|
||||
break;
|
||||
|
||||
@@ -1139,6 +1139,7 @@ void setup_browser(void)
|
||||
struct newtPercentTreeColors *c = &defaultPercentTreeColors;
|
||||
|
||||
if (!isatty(1) || !use_browser || dump_trace) {
|
||||
use_browser = 0;
|
||||
setup_pager();
|
||||
return;
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user