mirror of
https://github.com/torvalds/linux.git
synced 2026-09-25 21:21:09 -04:00
cifs: allow syscalls to be restarted in __smb_send_rqst()
A customer has reported that several files in their multi-threaded app were left with size of 0 because most of the read(2) calls returned -EINTR and they assumed no bytes were read. Obviously, they could have fixed it by simply retrying on -EINTR. We noticed that most of the -EINTR on read(2) were due to real-time signals sent by glibc to process wide credential changes (SIGRT_1), and its signal handler had been established with SA_RESTART, in which case those calls could have been automatically restarted by the kernel. Let the kernel decide to whether or not restart the syscalls when there is a signal pending in __smb_send_rqst() by returning -ERESTARTSYS. If it can't, it will return -EINTR anyway. Signed-off-by: Paulo Alcantara (SUSE) <[email protected]> CC: Stable <[email protected]> Reviewed-by: Ronnie Sahlberg <[email protected]> Reviewed-by: Pavel Shilovsky <[email protected]> Signed-off-by: Steve French <[email protected]>
This commit is contained in:
committed by
Steve French
parent
b650545978
commit
6988a619f5
+2
-2
@@ -339,8 +339,8 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
|
||||
return -EAGAIN;
|
||||
|
||||
if (signal_pending(current)) {
|
||||
cifs_dbg(FYI, "signal is pending before sending any data\n");
|
||||
return -EINTR;
|
||||
cifs_dbg(FYI, "signal pending before send request\n");
|
||||
return -ERESTARTSYS;
|
||||
}
|
||||
|
||||
/* cork the socket */
|
||||
|
||||
Reference in New Issue
Block a user