BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

statx: don't clear STATX_ATIME on SB_RDONLY

Browse Source 
IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so
generic_fillattr() will clear STATX_ATIME from the result_mask if the super
block is marked read only.

This was probably not the intention, so fix to only clear STATX_ATIME if
the fs doesn't support atime at all.

Signed-off-by: Miklos Szeredi <[email protected]>
Acked-by: David Howells <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
This commit is contained in:
Miklos Szeredi committed 2020-05-14 16:44:24 +02:00
1 parent 581701b7ef
commit 761e28fa27
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
fs/stat.c
+2 -1
View File
@@ -73,7 +73,8 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
query_flags &= KSTAT_QUERY_FLAGS;
/* allow the fs to override these if it really wants to */
if (IS_NOATIME(inode))
/* SB_NOATIME means filesystem supplies dummy atime value */
if (inode->i_sb->s_flags & SB_NOATIME)
stat->result_mask &= ~STATX_ATIME;
if (IS_AUTOMOUNT(inode))
stat->attributes |= STATX_ATTR_AUTOMOUNT;