tools/lib/lockdep/tests: Fix shellcheck warnings

Use find instead of ls to avoid splitting filenames that contain spaces.
Use rm -f instead of if ... then rm ...; fi. This patch addresses all
shellcheck complaints about the run_tests.sh shell script.

Signed-off-by: Bart Van Assche <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Sasha Levin <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Waiman Long <[email protected]>
Cc: [email protected]
Cc: [email protected]
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
This commit is contained in:
Bart Van Assche authored and Ingo Molnar committed 2018-12-11 14:54:48 +01:00
1 parent da087b2229
commit 7e9798871a
1 file changed
+4 -8
+4 -8
View File
@@ -7,7 +7,7 @@ if ! make >/dev/null; then
exit 1
fi
for i in `ls tests/*.c`; do
find tests -name '*.c' | sort | while read -r i; do
testname=$(basename "$i" .c)
echo -ne "$testname... "
if gcc -o "tests/$testname" -pthread "$i" liblockdep.a -Iinclude -D__USE_LIBLOCKDEP &&
@@ -16,12 +16,10 @@ for i in `ls tests/*.c`; do
else
echo "FAILED!"
fi
if [ -f "tests/$testname" ]; then
rm tests/$testname
fi
rm -f "tests/$testname"
done
for i in `ls tests/*.c`; do
find tests -name '*.c' | sort | while read -r i; do
testname=$(basename "$i" .c)
echo -ne "(PRELOAD) $testname... "
if gcc -o "tests/$testname" -pthread -Iinclude "$i" &&
@@ -30,7 +28,5 @@ for i in `ls tests/*.c`; do
else
echo "FAILED!"
fi
if [ -f "tests/$testname" ]; then
rm tests/$testname
fi
rm -f "tests/$testname"
done