BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 22:37:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

md-cluster: Fix a memleak in an error handling path

Browse Source 
We know that 'bm_lockres' is NULL here, so 'lockres_free(bm_lockres)' is a
no-op. According to resource handling in case of error a few lines below,
it is likely that 'bitmap_free(bitmap)' was expected instead.

Fixes: b98938d16a ("md-cluster: introduce cluster_check_sync_size")

Signed-off-by: Christophe JAILLET <[email protected]>
Reviewed-by: Guoqing Jiang <[email protected]>
Signed-off-by: Shaohua Li <[email protected]>
This commit is contained in:
Christophe JAILLET authored and Shaohua Li committed 2017-04-14 08:08:29 -07:00
1 parent 78b6350dca
commit 835d89e92f
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/md/md-cluster.c
+1 -1
View File
@@ -1127,7 +1127,7 @@ int cluster_check_sync_size(struct mddev *mddev)
bm_lockres = lockres_init(mddev, str, NULL, 1);
if (!bm_lockres) {
pr_err("md-cluster: Cannot initialize %s\n", str);
lockres_free(bm_lockres);
bitmap_free(bitmap);
return -1;
}
bm_lockres->flags |= DLM_LKF_NOQUEUE;