mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 22:37:45 -04:00
cpuidle, riscv: Push RCU-idle into driver
Doing RCU-idle outside the driver, only to then temporarily enable it again, at least twice, before going idle is suboptimal. That is, once implicitly through the cpu_pm_*() calls and once explicitly doing ct_irq_*_irqon(). Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Tested-by: Tony Lindgren <[email protected]> Tested-by: Ulf Hansson <[email protected]> Reviewed-by: Anup Patel <[email protected]> Reviewed-by: Frederic Weisbecker <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]> Link: https://lore.kernel.org/r/[email protected]
This commit is contained in:
1 parent
bb7b112585
commit
8e9ab9e8da
1 file changed
+5
-4
@@ -121,12 +121,12 @@ static int __sbi_enter_domain_idle_state(struct cpuidle_device *dev,
|
||||
return -1;
|
||||
|
||||
/* Do runtime PM to manage a hierarchical CPU toplogy. */
|
||||
ct_irq_enter_irqson();
|
||||
if (s2idle)
|
||||
dev_pm_genpd_suspend(pd_dev);
|
||||
else
|
||||
pm_runtime_put_sync_suspend(pd_dev);
|
||||
ct_irq_exit_irqson();
|
||||
|
||||
ct_idle_enter();
|
||||
|
||||
if (sbi_is_domain_state_available())
|
||||
state = sbi_get_domain_state();
|
||||
@@ -135,12 +135,12 @@ static int __sbi_enter_domain_idle_state(struct cpuidle_device *dev,
|
||||
|
||||
ret = sbi_suspend(state) ? -1 : idx;
|
||||
|
||||
ct_irq_enter_irqson();
|
||||
ct_idle_exit();
|
||||
|
||||
if (s2idle)
|
||||
dev_pm_genpd_resume(pd_dev);
|
||||
else
|
||||
pm_runtime_get_sync(pd_dev);
|
||||
ct_irq_exit_irqson();
|
||||
|
||||
cpu_pm_exit();
|
||||
|
||||
@@ -251,6 +251,7 @@ static int sbi_dt_cpu_init_topology(struct cpuidle_driver *drv,
|
||||
* of a shared state for the domain, assumes the domain states are all
|
||||
* deeper states.
|
||||
*/
|
||||
drv->states[state_count - 1].flags |= CPUIDLE_FLAG_RCU_IDLE;
|
||||
drv->states[state_count - 1].enter = sbi_enter_domain_idle_state;
|
||||
drv->states[state_count - 1].enter_s2idle =
|
||||
sbi_enter_s2idle_domain_idle_state;
|
||||
|
||||
Reference in new issue
Block a user