BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

lib: Fix atomic64_add_unless return value convention

Browse Source 
atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The generic implementation did the opposite thing.

Reported-by: H. Peter Anvin <[email protected]>
Confirmed-by: Paul Mackerras <[email protected]>
Signed-off-by: Luca Barbieri <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: H. Peter Anvin <[email protected]>
This commit is contained in:
Luca Barbieri authored and H. Peter Anvin committed 2010-03-01 11:38:46 -08:00
1 parent 6e6104fe08
commit 97577896f6
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
lib/atomic64.c
+2 -2
View File
@@ -162,12 +162,12 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u)
{
unsigned long flags;
spinlock_t *lock = lock_addr(v);
int ret = 1;
int ret = 0;
spin_lock_irqsave(lock, flags);
if (v->counter != u) {
v->counter += a;
ret = 0;
ret = 1;
}
spin_unlock_irqrestore(lock, flags);
return ret;