mirror of
https://github.com/torvalds/linux.git
synced 2026-09-25 21:21:09 -04:00
net: pasemi: fix error return code in pasemi_mac_open()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes:72b05b9940("pasemi_mac: RX/TX ring management cleanup") Fixes:8d636d8bc5("pasemi_mac: jumbo frame support") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zhang Changzhong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
This commit is contained in:
committed by
Jakub Kicinski
parent
ff9924897f
commit
aba84871bd
@@ -1078,16 +1078,20 @@ static int pasemi_mac_open(struct net_device *dev)
|
||||
|
||||
mac->tx = pasemi_mac_setup_tx_resources(dev);
|
||||
|
||||
if (!mac->tx)
|
||||
if (!mac->tx) {
|
||||
ret = -ENOMEM;
|
||||
goto out_tx_ring;
|
||||
}
|
||||
|
||||
/* We might already have allocated rings in case mtu was changed
|
||||
* before interface was brought up.
|
||||
*/
|
||||
if (dev->mtu > 1500 && !mac->num_cs) {
|
||||
pasemi_mac_setup_csrings(mac);
|
||||
if (!mac->num_cs)
|
||||
if (!mac->num_cs) {
|
||||
ret = -ENOMEM;
|
||||
goto out_tx_ring;
|
||||
}
|
||||
}
|
||||
|
||||
/* Zero out rmon counters */
|
||||
|
||||
Reference in New Issue
Block a user