mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 05:31:08 -04:00
perf session: Don't count per evsel events
PERF_RECORD_SAMPLE was not being counted here and is the only per-evsel thing anyway, the other events were not mapping to a evsel. With this we don't require that evsels used with a perf_session need to have space for hists, like the ones in annotate, report, top. Cc: Adrian Hunter <[email protected]> Cc: Borislav Petkov <[email protected]> Cc: David Ahern <[email protected]> Cc: Don Zickus <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Jean Pihet <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Mike Galbraith <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
This commit is contained in:
1 parent
4ea062ed43
commit
c2329ade22
1 file changed
-16
@@ -813,22 +813,6 @@ int perf_session__deliver_event(struct perf_session *session,
|
||||
dump_event(session, event, file_offset, sample);
|
||||
|
||||
evsel = perf_evlist__id2evsel(session->evlist, sample->id);
|
||||
if (evsel != NULL && event->header.type != PERF_RECORD_SAMPLE) {
|
||||
/*
|
||||
* XXX We're leaving PERF_RECORD_SAMPLE unnacounted here
|
||||
* because the tools right now may apply filters, discarding
|
||||
* some of the samples. For consistency, in the future we
|
||||
* should have something like nr_filtered_samples and remove
|
||||
* the sample->period from total_sample_period, etc, KISS for
|
||||
* now tho.
|
||||
*
|
||||
* Also testing against NULL allows us to handle files without
|
||||
* attr.sample_id_all and/or without PERF_SAMPLE_ID. In the
|
||||
* future probably it'll be a good idea to restrict event
|
||||
* processing via perf_session to files with both set.
|
||||
*/
|
||||
hists__inc_nr_events(evsel__hists(evsel), event->header.type);
|
||||
}
|
||||
|
||||
machine = perf_session__find_machine_for_cpumode(session, event,
|
||||
sample);
|
||||
|
||||
Reference in new issue
Block a user