BackPup/Linux
1
0 Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-07 05:31:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

scsi: target_core_user: fix double unlock

Browse Source 
The caller of queue_cmd_ring grabs and releases the lock, so the
tcmu_setup_cmd_timer failure handling inside queue_cmd_ring should not call
mutex_unlock.

Signed-off-by: Mike Christie <[email protected]>
Reviewed-by: Xiubo Li <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
This commit is contained in:
Mike Christie authored and Martin K. Petersen committed 2018-07-30 23:17:53 -04:00
1 parent 807cf197fc
commit f0e89aae60
1 file changed
-1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/target/target_core_user.c
-1
View File
@@ -1066,7 +1066,6 @@ static sense_reason_t queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, int *scsi_err)
&udev->cmd_timer);
if (ret) {
tcmu_cmd_free_data(tcmu_cmd, tcmu_cmd->dbi_cnt);
mutex_unlock(&udev->cmdr_lock);
*scsi_err = TCM_OUT_OF_RESOURCES;
return -1;