virtio_console: eliminate anonymous module_init & module_exit

Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs

Signed-off-by: Randy Dunlap <[email protected]>
Reviewed-by: Amit Shah <[email protected]>
Cc: [email protected]
Cc: Arnd Bergmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit is contained in:
Randy Dunlap authored and Greg Kroah-Hartman committed 2022-03-18 13:45:55 +01:00
1 parent 6aec3bfe38
commit fefb8a2a94
1 file changed
+4 -4
+4 -4
View File
@@ -2238,7 +2238,7 @@ static struct virtio_driver virtio_rproc_serial = {
.remove = virtcons_remove,
};
static int __init init(void)
static int __init virtio_console_init(void)
{
int err;
@@ -2273,7 +2273,7 @@ free:
return err;
}
static void __exit fini(void)
static void __exit virtio_console_fini(void)
{
reclaim_dma_bufs();
@@ -2283,8 +2283,8 @@ static void __exit fini(void)
class_destroy(pdrvdata.class);
debugfs_remove_recursive(pdrvdata.debugfs_dir);
}
module_init(init);
module_exit(fini);
module_init(virtio_console_init);
module_exit(virtio_console_fini);
MODULE_DESCRIPTION("Virtio console driver");
MODULE_LICENSE("GPL");