Removes dgap_savestring function to use kstrdup instead.
Signed-off-by: Mark Hounschell <[email protected]>
Tested-by: Mark Hounschell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This patch removes an unnecessary test. We've already
tested it by the time we get here with no possiblity
of it being changed.
Signed-off-by: Mark Hounschell <[email protected]>
Tested-by: Mark Hounschell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The sniff buffer was a /proc filesystem file. This
module no longer uses /proc. This patch removes
the deaed code associated with the sniff buffer.
Signed-off-by: Mark Hounschell <[email protected]>
Tested-by: Mark Hounschell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This patch fixes a smatch warning about an unsigned
integer being tested for less than zero.
Signed-off-by: Mark Hounschell <[email protected]>
Tested-by: Mark Hounschell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
- If both of drivers are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Replaced all uses of printk() in wlan-ng with netdev_err / _warn
where a netdev exists. If a few cases where a netdev does not yet
exist, dev_ or pr_ was used.
Checkpatch complains about lines over 80 chars or split string
constants - the messages are just too long, keeping it completely
happy would make the code less readable.
Signed-off-by: Vitaly Osipov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Gathered together comments in front of multicast filtering block.
Signed-off-by: Denis Pithon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Replaced generic memcmp() with dedicated ether_addr_equal_unaligned()
call. I did not find any clue of u16 alignment for both addresses.
Signed-off-by: Denis Pithon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Some lines with more than 80 characters are converted in to multiple lines.
Signed-off-by: Paul Davies C <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Add blank lines after each declarations in drivers/staging/octeon-usb/octeon-hcd.c.
Signed-off-by: Paul Davies C <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
cvmx_usb_pipe fits into a cache-line so additional prefetches are not
really helping anything.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Fix bad function definitions in all files from drivers/staging/usbip directory
Signed-off-by: Pawel Lebioda <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Fix "Missing a blank line after declaration" style problems
for all files in drivers/staging/usbip.
Signed-off-by: Pawel Lebioda <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the following checkpatch warning:
rtl8712/rtl871x_security.c
- 1178: WARNING: Avoid unnecessary line continuations
Signed-off-by: Marcus Farkas <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the following checkpatch warnings:
rtl8712/rtl871x_security.c
- 1167: WARNING: Unnecessary parentheses - maybe == should be = ?
- 1374: WARNING: Unnecessary parentheses - maybe == should be = ?
Signed-off-by: Marcus Farkas <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the following checkpatch warnings:
rtl8712/rtl871x_security.c
- 275: WARNING: Missing a blank line after declarations
- 768: WARNING: Missing a blank line after declarations
- 801: WARNING: Missing a blank line after declarations
Signed-off-by: Marcus Farkas <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Fix potential leaks in the error paths of r8712_set_key(). In case the
algorithm specific checks fail, the function returns without enqueuing
or freeing the already allocated command and parameter structs. Use a
centralized exit path and make sure that all memory is freed correctly.
Detected by Coverity - CID 144370, 144371.
Signed-off-by: Christian Engelmayer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the
requested algorithm is not supported by the driver, the function returns
without freeing the already allocated 'param' struct. Move the input
verification to the beginning of the function so that the direct return is
safe. Detected by Coverity - CID 144373.
Signed-off-by: Christian Engelmayer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This is a patch to remove warnings reported
by checkpatch tool on cb_pcimdas.c file
Signed-off-by: Raghavendra Chandra Ganiga <[email protected]>
Reviewed-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>
Signed-off-by: Peter Senna Tschudin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret = e
return
- ret
+ 0
;
// </smpl>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This patch fixes a coding style issue for a line that was over 80 characters long.
Signed-off-by: John Church <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Copying 16 bits into an uninitialized 32 bit stack variable and then
byteswapping it can provide 'interesting' results.
Signed-off-by: Jes Sorensen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Masanari Iida