Commit Graph
19 Commits
Author SHA1 Message Date
Satoru Takeuchi c54c187907 PCI: cleanup MSI code
Cleanup MSI code as follows:

 - fix some types
 - fix strange local variable definition
 - delete unnecessary blank line
 - add comment to #endif which is far from corresponding #ifdef

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2007-02-07 15:50:06 -08:00
Satoru Takeuchi b7b09b1cdf ACPI: update comment
Fixing wrong description for acpi_gpe_sleep_prepare().

acpi_gpe_sleep_prepare() had only used on power off and was changed
to also used on entering some sleep state. However its description
isn't changed yet.

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Len Brown <[email protected]>
2006-11-06 15:19:51 -05:00
Satoru Takeuchi 8fa1d7d3b2 [PATCH] cpu-hotplug: release `workqueue_mutex' properly on CPU hot-remove
_cpu_down() acquires `workqueue_mutex' on its process, but doen't release it
if __cpu_disable() fails.

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
2006-10-28 11:30:55 -07:00
Satoru Takeuchi ca926e80dc [PATCH] doc: fixing cpu-hotplug documentation
Fixing cpu-hotplug documentation as follows:

 - moving confusing asterisk on additional_cpus descrition
 - fixing some typos
 - unifying indentation for source code and command line example

Signed-off-by: Satoru Takeuchi <[email protected]>
Cc: Ashok Raj <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
2006-10-20 10:26:43 -07:00
Satoru Takeuchi 0feaece977 [PATCH] sched: fixing wrong comment for find_idlest_cpu()
Fixing wrong comment for find_idlest_cpu().

Signed-off-by: Satoru Takeuchi <[email protected]>
Acked-by: Ingo Molnar <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
2006-10-03 08:04:07 -07:00
Satoru Takeuchi aa4f63cad4 IA64: PCI: dont disable irq which is not enabled
This patch prevents pcibios_disable_device() from disabling interrupts
of devices which is not enabled.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi 600812ecea acpiphp: add support for ioapic hot-remove
This patch adds support for ioapics hot-remove.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi 2318627965 PCI: assign ioapic resource at hotplug
We need to assign resources to ioapics being hot-added. This patch
changes pbus_assign_resources_sorted() to assign resources if the
ioapic has no assigned resources.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi d5cdb67236 acpiphp: disable bridges
Currently acpiphp calls pci_enable_device() against all
hot-added bridges, but acpiphp does not call pci_disable_device()
against them in hot-remove. So ioapic hot-remove would fail.
This patch fixes this issue.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi 0dad3510ee acpiphp: stop bus device before acpi_bus_trim
Contrary to PCI bridge hot-add, we need to follow the sequence below
for PCI bridge hot-removal.

  (1) Stop devices (detach drivers, remove from the global list, etc.)
  (2) Unbind ACPI node from the devices (remove the _PRT entries)
  (3) Remove devices (remove from the device list, etc.)

This patch fixes acpiphp driver to follow above sequence for P2P
bridge hot-removal.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi 24f8aa9b46 PCI: add pci_stop_bus_device
This patch adds pci_stop_bus_device() which stops a PCI device (detach
the driver, remove from the global list and so on) and any children.
This is needed for ACPI based PCI-to-PCI bridge hot-remove, and it will
be also needed for ACPI based PCI root bridge hot-remove.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi 9b1d19ee86 acpiphp: do not initialize existing ioapics
Currently acpiphp initializes all ioapics under the bus on which
hot-add event occured. It also initializes already working ioapics.
This patch fixes this bug.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi b99feebe59 acpiphp: initialize ioapics before starting devices
Currently acpiphp initializes ioapics after starting devices,
but ioapics should be initialized before starting devices.
This patch fixes this bug.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:54 -07:00
Satoru Takeuchi 287af2fbe9 acpiphp: set hpp values before starting devices
Currently acpiphp sets hpp values after starting devices, but
the values should be set before starting devices. This patch
fixes this bug.

Signed-off-by: Kenji Kaneshige <[email protected]>
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Kristen Carlson Accardi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:53 -07:00
Satoru Takeuchi 753388c2e9 PCI Hotplug: cleanup pcihp skeleton code.
Cleanup pcihp skeleton code.

Fix some typos and remove some unnecessary blank lines.

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2006-09-26 17:43:53 -07:00
Satoru Takeuchi a72391e42f [IA64] eliminate compile time warnings
This patch removes following compile time warnings:

drivers/pci/pci-sysfs.c: In function `pci_read_legacy_io':
drivers/pci/pci-sysfs.c:257: warning: implicit declaration of function `ia64_pci_legacy_read'
drivers/pci/pci-sysfs.c: In function `pci_write_legacy_io':
drivers/pci/pci-sysfs.c:280: warning: implicit declaration of function `ia64_pci_legacy_write'

It also fixes wrong definition of ia64_pci_legacy_write (type of `bus' is not
`pci_dev', but `pci_bus').

Signed-Off-By: Satoru Takeuchi <[email protected]>
Signed-off-by: Tony Luck <[email protected]>
2006-04-20 17:06:54 -07:00
Satoru Takeuchi ee6d4b6ef8 [IA64] eliminate compile time warnings
This is a trivial patch to remove following compile time warning:

arch/ia64/ia32/../../../fs/binfmt_elf.c:508: warning: 'randomize_stack_top' defined but not used

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Tony Luck <[email protected]>
2006-04-20 17:06:35 -07:00
Satoru Takeuchi e6d1ba5cd9 [IA64] simplify some condition checks in iosapic_check_gsi_range
Some condition checks on iosapic_check_gsi_range() can be omitted
because always `base <= end' is assured. This patch simplifies those
checks.

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Tony Luck <[email protected]>
2006-03-28 10:42:15 -08:00
Satoru Takeuchi 46cba3dcae [IA64] correct some messages and fixes some minor things
This patch corrects some wrong comments and a printk message.
It also fixes some minor things, and makes all lines fit in
80 columns.

Signed-off-by: Satoru Takeuchi <[email protected]>
Signed-off-by: Tony Luck <[email protected]>
2006-03-28 10:41:23 -08:00