Make sure we have a matching chip id high and one or the other
of the chip id low values.
Print the values if the probe fails.
Signed-off-by: Nicolas Kaiser <[email protected]>
Acked-by: Jarod Wilson <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
It looks to me like it was intended to check the return value
at this point.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Jean-François Moine <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
aemif_calc_rate() can return a negative error value, so all the
variables that get tested for this value need to be signed.
The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
(0xf << 26). Using a signed instead of an unsigned integer
shouldn't make a difference here.
Signed-off-by: Nicolas Kaiser <[email protected]>
Acked-by: Sekhar Nori <[email protected]>
Signed-off-by: Kevin Hilman <[email protected]>
A common do-while loop can be factored out from the end of
the branches.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Kevin Hilman <[email protected]>
It looks to me as if the second value of rate_err_array is intended
to be a decimal 625. However, with a leading 0 it becomes an octal
constant, and as such evaluates to a decimal 405.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
irq_of_parse_and_map() has an unsigned return type.
Testing for a negative error value doesn't work here.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Fix typo in error message of dux commands allocation.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
wl1271_ps_elp_sleep() is void and cannot return a value.
Signed-off-by: Nicolas Kaiser <[email protected]>
Reviewed-by: Luciano Coelho <[email protected]>
Signed-off-by: Luciano Coelho <[email protected]>
I noticed that by factoring out common rounds from the
branches of the if-statements in the encryption and
decryption functions, the executable file size goes down
significantly, for crypto/cast5.ko from 26688 bytes
to 24336 bytes (amd64).
On my test system, I saw a slight speedup. This is the
first time I'm doing such a benchmark - I found a similar
one on the crypto mailing list, and I hope I did it right?
Before:
# cryptsetup create dm-test /dev/hda2 -c cast5-cbc-plain -s 128
Passsatz eingeben:
# dd if=/dev/zero of=/dev/mapper/dm-test bs=1M count=50
52428800 Bytes (52 MB) kopiert, 2,43484 s, 21,5 MB/s
# dd if=/dev/zero of=/dev/mapper/dm-test bs=1M count=50
52428800 Bytes (52 MB) kopiert, 2,4089 s, 21,8 MB/s
# dd if=/dev/zero of=/dev/mapper/dm-test bs=1M count=50
52428800 Bytes (52 MB) kopiert, 2,41091 s, 21,7 MB/s
After:
# cryptsetup create dm-test /dev/hda2 -c cast5-cbc-plain -s 128
Passsatz eingeben:
# dd if=/dev/zero of=/dev/mapper/dm-test bs=1M count=50
52428800 Bytes (52 MB) kopiert, 2,38128 s, 22,0 MB/s
# dd if=/dev/zero of=/dev/mapper/dm-test bs=1M count=50
52428800 Bytes (52 MB) kopiert, 2,29486 s, 22,8 MB/s
# dd if=/dev/zero of=/dev/mapper/dm-test bs=1M count=50
52428800 Bytes (52 MB) kopiert, 2,37162 s, 22,1 MB/s
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
I'm assuming it's not intended to instantly change the error code
from -ENODEV to -EIO, is it?
Signed-off-by: Nicolas Kaiser <[email protected]>
Acked-by: Harald Welte <[email protected]>
Signed-off-by: Dominik Brodowski <[email protected]>
If copy_from_user fails, the return value gets overwritten.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
If we continue on error, we'd likely free the IRQ that we
didn't get, right?
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
When block2mtd_erase fails, a duplicated assignment instantly
changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
It looks to me like this might not be intended, or is it?
Signed-off-by: Nicolas Kaiser <[email protected]>
Acked-By: Joern Engel <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
Simplify conditional: (a || (!a && !b)) => (a || !b)
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Tomi Valkeinen <[email protected]>
Including mux.h should no longer be needed for omap2/3/4 SoCs
outside arch/arm/mach-omap2 files.
Signed-off-by: Nicolas Kaiser <[email protected]>
Acked-by: Tony Lindgren <[email protected]>
Signed-off-by: Tomi Valkeinen <[email protected]>
The arguments were transposed, we want to assign the error code to
'ret', which is being returned.
Signed-off-by: Nicolas Kaiser <[email protected]>
Cc: [email protected]
Signed-off-by: Jens Axboe <[email protected]>
Don't descend to the EARLY_PRINTK_DBGP directory
unless it is actually used.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
checkpatch complains about this define:
WARNING: space prohibited between function name and open parenthesis '('
+#define GEN6_RENDER TIMEOUT_COUNTER_EXPIRED (1 << 6)
Signed-off-by: Nicolas Kaiser <[email protected]>
Acked-by: Zhenyu Wang <[email protected]>
Signed-off-by: Eric Anholt <[email protected]>
Fixed brace, macro and spacing coding style issues, and a C99 comment.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>
Fixed brace, static initialization, comment, whitespace and spacing
coding style issues.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Don't descend to wireless unless it is actually used.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Don't descend to wireless and ieee802154 unless they are actually used.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Remove duplicated defines.
(From their use it looks like 'midiDataOutx are written to
rather than read from.)
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
Signed-off-by: Jaroslav Kysela <[email protected]>
Add three files not mentioned in Documentation/powerpc/00-INDEX.
Sort alphabetically.
Signed-off-by: Nicolas Kaiser <[email protected]>
Signed-off-by: Paul Mackerras <[email protected]>
Nicolas Kaiser