Commit Graph
16 Commits
Author SHA1 Message Date
Claudio Scordino b717727ef2 umc-bus.c: fix usage of device_trylock
Fix usage of device_trylock. It has the same semantics of mutex_trylock, so it
returns 1 if the lock has been acquired successfully.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Bruno Morelli <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2012-10-25 11:39:31 -07:00
Claudio Scordino dbf1115d3f atmel_serial: fix spinlock lockup in RS485 code
Patch to fix a spinlock lockup in the driver that sometimes happens when the
tasklet starts.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Dave Bender <[email protected]>
Tested-by: Dave Bender <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
Acked-by: Alan Cox <[email protected]>
Cc: stable <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2012-01-04 16:19:34 -08:00
Claudio Scordino b53fc7c297 fs/proc/meminfo.c: fix compilation error
Fix the error message "directives may not be used inside a macro argument"
which appears when the kernel is compiled for the cris architecture.

Signed-off-by: Claudio Scordino <[email protected]>
Cc: Andrea Arcangeli <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
2011-12-09 07:50:28 -08:00
Claudio Scordino 91a13c281d drivers/base/node.c: fix compilation error with older versions of gcc
Patch to fix the error message "directives may not be used inside a macro
argument" which appears when the kernel is compiled for the cris architecture.

Signed-off-by: Claudio Scordino <[email protected]>
Acked-by: David Rientjes <[email protected]>
Cc: stable <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-11-18 10:39:24 -08:00
Claudio Scordino 93f3350c46 RS485: fix inconsistencies in the meaning of some variables
The crisv10.c and the atmel_serial.c serial drivers intepret the fields of the
serial_rs485 structure in a different way.

In particular, crisv10.c uses SER_RS485_RTS_AFTER_SEND and
SER_RS485_RTS_ON_SEND for the voltage of the RTS pin; atmel_serial.c,
instead, uses these values to know if a delay must be set before and
after sending.  This patch makes the usage of these variables consistent
across all drivers and fixes the Documentation as well.

From now on, SER_RS485_RTS_AFTER_SEND and SER_RS485_RTS_ON_SEND will be
used to set the voltage of the RTS pin (as in the crisv10.c driver); the
delay will be understood by looking only at the value of
delay_rts_before_send and delay_rts_after_send.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Darron Black <[email protected]>
Acked-by: Jesper Nilsson <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
Acked-by: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-11-15 12:13:44 -08:00
Claudio Scordino 5dfbd1d734 atmel_serial: fix RTS high after initialization in RS485 mode
When working in RS485 mode, the atmel_serial driver keeps RTS high after
the initialization of the serial port.  It goes low only after the first
character has been sent.

[[email protected]: simplify code]
Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Arkadiusz Bubala <[email protected]>
Tested-by: Arkadiusz Bubala <[email protected]>
Cc: Nicolas Ferre <[email protected]>
Cc: Greg KH <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
2011-01-13 17:32:31 -08:00
Claudio Scordino 63295cb2ff serial: add Documentation about RS485 serial communications
Documentation about RS485 serial communications

Signed-off-by: Claudio Scordino <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Acked-by: Russell King <[email protected]>
Acked-by: Grant Edwards <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-11-11 11:35:59 -08:00
Claudio Scordino 1b6331848b serial: general fixes in the serial_rs485 structure
Fix several issues related to the RS485 interface:

 - It adds the flag SER_RS485_RTS_BEFORE_SEND that was missing from the
   serial_rs485 structure (even if "delay_rts_before_send" was existing)

 - It adds a further "delay_rts_after_send" field for those drivers that
   can have a delay after send (e.g., atmel_serial)

 - It fixes the usage of the structure in the atmel_serial driver (where
   "delay_rts_before_send" should be used instead of "delay_rts_after_send").

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Bernhard Roth <[email protected]>
Cc: Philippe De Muyter <[email protected]>
Cc: Alan Cox <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-08-10 13:47:45 -07:00
Claudio Scordino f1d23ed821 CRIS: ioctl for getting RS485 information
Add ioctl to CRIS serial driver to get RS485 data from user-space.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Jesper Nilsson <[email protected]>
2010-08-09 14:10:32 +02:00
Claudio Scordino e8faff7330 ARM: 6092/1: atmel_serial: support for RS485 communications
Final version of the patch that adds support for RS485 communications to the atmel_serial driver.

The patch has been already sent and discussed on both linux-kernel and linux-arm-kernel mailing lists several times.

Many people collaborated to improve and test the code:

Tested-by: Sebastian Heutling <[email protected]>
Tested-by: Bernhard Roth <[email protected]>
Reviewed-by: Ryan Mallon <[email protected]>
Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Michael Trimarchi <[email protected]>
Signed-off-by: Rick Bronson <[email protected]>
Signed-off-by: Sebastian Heutling <[email protected]>
Signed-off-by: Russell King <[email protected]>
2010-05-04 16:59:11 +01:00
Claudio Scordino 93f6ced9e4 atmel_lcdfb.c: fix printk() type mismatch
This patch fixes a type mismatch when calling dev_info() in the
atmel_lcdfb.c driver.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
2009-11-09 09:40:58 +01:00
Claudio Scordino 6603a4fd51 ARM: 5776/1: Check compiler version and EABI support when adding ARM unwind support.
ARM unwind is known to compile only with EABI and not-buggy compilers.
The problem is not the unwinding information but the -fno-frame-pointer
option added as a result of !CONFIG_FRAME_POINTER.  Now we check the
compiler and raise a #warning in case of wrong compiler.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Russell King <[email protected]>
2009-11-02 16:59:45 +00:00
Claudio Scordino e4af3bf633 mtd: atmel_nand: unused variable removed
Unused variable "eccpos" removed from atmel_nand driver.

Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
2009-10-08 09:39:54 +01:00
Claudio Scordino 6fd1af4cf9 tty: Use the generic RS485 ioctl on CRIS
Use the new general RS485 Linux data structure (introduced by Alan with
commit number c26c56c0f4) in the Cris
architecture too (currently, Cris still uses the old private data
structure instead of the new one).

Signed-off-by: Claudio Scordino <[email protected]>
Tested-by: Hinko Kocevar <[email protected]>
Tested-by: Janez Cufer <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
2009-04-07 08:44:05 -07:00
Claudio Scordino 47fee6fedd Unused variable 'reg' removed.
Signed-off-by: Claudio Scordino <[email protected]>
Signed-off-by: Sascha Hauer <[email protected]>
2008-12-16 14:58:44 +01:00
Claudio Scordino f58e2c33ff sched: new documentation about CFS
Rewrite of the CFS documentation - because the old one was sorely
out-dated.

Signed-off-by: Claudio Scordino <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
2008-08-21 08:17:24 +02:00