mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
test: remove extraneous report validation argument
The second argument passed to validate() and validateContent() is not used for anything. PR-URL: https://github.com/nodejs/node/pull/25986 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
8 files changed
+8
-30
No files matched your search
@@ -21,8 +21,5 @@ if (process.argv[2] === 'child') {
|
||||
' experimental feature. This feature could change at any time'), std_msg);
|
||||
const reportFiles = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.deepStrictEqual(reportFiles, [], report_msg);
|
||||
helper.validateContent(child.stdout, { pid: child.pid,
|
||||
commandline: process.execPath +
|
||||
' ' + args.join(' ')
|
||||
});
|
||||
helper.validateContent(child.stdout);
|
||||
}
|
||||
@@ -23,8 +23,6 @@ if (process.argv[2] === 'child') {
|
||||
const reports = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.strictEqual(reports.length, 1, report_msg);
|
||||
const report = reports[0];
|
||||
helper.validate(report, { pid: child.pid,
|
||||
commandline: child.spawnargs.join(' ')
|
||||
});
|
||||
helper.validate(report);
|
||||
}));
|
||||
}
|
||||
@@ -25,9 +25,6 @@ if (process.argv[2] === 'child') {
|
||||
const reports = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.strictEqual(reports.length, 1, report_msg);
|
||||
const report = reports[0];
|
||||
helper.validate(report, { pid: child.pid,
|
||||
commandline: child.spawnargs.join(' '),
|
||||
expectedException: 'Testing error handling',
|
||||
});
|
||||
helper.validate(report);
|
||||
}));
|
||||
}
|
||||
@@ -126,8 +126,6 @@ if (process.argv[2] === 'child') {
|
||||
assert.deepStrictEqual(udp, 1, udp_msg);
|
||||
|
||||
// Common report tests.
|
||||
helper.validateContent(stdout, { pid: child.pid,
|
||||
commandline: child.spawnargs.join(' ')
|
||||
});
|
||||
helper.validateContent(stdout);
|
||||
}));
|
||||
}
|
||||
@@ -22,8 +22,6 @@ if (process.argv[2] === 'child') {
|
||||
const reports = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.strictEqual(reports.length, 1, report_msg);
|
||||
const report = reports[0];
|
||||
helper.validate(report, { pid: child.pid,
|
||||
commandline: child.spawnargs.join(' ')
|
||||
});
|
||||
helper.validate(report);
|
||||
}));
|
||||
}
|
||||
@@ -37,8 +37,6 @@ if (process.argv[2] === 'child') {
|
||||
const reports = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.strictEqual(reports.length, 1, report_msg);
|
||||
const report = reports[0];
|
||||
helper.validate(report, { pid: child.pid,
|
||||
commandline: child.spawnargs.join(' ')
|
||||
});
|
||||
helper.validate(report);
|
||||
}));
|
||||
}
|
||||
@@ -33,12 +33,6 @@ if (process.argv[2] === 'child') {
|
||||
const reports = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.strictEqual(reports.length, 1);
|
||||
const report = reports[0];
|
||||
const options = { pid: child.pid };
|
||||
// Node.js currently overwrites the command line on AIX
|
||||
// https://github.com/nodejs/node/issues/10607
|
||||
if (!(common.isAIX || common.isSunOS)) {
|
||||
options.commandline = child.spawnargs.join(' ');
|
||||
}
|
||||
helper.validate(report, options);
|
||||
helper.validate(report);
|
||||
}));
|
||||
}
|
||||
@@ -73,8 +73,6 @@ if (process.argv[2] === 'child') {
|
||||
const reports = helper.findReports(child.pid, tmpdir.path);
|
||||
assert.deepStrictEqual(reports.length, 1, report_msg);
|
||||
const report = reports[0];
|
||||
helper.validate(report, { pid: child.pid,
|
||||
commandline: child.spawnargs.join(' ')
|
||||
});
|
||||
helper.validate(report);
|
||||
}));
|
||||
}
|
||||
Reference in new issue
Block a user