mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
readline: don't cache the "keypress" listeners
it's not safe to since `removeAllListeners()` will detach the returned Array from the stream instance if that's ever called by the user.
This commit is contained in:
1 parent
c9a1b5d162
commit
032fc42e64
1 file changed
+2
-4
+2
-4
@@ -786,10 +786,8 @@ function emitKeypressEvents(stream) {
|
||||
if (stream._emitKeypress) return;
|
||||
stream._emitKeypress = true;
|
||||
|
||||
var keypressListeners = stream.listeners('keypress');
|
||||
|
||||
function onData(b) {
|
||||
if (keypressListeners.length) {
|
||||
if (stream.listeners('keypress').length > 0) {
|
||||
emitKey(stream, b);
|
||||
} else {
|
||||
// Nobody's watching anyway
|
||||
@@ -805,7 +803,7 @@ function emitKeypressEvents(stream) {
|
||||
}
|
||||
}
|
||||
|
||||
if (keypressListeners.length) {
|
||||
if (stream.listeners('keypress').length > 0) {
|
||||
stream.on('data', onData);
|
||||
} else {
|
||||
stream.on('newListener', onNewListener);
|
||||
|
||||
Reference in new issue
Block a user