mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
test: improve assertion fail messages
PR-URL: https://github.com/nodejs/node/pull/14949 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
1 parent
e76b1ff17e
commit
0ce54a7ec9
1 file changed
+16
-7
@@ -33,8 +33,14 @@ assert.ok(!(undefined instanceof Writable));
|
||||
|
||||
// Simple inheritance check for `Writable` works fine in a subclass constructor.
|
||||
function CustomWritable() {
|
||||
assert.ok(this instanceof Writable, 'inherits from Writable');
|
||||
assert.ok(this instanceof CustomWritable, 'inherits from CustomWritable');
|
||||
assert.ok(
|
||||
this instanceof CustomWritable,
|
||||
`${this} does not inherit from CustomWritable`
|
||||
);
|
||||
assert.ok(
|
||||
this instanceof Writable,
|
||||
`${this} does not inherit from Writable`
|
||||
);
|
||||
}
|
||||
|
||||
Object.setPrototypeOf(CustomWritable, Writable);
|
||||
@@ -42,8 +48,11 @@ Object.setPrototypeOf(CustomWritable.prototype, Writable.prototype);
|
||||
|
||||
new CustomWritable();
|
||||
|
||||
assert.throws(CustomWritable,
|
||||
common.expectsError({
|
||||
code: 'ERR_ASSERTION',
|
||||
message: /^inherits from Writable$/
|
||||
}));
|
||||
common.expectsError(
|
||||
CustomWritable,
|
||||
{
|
||||
code: 'ERR_ASSERTION',
|
||||
type: assert.AssertionError,
|
||||
message: 'undefined does not inherit from CustomWritable'
|
||||
}
|
||||
);
|
||||
Reference in new issue
Block a user