mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
timers: do not expose .unref()._handle._list
The list is defunct at this point.
I believe this to be in effect a minor defect from
3eecdf9f14
PR-URL: https://github.com/nodejs/node/pull/8422
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
1 parent
87bdddaf41
commit
11f7dcf91e
2 files changed
+17
No files matched your search
@@ -598,6 +598,9 @@ Timeout.prototype.unref = function() {
|
||||
}
|
||||
|
||||
var handle = reuse(this);
|
||||
if (handle) {
|
||||
handle._list = undefined;
|
||||
}
|
||||
|
||||
this._handle = handle || new TimerWrap();
|
||||
this._handle.owner = this;
|
||||
|
||||
@@ -0,0 +1,14 @@
|
||||
'use strict';
|
||||
|
||||
require('../common');
|
||||
const assert = require('assert');
|
||||
|
||||
const timer1 = setTimeout(() => {}, 1).unref();
|
||||
assert.strictEqual(timer1._handle._list, undefined,
|
||||
'timer1._handle._list should be undefined');
|
||||
|
||||
// Check that everything works even if the handle was not re-used.
|
||||
setTimeout(() => {}, 1);
|
||||
const timer2 = setTimeout(() => {}, 1).unref();
|
||||
assert.strictEqual(timer2._handle._list, undefined,
|
||||
'timer2._handle._list should be undefined');
|
||||
Reference in new issue
Block a user