mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
deps: V8: cherry-pick 19173cde61d8
Original commit message:
Make TagRange build without __builtin_unreachable
Guard the call with V8_HAS_BUILTIN_UNREACHABLE, if it's not
available in the toolchain, skip the compiler hint so it still
compiles.
Co-Authored-By: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Refs: https://github.com/nodejs/node/pull/61898
Change-Id: Ided07825644ffdd5b6aa7c6fa7f39ae3e62d2535
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8517724
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110422}
Refs: https://github.com/v8/v8/commit/19173cde61d86c96da741e10e4ccbb20e11794ad
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66601
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit is contained in:
1 parent
2589e42f48
commit
2d87c56f37
2 files changed
+2
-2
No files matched your search
+1
-1
@@ -44,7 +44,7 @@
|
||||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.7',
|
||||
'v8_embedder_string': '-node.8',
|
||||
|
||||
##### V8 defaults for Node.js #####
|
||||
|
||||
|
||||
Vendored
+1
-1
@@ -532,7 +532,7 @@ struct TagRange {
|
||||
|
||||
// Construct the inclusive tag range [first, last].
|
||||
constexpr TagRange(Tag first, Tag last) : first(first), last(last) {
|
||||
#ifdef V8_ENABLE_CHECKS
|
||||
#if defined(V8_ENABLE_CHECKS) && V8_HAS_BUILTIN_UNREACHABLE
|
||||
// This would typically be a DCHECK, but that's not available here.
|
||||
if (first > last) __builtin_unreachable(); // Invalid tag range.
|
||||
#endif
|
||||
|
||||
Reference in new issue
Block a user