mirror of
https://github.com/nodejs/node.git
synced 2026-10-10 18:59:49 -04:00
deps: backport 75e43a6 from v8 upstream
Note: chunk in test-heap.cc:1989 discarded as related code missing
from current version in node.
Original commit message:
Use static_cast<> for NULL (clang 3.7)
The following errors come up when compiling v8
with clang 3.7 on FreeBSD/amd64:
src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from
'nullptr_t' to 'v8::internal::Smi *' is not allowed
local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/cctest/test-heap.cc:131:20: error: reinterpret_cast from
'nullptr_t' to 'v8::internal::Object *' is not allowed
Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from
'nullptr_t' to 'Address' (aka 'unsigned char *') is not
allowed
Address base = reinterpret_cast<Address>(NULL);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+add myself to the AUTHORS file.
BUG=
Review URL: https://codereview.chromium.org/1277353002
Cr-Commit-Position: refs/heads/master@{#30103}
PR-URL: https://github.com/nodejs/node/pull/2636
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
1 parent
74ff9bc86c
commit
4593539b92
3 files changed
+3
-2
No files matched your search
Vendored
+1
@@ -69,6 +69,7 @@ Kang-Hao (Kenny) Lu <kennyluck@csail.mit.edu>
|
||||
Luis Reis <luis.m.reis@gmail.com>
|
||||
Luke Zarko <lukezarko@gmail.com>
|
||||
Maciej Małecki <me@mmalecki.com>
|
||||
Marcin Cieślak <saper@marcincieslak.com>
|
||||
Mathias Bynens <mathias@qiwi.be>
|
||||
Matt Hanselman <mjhanselman@gmail.com>
|
||||
Matthew Sporleder <msporleder@gmail.com>
|
||||
|
||||
Vendored
+1
-1
@@ -627,7 +627,7 @@ RUNTIME_FUNCTION(Runtime_CreateBreakIterator) {
|
||||
|
||||
local_object->SetInternalField(0, reinterpret_cast<Smi*>(break_iterator));
|
||||
// Make sure that the pointer to adopted text is NULL.
|
||||
local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));
|
||||
local_object->SetInternalField(1, static_cast<Smi*>(nullptr));
|
||||
|
||||
Factory* factory = isolate->factory();
|
||||
Handle<String> key = factory->NewStringFromStaticChars("breakIterator");
|
||||
|
||||
Vendored
+1
-1
@@ -126,7 +126,7 @@ TEST(HandleNull) {
|
||||
Isolate* isolate = CcTest::i_isolate();
|
||||
HandleScope outer_scope(isolate);
|
||||
LocalContext context;
|
||||
Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
|
||||
Handle<Object> n(static_cast<Object*>(nullptr), isolate);
|
||||
CHECK(!n.is_null());
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user