mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
test: increase coverage for stream
1. test addAbortSignal with invalid signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L17 2. test addAbortSignal with invalid stream Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L28 3. test addAbortSignalNoValidate with invalid signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L34 4. test addAbortSignalNoValidate with aborted signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40 5. test Readable.from with invalid args Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/from.js.html#L31 PR-URL: https://github.com/nodejs/node/pull/36538 Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This commit is contained in:
1 parent
aadb0bdc73
commit
4d22dd329b
3 files changed
+49
-1
No files matched your search
@@ -3,7 +3,13 @@
|
||||
const { mustCall } = require('../common');
|
||||
const { once } = require('events');
|
||||
const { Readable } = require('stream');
|
||||
const { strictEqual } = require('assert');
|
||||
const { strictEqual, throws } = require('assert');
|
||||
|
||||
{
|
||||
throws(() => {
|
||||
Readable.from(null);
|
||||
}, /ERR_INVALID_ARG_TYPE/);
|
||||
}
|
||||
|
||||
async function toReadableBasicSupport() {
|
||||
async function* generate() {
|
||||
|
||||
@@ -0,0 +1,27 @@
|
||||
// Flags: --expose-internals
|
||||
'use strict';
|
||||
|
||||
require('../common');
|
||||
const assert = require('assert');
|
||||
const { addAbortSignal, Readable } = require('stream');
|
||||
const {
|
||||
addAbortSignalNoValidate,
|
||||
} = require('internal/streams/add-abort-signal');
|
||||
|
||||
{
|
||||
assert.throws(() => {
|
||||
addAbortSignal('INVALID_SIGNAL');
|
||||
}, /ERR_INVALID_ARG_TYPE/);
|
||||
|
||||
const ac = new AbortController();
|
||||
assert.throws(() => {
|
||||
addAbortSignal(ac.signal, 'INVALID_STREAM');
|
||||
}, /ERR_INVALID_ARG_TYPE/);
|
||||
}
|
||||
|
||||
{
|
||||
const r = new Readable({
|
||||
read: () => {},
|
||||
});
|
||||
assert.deepStrictEqual(r, addAbortSignalNoValidate('INVALID_SIGNAL', r));
|
||||
}
|
||||
@@ -446,3 +446,18 @@ const assert = require('assert');
|
||||
write.write('asd');
|
||||
ac.abort();
|
||||
}
|
||||
|
||||
{
|
||||
const ac = new AbortController();
|
||||
ac.abort();
|
||||
|
||||
const write = new Writable({
|
||||
signal: ac.signal,
|
||||
write(chunk, enc, cb) { cb(); }
|
||||
});
|
||||
|
||||
write.on('error', common.mustCall((e) => {
|
||||
assert.strictEqual(e.name, 'AbortError');
|
||||
assert.strictEqual(write.destroyed, true);
|
||||
}));
|
||||
}
|
||||
Reference in new issue
Block a user