mirror of
https://github.com/nodejs/node.git
synced 2026-11-21 12:59:16 -05:00
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
1 parent
3c3a70dc5f
commit
5bc8f3bf1c
2 files changed
+5
-1
No files matched your search
+1
-1
@@ -36,7 +36,7 @@
|
||||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.3',
|
||||
'v8_embedder_string': '-node.4',
|
||||
|
||||
##### V8 defaults for Node.js #####
|
||||
|
||||
|
||||
Vendored
+4
@@ -61,7 +61,9 @@ class ScriptOriginOptions {
|
||||
*/
|
||||
class V8_EXPORT ScriptOrigin {
|
||||
public:
|
||||
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
|
||||
V8_DEPRECATED("Use constructor with primitive C++ types")
|
||||
#endif
|
||||
ScriptOrigin(
|
||||
Local<Value> resource_name, Local<Integer> resource_line_offset,
|
||||
Local<Integer> resource_column_offset,
|
||||
@@ -72,7 +74,9 @@ class V8_EXPORT ScriptOrigin {
|
||||
Local<Boolean> is_wasm = Local<Boolean>(),
|
||||
Local<Boolean> is_module = Local<Boolean>(),
|
||||
Local<Data> host_defined_options = Local<Data>());
|
||||
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
|
||||
V8_DEPRECATED("Use constructor that takes an isolate")
|
||||
#endif
|
||||
explicit ScriptOrigin(Local<Value> resource_name,
|
||||
int resource_line_offset = 0,
|
||||
int resource_column_offset = 0,
|
||||
|
||||
Reference in new issue
Block a user