BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

build: expose libplatform symbols in shared libnode

Browse Source 
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the
public symbols since we build with hidden visibility by default.

PR-URL: https://github.com/nodejs/node/pull/61144
Fixes: https://github.com/nodejs/node/issues/61102
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
This commit is contained in:
Joyee Cheung authored and GitHub committed 2026-01-05 13:08:06 +00:00
1 parent 6218d14505
commit 77c2b53834
2 files changed
+11
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

node.gypi
+2
View File
@@ -50,9 +50,11 @@
'defines': [
'USING_UV_SHARED',
'USING_V8_SHARED',
'USING_V8_PLATFORM_SHARED',
'BUILDING_NODE_EXTENSION'
],
'defines!': [
'BUILDING_V8_PLATFORM_SHARED=1',
'BUILDING_V8_SHARED=1',
'BUILDING_UV_SHARED=1'
]
tools/v8_gypfiles/v8.gyp
+9
View File
@@ -58,6 +58,7 @@
['OS!="aix" and OS!="os400"', {
'defines': [
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
'BUILDING_V8_PLATFORM_SHARED', # Make V8_PLATFORM_EXPORT visible.
]
}],
['node_shared=="true"', {
@@ -1345,6 +1346,7 @@
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
'BUILDING_V8_PLATFORM_SHARED',
],
}],
['v8_enable_i18n_support==1', {
@@ -1414,6 +1416,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'cflags_cc!': ['-fno-exceptions'],
'cflags_cc': ['-fexceptions'],
@@ -1440,6 +1443,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'cflags_cc!': ['-fno-exceptions'],
'cflags_cc': ['-fexceptions'],
@@ -1781,6 +1785,7 @@
],
'defines!': [
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'dependencies': [
'v8_libbase',
@@ -1862,6 +1867,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'cflags_cc!': ['-fno-exceptions'],
'cflags_cc': ['-fexceptions'],
@@ -1905,6 +1911,7 @@
'defines!': [
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_V8_PLATFORM_SHARED=1',
],
'msvs_settings': {
'VCCLCompilerTool': {
@@ -2119,10 +2126,12 @@
],
'defines': [
'BUILDING_V8_SHARED',
'BUILDING_V8_PLATFORM_SHARED',
],
'direct_dependent_settings': {
'defines': [
'USING_V8_SHARED',
'USING_V8_PLATFORM_SHARED',
],
},
'conditions': [