mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
test_runner: remove redundant report call
This commit removes a redundant call to `reportStarted()`. It is redundant because a few lines down, `subtest.finalize()` is called. `finalize()` will find the first test that is ready to report its data, and then call `report()`, which also calls `reportStarted()`. This will trigger the `'test:start'` as high up the test tree as necessary. PR-URL: https://github.com/nodejs/node/pull/52089 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
This commit is contained in:
1 parent
dafe004703
commit
97b2c5344d
1 file changed
-4
@@ -469,10 +469,6 @@ class Test extends AsyncResource {
|
||||
return;
|
||||
}
|
||||
|
||||
if (i === 1 && this.parent !== null) {
|
||||
this.reportStarted();
|
||||
}
|
||||
|
||||
// Report the subtest's results and remove it from the ready map.
|
||||
subtest.finalize();
|
||||
this.readySubtests.delete(i);
|
||||
|
||||
Reference in new issue
Block a user