BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

benchmark: use let instead of var in url

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/31794
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Daniele Belardi authored and Anna Henningsen committed 2020-03-30 10:16:20 +02:00
1 parent 8ec533d890
commit a33e9c9d80
3 files changed
+10 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

benchmark/url/legacy-vs-whatwg-url-parse.js
+5 -5
View File
@@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
function useLegacy(data) {
const len = data.length;
var result = url.parse(data[0]); // Avoid dead code elimination
let result = url.parse(data[0]); // Avoid dead code elimination
bench.start();
for (let i = 0; i < len; ++i) {
result = url.parse(data[i]);
@@ -24,7 +24,7 @@ function useLegacy(data) {
function useWHATWGWithBase(data) {
const len = data.length;
var result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination
let result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination
bench.start();
for (let i = 0; i < len; ++i) {
const item = data[i];
@@ -36,7 +36,7 @@ function useWHATWGWithBase(data) {
function useWHATWGWithoutBase(data) {
const len = data.length;
var result = new URL(data[0]); // Avoid dead code elimination
let result = new URL(data[0]); // Avoid dead code elimination
bench.start();
for (let i = 0; i < len; ++i) {
result = new URL(data[i]);
@@ -47,8 +47,8 @@ function useWHATWGWithoutBase(data) {
function main({ e, method, type, withBase }) {
withBase = withBase === 'true';
var noDead; // Avoid dead code elimination.
var data;
let noDead; // Avoid dead code elimination.
let data;
switch (method) {
case 'legacy':
data = common.bakeUrlData(type, e, false, false);
benchmark/url/legacy-vs-whatwg-url-serialize.js
+3 -3
View File
@@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
function useLegacy(data) {
const obj = url.parse(data[0]);
const len = data.length;
var noDead = url.format(obj);
let noDead = url.format(obj);
bench.start();
for (let i = 0; i < len; i++) {
noDead = data[i].toString();
@@ -25,7 +25,7 @@ function useLegacy(data) {
function useWHATWG(data) {
const obj = new URL(data[0]);
const len = data.length;
var noDead = obj.toString();
let noDead = obj.toString();
bench.start();
for (let i = 0; i < len; i++) {
noDead = data[i].toString();
@@ -37,7 +37,7 @@ function useWHATWG(data) {
function main({ type, e, method }) {
const data = common.bakeUrlData(type, e, false, false);
var noDead; // Avoid dead code elimination.
let noDead; // Avoid dead code elimination.
switch (method) {
case 'legacy':
noDead = useLegacy(data);
benchmark/url/whatwg-url-properties.js
+2 -2
View File
@@ -12,7 +12,7 @@ const bench = common.createBenchmark(main, {
function setAndGet(data, prop) {
const len = data.length;
var result = data[0][prop];
let result = data[0][prop];
bench.start();
for (let i = 0; i < len; ++i) {
result = data[i][prop];
@@ -24,7 +24,7 @@ function setAndGet(data, prop) {
function get(data, prop) {
const len = data.length;
var result = data[0][prop];
let result = data[0][prop];
bench.start();
for (let i = 0; i < len; ++i) {
result = data[i][prop]; // get