mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
test: move common.PORT tests to sequential
Reasons: - `test-async-wrap-getasyncid` binds a handle, so move to sequential because port cannot be already in use. - `test-dgram-implicit-bind-failure` requires a hardcoded port number to properly send socket packet. - `test-http-agent-uninitialized-with-handle` requires a hardcoded port number to properly send http request. - `test-http-agent-uninitialized` requires a hardcoded port number to properly send http request. - `test-net-localport` requires a hardcoded port number for assertions. In addition this replaces two common.PORTs with a dynamic port. PR-URL: https://github.com/nodejs/node/pull/15151 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
1 parent
45357d0556
commit
af15b755c0
5 files changed
+6
-4
No files matched your search
@@ -13,11 +13,12 @@ socket._handle = {
|
||||
ref() { },
|
||||
readStart() { },
|
||||
};
|
||||
const req = new http.ClientRequest(`http://localhost:${common.PORT}/`);
|
||||
|
||||
const server = http.createServer(common.mustCall((req, res) => {
|
||||
res.end();
|
||||
})).listen(common.PORT, common.mustCall(() => {
|
||||
})).listen(0, common.mustCall(() => {
|
||||
const req = new http.ClientRequest(`http://localhost:${server.address().port}/`);
|
||||
|
||||
// Manually add the socket without a _handle.
|
||||
agent.freeSockets[agent.getName(req)] = [socket];
|
||||
// Now force the agent to use the socket and check that _handle exists before
|
||||
|
||||
@@ -8,11 +8,12 @@ const agent = new http.Agent({
|
||||
keepAlive: true,
|
||||
});
|
||||
const socket = new net.Socket();
|
||||
const req = new http.ClientRequest(`http://localhost:${common.PORT}/`);
|
||||
|
||||
const server = http.createServer(common.mustCall((req, res) => {
|
||||
res.end();
|
||||
})).listen(common.PORT, common.mustCall(() => {
|
||||
})).listen(0, common.mustCall(() => {
|
||||
const req = new http.ClientRequest(`http://localhost:${server.address().port}/`);
|
||||
|
||||
// Manually add the socket without a _handle.
|
||||
agent.freeSockets[agent.getName(req)] = [socket];
|
||||
// Now force the agent to use the socket and check that _handle exists before
|
||||
|
||||
File renamed without changes.
File renamed without changes.
File renamed without changes.
Reference in new issue
Block a user