mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
util: add todo comments for inspect to add unicode support
PR-URL: https://github.com/nodejs/node/pull/31112 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
1 file changed
+7
@@ -1195,6 +1195,8 @@ function groupArrayElements(ctx, output, value) {
|
||||
if (columns <= 1) {
|
||||
return output;
|
||||
}
|
||||
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
|
||||
// function.
|
||||
const tmp = [];
|
||||
const maxLineLength = [];
|
||||
for (let i = 0; i < columns; i++) {
|
||||
@@ -1272,6 +1274,8 @@ function formatBigInt(fn, value) {
|
||||
function formatPrimitive(fn, value, ctx) {
|
||||
if (typeof value === 'string') {
|
||||
if (ctx.compact !== true &&
|
||||
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
|
||||
// function.
|
||||
value.length > kMinLineLength &&
|
||||
value.length > ctx.breakLength - ctx.indentationLvl - 4) {
|
||||
return value
|
||||
@@ -1617,6 +1621,9 @@ function isBelowBreakLength(ctx, output, start, base) {
|
||||
// Each entry is separated by at least a comma. Thus, we start with a total
|
||||
// length of at least `output.length`. In addition, some cases have a
|
||||
// whitespace in-between each other that is added to the total as well.
|
||||
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
|
||||
// function. Check the performance overhead and make it an opt-in in case it's
|
||||
// significant.
|
||||
let totalLength = output.length + start;
|
||||
if (totalLength + output.length > ctx.breakLength)
|
||||
return false;
|
||||
|
||||
Reference in new issue
Block a user