mirror of
https://github.com/nodejs/node.git
synced 2026-11-21 12:59:16 -05:00
deps: V8: cherry-pick 87ce4f5d98a5
Original commit message:
[ic] use CSA_DCHECK in CodeStubAssembler::SharedValueBarrier
Since the code is generated unconditionally, using a DCHECK to check
that shared RO heap is enabled breaks builds with
v8_enable_shared_ro_heap set to false, this patch turns that into a
CSA_DCHECK so it only crashes when V8 actually attempts to store into
a shared struct while the RO heap isn't shared at run time.
Refs: https://github.com/nodejs/node/pull/42115
Bug: v8:12547
Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#79756}
Refs: https://github.com/v8/v8/commit/87ce4f5d98a5ee4e32a0545001a2d58be61a6e8d
PR-URL: https://github.com/nodejs/node/pull/42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This commit is contained in:
2 files changed
+2
-2
No files matched your search
+1
-1
@@ -36,7 +36,7 @@
|
||||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.7',
|
||||
'v8_embedder_string': '-node.8',
|
||||
|
||||
##### V8 defaults for Node.js #####
|
||||
|
||||
|
||||
+1
-1
@@ -15953,7 +15953,7 @@ void CodeStubAssembler::SharedValueBarrier(
|
||||
GotoIf(TaggedIsSmi(value), &done);
|
||||
// Fast path: Shared memory features imply shared RO space, so RO objects are
|
||||
// trivially shared.
|
||||
DCHECK(ReadOnlyHeap::IsReadOnlySpaceShared());
|
||||
CSA_DCHECK(this, BoolConstant(ReadOnlyHeap::IsReadOnlySpaceShared()));
|
||||
TNode<IntPtrT> page_flags = LoadBasicMemoryChunkFlags(CAST(value));
|
||||
GotoIf(WordNotEqual(WordAnd(page_flags,
|
||||
IntPtrConstant(BasicMemoryChunk::READ_ONLY_HEAP)),
|
||||
|
||||
Reference in new issue
Block a user