mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
build: consolidate JS and md linting GitHub Actions
Linting markdown runs the JavaScript linting job, so consolidate them to conserve time and resources. Run JavaScript separately, but then run markdown linting so it can use the cached results of the JavaScript linting. PR-URL: https://github.com/nodejs/node/pull/42572 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
1 parent
d83e7a0b77
commit
df20947e69
1 file changed
+11
-25
@@ -49,31 +49,7 @@ jobs:
|
||||
run: npx envinfo
|
||||
- name: Lint C/C++ files
|
||||
run: make lint-cpp
|
||||
lint-md:
|
||||
if: github.event.pull_request.draft == false
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
with:
|
||||
persist-credentials: false
|
||||
- name: Use Node.js ${{ env.NODE_VERSION }}
|
||||
uses: actions/setup-node@v3
|
||||
with:
|
||||
node-version: ${{ env.NODE_VERSION }}
|
||||
- name: Environment Information
|
||||
run: npx envinfo
|
||||
- name: Get release version numbers
|
||||
if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
|
||||
id: get-released-versions
|
||||
run: ./tools/lint-md/list-released-versions-from-changelogs.mjs
|
||||
- name: Lint docs
|
||||
run: |
|
||||
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"
|
||||
NODE=$(command -v node) make lint-md
|
||||
env:
|
||||
NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }}
|
||||
|
||||
lint-js:
|
||||
lint-js-and-md:
|
||||
if: github.event.pull_request.draft == false
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
@@ -88,6 +64,16 @@ jobs:
|
||||
run: npx envinfo
|
||||
- name: Lint JavaScript files
|
||||
run: NODE=$(command -v node) make lint-js
|
||||
- name: Get release version numbers
|
||||
if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
|
||||
id: get-released-versions
|
||||
run: ./tools/lint-md/list-released-versions-from-changelogs.mjs
|
||||
- name: Lint markdown files
|
||||
run: |
|
||||
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"
|
||||
NODE=$(command -v node) make lint-md
|
||||
env:
|
||||
NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }}
|
||||
lint-py:
|
||||
if: github.event.pull_request.draft == false
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
Reference in new issue
Block a user