BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
32,856 Commits 266 Branches 972 Tags
03380bc16aaf731bc599dec4baf4f5668635f587
Commit Graph
32856 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Benjamin Gruenbaum 03380bc16a stream: improve Readable.from error handling 
PR-URL: https://github.com/nodejs/node/pull/37158
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-02-03 12:04:37 +02:00
Ruy Adorno 861a396a4a deps: upgrade npm to 7.5.2 
PR-URL: https://github.com/nodejs/node/pull/37191
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2021-02-02 21:13:40 -08:00
Filip Skokan a8d7de1efb crypto: add keyObject.export() 'jwk' format option 
Adds [JWK](https://tools.ietf.org/html/rfc7517) keyObject.export format
option.

Supported key types: `ec`, `rsa`, `ed25519`, `ed448`, `x25519`, `x448`,
and symmetric keys, resulting in JWK `kty` (Key Type) values `EC`,
`RSA`, `OKP`, and `oct`.

`rsa-pss` is not supported since the JWK format does not support
PSS Parameters.

`EC` JWK curves supported are `P-256`, `secp256k1`, `P-384`, and `P-521`

PR-URL: https://github.com/nodejs/node/pull/37081
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-02-02 23:16:51 +01:00
Michaël Zasso 211574b0c2 2021-02-02, Version 15.8.0 (Current) 
Notable changes:

crypto:
  * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) https://github.com/nodejs/node/pull/36997
  * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) https://github.com/nodejs/node/pull/36879
deps:
  * upgrade npm to 7.5.0 (Ruy Adorno) https://github.com/nodejs/node/pull/37117
dgram:
  * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) https://github.com/nodejs/node/pull/37026
doc:
  * add Zijian Liu to collaborators (ZiJian Liu) https://github.com/nodejs/node/pull/37075
esm:
  * deprecate legacy main lookup for modules (Guy Bedford) https://github.com/nodejs/node/pull/36918
readline:
  * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) https://github.com/nodejs/node/pull/33662
  * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) https://github.com/nodejs/node/pull/33676

PR-URL: https://github.com/nodejs/node/pull/37183
 2021-02-02 21:50:24 +01:00
James M Snell c973d503e0 tls: add ability to get cert/peer cert as X509Certificate object 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37070
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2021-02-02 09:39:27 -08:00
Rich Trott 84e41d27da test: split heap snapshot limit tests 
test/parallel/test-heapsnapshot-near-heap-limit.js is timing out in CI
on low-memory and slow-CPU devices. Split off the worker test to its own
test file to allow the test to finish in time.

Refs: https://github.com/nodejs/node/issues/36961
PR-URL: https://github.com/nodejs/node/pull/37189
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-02-02 09:25:39 -08:00
Antoine du Hamel b750f74b67 doc: fix color contrast on <kbd> elements 
PR-URL: https://github.com/nodejs/node/pull/37185
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-02 14:43:20 +01:00
James Addison a0c0875e42 src: read exactly two tokens from Linux THP sysfs config 
There was an unexpected and hard-to-spot issue here:
the /sys/kernel/mm/transparent_hugepage/enabled file contains three
entries, and the std::ifstream reader was reading two values on each
loop iteration, resulting in incorrect behaviour.

Fixes: https://github.com/nodejs/node/issues/37064

PR-URL: https://github.com/nodejs/node/pull/37065
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-02 18:54:09 +05:30
Benjamin Gruenbaum 271e04f5ba doc: improve promise terminology 
PR-URL: https://github.com/nodejs/node/pull/37181
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-02-02 14:58:20 +02:00
Michaël Zasso 501ae0e6e3 test: remove outdated V8 flag 
The flag is going to be removed upstream in V8 9.0.

Refs: https://github.com/v8/v8/commit/0a480c30d553c1b8dddb0dddcbdec5fb6f3101ff

PR-URL: https://github.com/nodejs/node/pull/37151
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2021-02-02 10:33:56 +01:00
Ruy Adorno 3c0672e3f6 deps: upgrade npm to 7.5.1 
PR-URL: https://github.com/nodejs/node/pull/37177
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2021-02-02 10:31:47 +01:00
Joyee Cheung 638fb48911 src: expose BaseObject::kInternalFieldCount in post-mortem metadata 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: https://github.com/nodejs/node/pull/37111
Refs: https://github.com/nodejs/node/pull/36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-02 01:57:05 +08:00
Akash Negi b5f5c46129 doc: fix list format in Developer's Certificate of Origin 
This corresponds to the format at https://developercertificate.org/.

PR-URL: https://github.com/nodejs/node/pull/37138
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-02-01 16:19:10 +01:00
Antoine du Hamel f8853dd8cc async_hooks: refactor to avoid unsafe array iteration 
PR-URL: https://github.com/nodejs/node/pull/37125
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-02-01 16:16:38 +01:00
Tobias Nießen 814f97186f doc,test: fix prime generation description 
The previous description incorrectly explained the behavior of
options.add and options.rem for primes that are not safe.

PR-URL: https://github.com/nodejs/node/pull/37085
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-02-01 16:14:36 +01:00
Anna Henningsen a126cb5792 fs: read full size if known in promises.readFile 
If we have an estimate of the file size available from the previous
stat call, use that for the size of the first chunk to be read.
This increases performance by reading more data (and, most likely,
all data) at once without incurring memory overhead in most situations.

PR-URL: https://github.com/nodejs/node/pull/37127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-01 15:41:26 +01:00
Anna Henningsen 186feb45bc fs: only use Buffer.concat in promises.readFile when necessary 
PR-URL: https://github.com/nodejs/node/pull/37127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-02-01 15:41:23 +01:00
Antoine du Hamel 4ad46e2fef stream: refactor to avoid unsafe array iteration 
PR-URL: https://github.com/nodejs/node/pull/37126
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-02-01 15:20:35 +01:00
Antoine du Hamel 419686cdfb stream: refactor to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/36346
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-02-01 15:18:25 +01:00
Rich Trott e6fbe48cb9 doc: fix markup and alphabetization in errors.md 
Change `<a id"...` to `<a id="...` (missing equal sign) and move entry
to correct location in alphabetical order.

PR-URL: https://github.com/nodejs/node/pull/37144
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2021-02-01 06:08:27 -08:00
Rich Trott 06d74956ae doc: clarify ERR_INVALID_REPL_INPUT usage 
The REPL documentation does not list prohibited inputs, but it does
explain the conditions under which ERR_INVALID_REPL_INPUT is used.
Update the error doc to indicate that.

PR-URL: https://github.com/nodejs/node/pull/37143
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-01 05:49:49 -08:00
Antoine du Hamel 4a113be836 http: refactor to avoid unsafe array iteration 
PR-URL: https://github.com/nodejs/node/pull/37124
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-02-01 05:47:21 -08:00
Rich Trott e30e035dcd doc: clarify repl exception conditions 
The sample code demonstrating ERR_INVALID_REPL_INPUT is confusing, I
think. This simplifies and clarifies it a bit, I hope.

PR-URL: https://github.com/nodejs/node/pull/37142
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-02-01 05:42:27 -08:00
Turner Jabbour c746c403ab doc: add example for test structure 
PR-URL: https://github.com/nodejs/node/pull/35046
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-02-01 16:14:50 +08:00
Rich Trott 683754c6f3 doc: remove TOC summary for pages with no TOC 
Remove the table of contents summary for pages with no table of
contents. Currently, this affects at least index.html.

PR-URL: https://github.com/nodejs/node/pull/37043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-31 06:03:33 -08:00
cjihrig d0a92e2c32 esm: update to correct deprecation code 
https://github.com/nodejs/node/pull/36918 landed with references
to DEP0150, which is already used for a different deprecation.
This commit updates the code to use DEP0151.

PR-URL: https://github.com/nodejs/node/pull/37147
Refs: https://github.com/nodejs/node/pull/36918
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-30 11:37:22 -05:00
cjihrig 71cb829dca doc: add missing deprecation code 
PR-URL: https://github.com/nodejs/node/pull/37147
Refs: https://github.com/nodejs/node/pull/36918
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-30 11:37:04 -05:00
James M Snell 290ecb307d deps: update openssl config 
PR-URL: https://github.com/nodejs/node/pull/37067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-01-30 07:49:31 -08:00
James M Snell c3d6d50309 quic: remove quic 
PR-URL: https://github.com/nodejs/node/pull/37067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-01-30 07:49:28 -08:00
James M Snell f763a80ab5 Revert "deps: various quic patches from akamai/openssl" 
This reverts commit 06c5b5315a.

PR-URL: https://github.com/nodejs/node/pull/37067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-01-30 07:49:26 -08:00
James M Snell e63035c312 Revert "deps: re-enable OPENSSL_NO_QUIC guards" 
This reverts commit b0d5bfe73d.

PR-URL: https://github.com/nodejs/node/pull/37067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-01-30 07:49:23 -08:00
James M Snell 1c52ce892f Revert "deps: update patch and docs for openssl update" 
This reverts commit 548790ab82.

PR-URL: https://github.com/nodejs/node/pull/37067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-01-30 07:49:21 -08:00
Guy Bedford 255d6337cd esm: deprecate legacy main lookup for modules 
PR-URL: https://github.com/nodejs/node/pull/36918
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-30 16:31:49 +02:00
Dave Cardwell fd02dace6f doc: update Buffer encoding option count 
https://github.com/nodejs/node/pull/36952 added the `base64url`
encoding option.

Easier to just remove the count of options so it doesn’t need to be
updated to four, five, etc. in the future.

PR-URL: https://github.com/nodejs/node/pull/37102
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-30 18:12:59 +05:30
Ruy Adorno d3906ae294 deps: upgrade npm to 7.5.0 
PR-URL: https://github.com/nodejs/node/pull/37117
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2021-01-29 23:49:44 -05:00
Tobias Nießen 0a993e1f24 src: fix dead code in RandomPrimeTraits 
PR-URL: https://github.com/nodejs/node/pull/37083
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-29 21:09:21 +01:00
cjihrig 17467d15f8 util: add internal createDeferredPromise() 
The pattern of resolving/rejecting a Promise from outside of its
executor happens numerous times throughout the codebase (more than
what is updated here in fact). This commit abstracts that logic
into an internal utility function.

PR-URL: https://github.com/nodejs/node/pull/37095
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-29 09:50:34 -05:00
cjihrig fec093b6b7 readline: replace _questionCancel with a symbol 
This commit avoids exposing a new underscored property on
readline Interface instances.

PR-URL: https://github.com/nodejs/node/pull/37094
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-29 20:09:58 +08:00
cjihrig b02030df00 readline: check for null input in question() 
question() checks for objects passed as the recently added options
argument. This commit improves that logic to also check for null.

PR-URL: https://github.com/nodejs/node/pull/37089
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-01-29 20:08:29 +08:00
cjihrig 1b222f900e tools: remove commented code from stability.js 
PR-URL: https://github.com/nodejs/node/pull/37092
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-29 20:05:25 +08:00
Richard Lau b9dfda9b46 doc: update BUILDING.md previous versions links 
Remove links to End-of-Life versions of the BUILDING.md document.
Add a link to the version for Node.js 14.x.

PR-URL: https://github.com/nodejs/node/pull/37082
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-01-28 18:48:34 +01:00
ExE Boss 742342fa8a test: add tests for bound apply variants of varargs primordials 
PR-URL: https://github.com/nodejs/node/pull/37005
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-28 18:45:46 +01:00
ExE BossandAntoine du Hamel 728fee22e9 lib: add bound apply variants of varargs primordials 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37005
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-28 18:45:43 +01:00
ZiJian LiuExE BossAntoine du Hamel
 		029d1fd797 lib: refactor to use validateObject 
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37028
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-28 12:53:50 +01:00
bcoe 8c9dc4e9e6 benchmark: add benchmark for NODE_V8_COVERAGE 
PR-URL: https://github.com/nodejs/node/pull/36972
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-01-27 14:31:37 -08:00
Darshan Sen 0aaa804f43 fs: add validatePosition and use in read and readSync 
PR-URL: https://github.com/nodejs/node/pull/37051
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-01-27 20:55:56 +02:00
Emil Sivervik 4abe50c1d1 test: increase inspect coverage 
1. Truncate output for Primitives with 1 character left
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1359

2. Truncate output for ArrayBuffers using plural or singular bytes
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/util/inspect.js.html#L1465

PR-URL: https://github.com/nodejs/node/pull/36755
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-01-27 20:52:28 +02:00
Rich Trott e331046a29 test: skip tests consistently in parallel.status 
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when
they fail) and others are marked SKIP (which means the results don't
affect CI at all). There doesn't seem to be any reason for the
difference. Mark them all as SKIP as IBM i for consistency and to have
the luxury of a green daily CI. We'll want these to be at least
SKIP,FLAKY (and preferably not skipped at all) before IBM i is
supported.

PR-URL: https://github.com/nodejs/node/pull/37035
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-01-27 20:49:06 +02:00
ZiJian Liu 064a7070c7 lib: refactor to use validateFunction 
add validateFunction and refactor to use validateFunction

PR-URL: https://github.com/nodejs/node/pull/37045
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-27 20:46:54 +02:00
Moshe vilner 8c3cdce418 test: increase read file abort coverage 
PR-URL: https://github.com/nodejs/node/pull/36716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-27 20:44:18 +02:00