Nikolai Vavilov
9cd83c761f
buffer: remove hoisted variable
...
PR-URL: https://github.com/nodejs/node/pull/33470
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2020-05-23 20:47:02 +02:00
Nikolai Vavilov
b3f14df485
doc: fix Buffer.from(object) documentation
...
Only strings are supported for objects supporting `Symbol.toPrimitive`.
PR-URL: https://github.com/nodejs/node/pull/33327
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2020-05-23 19:23:45 +02:00
Nikolai Vavilov
339690ce9b
buffer: improve copy() performance
...
There is no need to create a slice when sourceEnd is out of bounds.
PR-URL: https://github.com/nodejs/node/pull/33214
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-05-09 08:04:10 +02:00
Nikolai Vavilov
dbad1b6515
doc: update Buffer(size) documentation
...
It returns zero-filled memory since v8.0.0.
PR-URL: https://github.com/nodejs/node/pull/33198
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2020-05-08 01:16:03 +02:00
Nikolai Vavilov
c17dcb3253
doc: fix style and grammer in buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/33194
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-05-04 16:49:29 -07:00
Nikolai Vavilov
3d8532f851
buffer: add {read|write}Big[U]Int64{BE|LE} methods
...
PR-URL: https://github.com/nodejs/node/pull/19691
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2019-04-06 19:30:23 +02:00
Nikolai Vavilov
a82fc30383
tty: handle setRawMode errors
...
PR-URL: https://github.com/nodejs/node/pull/22886
Refs: https://github.com/nodejs/node/issues/21773
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2018-09-19 14:05:19 +02:00
Nikolai Vavilov
bf12384988
tools: add BigInt to globals
...
PR-URL: https://github.com/nodejs/node/pull/21237
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yuta Hiroto <hello@hiroppy.me >
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-06-10 14:24:08 -07:00
Nikolai Vavilov
cfad44105d
build,win: replace run-python subroutine with single find_python call
...
A subroutine does not work as a replacement for the `python` command
since one cannot use a subroutine call in a `for /F` loop.
PR-URL: https://github.com/nodejs/node/pull/18621
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
2018-02-15 10:44:34 +01:00
Nikolai Vavilov
ae2bed9938
doc: require CI status indicator in PRs
...
Commits are often landed despite failing on one or more CI platforms.
Having a CI status indicator in the PR should make this less likely to
happen.
PR-URL: https://github.com/nodejs/node/pull/17151
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2017-12-24 00:10:00 +08:00
Nikolai Vavilov
b13233aa39
build: remove support for VS2015
...
PR-URL: https://github.com/nodejs/node/pull/16969
Refs: https://github.com/nodejs/node/pull/16868
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2017-12-12 20:43:35 +02:00
Nikolai Vavilov
c5a49e148d
doc: drop support for VS2015
...
PR-URL: https://github.com/nodejs/node/pull/16868
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2017-11-12 17:44:25 +02:00
Nikolai Vavilov
ff21851816
doc: clarify the prerequisites for building with VS2017
...
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017
is listed under "Visual Studio 2017", but Build Tools for Visual
Studio 2017 is listed under "Other Tools and Frameworks".
* The listed required components are insufficient. VS2017 also needs
"Visual Studio C++ core features", and Build Tools also needs
"Visual C++ Build Tools core features".
* Installing the workload with the default optional components takes up
only about 1GB more space than the minimal set of components, but
saves scrolling through the long list of individual components.
PR-URL: https://github.com/nodejs/node/pull/16903
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
2017-11-11 16:53:22 +02:00
Nikolai Vavilov
403ccb68a5
lib: setup IPC channel before console
...
Initializing IOCP on the same fd twice can fail on Windows.
Consequently, if the IPC channel uses fd 1 or 2 and the console is setup
first, writing to the IPC channel will fail.
PR-URL: https://github.com/nodejs/node/pull/16562
Fixes: https://github.com/nodejs/node/issues/16141
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-10-29 20:59:24 +02:00
Nikolai Vavilov
4108072457
build,win: set /MP separately in Debug and Release
...
Setting /MP globally causes it to appear twice in the command line due
to a GYP bug, which causes the project to be rebuilt unconditionally due
to an msbuild bug.
PR-URL: https://github.com/nodejs/node/pull/16415
Fixes: https://github.com/nodejs/node/issues/16367
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Minwoo Jung <minwoo@nodesource.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-10-24 21:34:33 +03:00
Nikolai Vavilov
5018156628
build,win: use /MP for debug builds
...
PR-URL: https://github.com/nodejs/node/pull/16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2017-10-21 13:17:08 +03:00
Nikolai Vavilov
8f5fedb555
build, windows: use /bigobj for debug builds
...
PR-URL: https://github.com/nodejs/node/pull/16289
Fixes: https://github.com/nodejs/node/issues/16288
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2017-10-19 12:04:29 +03:00
Nikolai Vavilov
b2eb98721e
build: use generic names for linting tasks
...
"jslint" is the name of a tool that actually is not used, which can
cause confusion.
PR-URL: https://github.com/nodejs/node/pull/15272
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com >
2017-09-24 12:31:52 -03:00
Nikolai Vavilov
be3f3d40e2
build: prevent VsDevCmd.bat from changing cwd
...
VsDevCmd.bat changes the current working directory to
"%USERPROFILE%\Source" if it exists. Setting VSCMD_START_DIR overrides
this behavior.
PR-URL: https://github.com/nodejs/node/pull/14303
Fixes: https://github.com/nodejs/node/issues/14300
Refs: https://developercommunity.visualstudio.com/content/problem/26780/vsdevcmdbat-changes-the-current-working-directory.html
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-07-17 20:00:42 +03:00
Nikolai Vavilov
64812f5728
src: fix decoding base64 with whitespace
...
`max_i` should also include the characters that were just read by
`base64_decode_group_slow()`.
PR-URL: https://github.com/nodejs/node/pull/13660
Fixes: https://github.com/nodejs/node/issues/13636
Fixes: https://github.com/nodejs/node/issues/13657
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-06-16 19:09:50 +03:00
Nikolai Vavilov
24e5b67148
doc: use HTTPS URL for suggested upstream remote
...
It's impossible to push to git:// URLs.
PR-URL: https://github.com/nodejs/node/pull/13602
Fixes: https://github.com/nodejs/node/issues/13600
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2017-06-10 22:58:54 +03:00
Nikolai Vavilov
208db5675e
fs: don't conflate data and callback in appendFile
...
PR-URL: https://github.com/nodejs/node/pull/11607
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-06-10 20:34:50 +03:00
Nikolai Vavilov
9991e27ac8
inspector: fix crash on exception
...
Fixes: https://github.com/nodejs/node/issues/13438
PR-URL: https://github.com/nodejs/node/pull/13455
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
2017-06-09 14:28:17 +03:00
Nikolai Vavilov
3d9e7bb1d4
repl: remove unused function convertToContext
...
PR-URL: https://github.com/nodejs/node/pull/13434
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-06-05 13:30:05 +03:00
Nikolai Vavilov
3fe980d3e6
build: fix typo
...
PR-URL: https://github.com/nodejs/node/pull/13396
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2017-06-02 16:14:56 +03:00
Nikolai Vavilov
7e0c3ab641
src: fix base64 decoding
...
Make sure trailing garbage is not treated as a valid base64 character.
Fixes: https://github.com/nodejs/node/issues/11987
PR-URL: https://github.com/nodejs/node/pull/11995
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-03-31 23:00:02 +03:00
Nikolai Vavilov
01ffe30d18
doc: clarify out-of-bounds behavior of buf[index]
...
PR-URL: https://github.com/nodejs/node/pull/11286
Fixes: https://github.com/nodejs/node/issues/11244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ron Korving <ron@ronkorving.nl >
2017-03-28 11:25:55 +03:00
Nikolai Vavilov
43fa0a8847
benchmark: allow multiple values for same config
...
This allows running a benchmark with two or more values for the same
config rather than just one or all of them, for example:
```
node benchmark/buffers/buffer-creation.js type=buffer() type=fast-alloc type=fast-alloc-fill
```
PR-URL: https://github.com/nodejs/node/pull/11819
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2017-03-22 19:41:24 +02:00
Nikolai Vavilov
0a44b71c50
doc: fix typo in STYLE_GUIDE.md
...
PR-URL: https://github.com/nodejs/node/pull/11615
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-02-28 19:59:59 +02:00
Nikolai Vavilov
d08836003c
build: build an x64 build by default on Windows
...
PR-URL: https://github.com/nodejs/node/pull/11537
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-02-28 13:41:03 +02:00
Nikolai Vavilov
00c86cc8e9
buffer: remove Uint8Array check
...
This makes write[U]Int* operations on Buffer with `noAssert=false` about 3
times faster.
PR-URL: https://github.com/nodejs/node/pull/11324
Refs: https://github.com/nodejs/node/issues/11245
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2017-02-16 16:55:56 +02:00
Nikolai Vavilov
f5ee9921e6
benchmark: fix typos
...
PR-URL: https://github.com/nodejs/node/pull/11287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2017-02-10 22:21:35 +02:00
Nikolai Vavilov
271d50a892
doc: clarify the behavior of Buffer.byteLength
...
PR-URL: https://github.com/nodejs/node/pull/11238
Refs: https://github.com/nodejs/node/issues/11165
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2017-02-09 20:47:48 +02:00
Nikolai Vavilov
9a0829d728
buffer: stricter argument checking in toString
...
This prevents the confusing behavior of `buf.toString(0, 5)` by
disallowing passing `0` as the encoding.
PR-URL: https://github.com/nodejs/node/pull/11120
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2017-02-05 14:14:53 +02:00
Nikolai Vavilov
7cd6a7ddcb
build: notify about the redundancy of "nosign"
...
vcbuild doesn't sign by default since
92ed1ab450 , but there might be people who
haven't noticed the change. This adds a message informing them that
"nosign" is no longer necessary.
PR-URL: https://github.com/nodejs/node/pull/11119
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2017-02-03 20:35:10 +02:00
Nikolai Vavilov
4444e731f2
fs: ensure readFile[Sync] reads from the beginning
...
It would previously read from the current file position, which can be
non-zero if the `fd` has been read from or written to. This contradicts
the documentation which states that it "reads the entire contents of a
file".
PR-URL: https://github.com/nodejs/node/pull/9699
Fixes: https://github.com/nodejs/node/issues/9671
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
2017-01-14 20:33:18 +02:00
Nikolai Vavilov
3c2a9361ff
fs: remove fs.read's string interface
...
It is a maintenance burden that was removed from the docs in 2010
(c93e0aaf06 ) and runtime-deprecated in v6.0
(1124de2d76 ).
PR-URL: https://github.com/nodejs/node/pull/9683
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2017-01-10 14:26:23 +02:00
Nikolai Vavilov
b209a6e271
doc: clarify eventType in fs.watch
...
'rename' is confusing, and it's not clear what "they" refers to.
Fixes: https://github.com/nodejs/node/issues/9082
PR-URL: https://github.com/nodejs/node/pull/9318
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-15 23:12:00 +01:00
Nikolai Vavilov
aa4698b66d
doc: fix typo
...
PR-URL: https://github.com/nodejs/node/pull/9089
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-10-14 01:41:53 +03:00
Nikolai Vavilov
f2fe5583c4
buffer: runtime deprecation of calling Buffer without new
...
PR-URL: https://github.com/nodejs/node/pull/8169
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-25 11:08:19 -07:00
Nikolai Vavilov
09f861f231
src: don't include a null character in the WriteConsoleW call
...
Fixes: https://github.com/nodejs/node/issues/7755
PR-URL: https://github.com/nodejs/node/pull/7764
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-08-23 14:25:49 -07:00
Nikolai Vavilov
bd23290657
buffer: remove obsolete and confusing comment
...
This comment applied to a line that was removed in
https://github.com/nodejs/node/commit/dd67608bfdb3bef6e06a1965ecbfa51658c61b1b
and is no longer relevant.
PR-URL: https://github.com/nodejs/node/pull/7264
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-06-12 15:40:17 +03:00
Nikolai Vavilov
cf29b2f815
doc: document intention and dangers of fs module Buffer API
...
PR-URL: https://github.com/nodejs/node/pull/6020
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-04-18 16:03:04 -07:00
Nikolai Vavilov
804ab7ebaa
doc: add seishun as a collaborator
...
PR-URL: https://github.com/iojs/io.js/pull/598
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com >
2015-01-24 23:03:11 +01:00
Nikolai Vavilov
0f3d7e6032
configure: remove compiler detection
...
The GCC version is no longer relevant since only 4.8 and newer are
supported. It's probably safe to assume clang on mac since V8 does
so too.
PR-URL: https://github.com/iojs/io.js/pull/205
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2014-12-23 19:27:24 +01:00
Nikolai Vavilov
ef10827c9f
configure: remove workarounds for GCC < 4.8
...
They can't compile io.js anyway.
PR-URL: https://github.com/iojs/io.js/pull/187
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2014-12-20 22:08:47 +01:00
Nikolai Vavilov
370e821424
build: remove support for VS 2010 and 2012
...
They can't compile io.js anyway.
PR-URL: https://github.com/iojs/io.js/pull/156
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Bert Belder <bertbelder@gmail.com >
2014-12-12 14:06:51 -08:00
Nikolai Vavilov
e24fa83e69
Revert "path: resolve normalize drive letter to lower case"
...
This reverts commit f6e5740180 .
Changing drive letters to lowercase violates the principle of
least surprise. Other functions that do this should get fixed too.
Conflicts:
lib/path.js
PR-URL: https://github.com/iojs/io.js/pull/100
Reviewed-By: Bert Belder <bertbelder@gmail.com >
2014-12-08 17:35:52 +01:00
Nikolai Vavilov
b782ef85f1
src: remove usage of extended sizeof
...
It's not supported in VS2013.
PR-URL: https://github.com/node-forward/node/pull/38
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2014-10-28 16:55:11 +01:00
Nikolai Vavilov
b105f6f741
src: fix comparison of WCHAR with nullptr
...
PR-URL: https://github.com/node-forward/node/pull/32
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2014-10-25 01:29:55 +02:00
seishun
42bda05af8
crypto: add RSA encryption
...
Reviewed-By: Fedor Indutny <fedor@indutny.com >
2014-08-11 22:00:34 +04:00
Nicholas Vavilov
5344d0c103
crypto, zlib: replace _binding with _handle
...
Also include whitespace fixes to appease jslint.
Signed-off-by: Trevor Norris <trev.norris@gmail.com >
2014-05-07 16:31:00 -07:00
Nikolai Vavilov
79e8f65cb1
doc: fix a typo
...
Signed-off-by: Trevor Norris <trev.norris@gmail.com >
2014-05-07 14:41:15 -07:00
Nikolai Vavilov
9b37b83a20
zlib: add sync versions for convenience methods
2014-02-01 03:45:45 +04:00
Nikolai Vavilov
207a3e10f8
doc: http: properly document callback argument
2013-11-28 22:31:11 +01:00