Vse Mozhet Byt
0f69f40af0
benchmark: replace more [].join() with ''.repeat()
...
Refs: https://github.com/nodejs/node/pull/12170
PR-URL: https://github.com/nodejs/node/pull/12317
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-04-13 00:31:25 +03:00
Vse Mozhet Byt
a91242569a
doc: modernize and fix code examples in path.md
...
Unify spaces, quotes, and semicolons. Update output examples.
PR-URL: https://github.com/nodejs/node/pull/12296
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-04-12 03:21:47 +03:00
Vse Mozhet Byt
9b6376a4ee
doc: update os.uptime() and process.uptime() info
...
PR-URL: https://github.com/nodejs/node/pull/12294
Fixes: https://github.com/nodejs/node/issues/12291
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-04-11 02:35:13 -07:00
Vse Mozhet Byt
b2a12ee782
doc: fix confusing example in process.md
...
PR-URL: https://github.com/nodejs/node/pull/12282
Fixes: https://github.com/nodejs/node/issues/12280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2017-04-10 16:16:44 +03:00
Vse Mozhet Byt
14749f9eaf
doc: fix confusing reference in net.md
...
PR-URL: https://github.com/nodejs/node/pull/12247
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com >
2017-04-08 16:09:22 +03:00
Vse Mozhet Byt
166a15669f
doc: modernize and fix code examples in modules.md
...
* Replace `var` by `const`.
* Fix semicolons.
* Add missing code marks.
* Unify quotes.
* Comment out ellipsis.
* Use object destructuring.
* Use exponentiation operator.
* Replace snake_case by camelCase.
PR-URL: https://github.com/nodejs/node/pull/12224
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com >
2017-04-08 16:02:01 +03:00
Vse Mozhet Byt
505936309d
doc: modernize and fix code examples in https.md
...
* Replace `var` by `const`.
* Comment out ellipses.
* Update code example (provide relevant file path, add missing option).
PR-URL: https://github.com/nodejs/node/pull/12171
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-04-05 04:02:41 +03:00
Vse Mozhet Byt
b2ac3b60b2
doc: fix and update examples in http.md
...
* replace `var` by `const` in http.md
* replace `let` by `const` in http.md
* fix spaces in code examples of http.md
* replace console.log() by .error() in http.md
* make arrow function clearer in http.md
* use object destructuring in http.md
* update output examples in http.md
PR-URL: https://github.com/nodejs/node/pull/12169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2017-04-04 09:20:40 -07:00
Vse Mozhet Byt
74dc3bfe08
benchmark: replace [].join() with ''.repeat()
...
Also add a benchmark to compare both ways to create strings.
PR-URL: https://github.com/nodejs/node/pull/12170
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-04-04 09:19:18 -07:00
Vse Mozhet Byt
642baf4699
benchmark: check end() argument to be > 0
...
PR-URL: https://github.com/nodejs/node/pull/12030
Ref: https://github.com/nodejs/node/issues/11972
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2017-03-28 03:18:44 +03:00
Vse Mozhet Byt
31da3757fa
doc: update and modernize examples in fs.ms
...
* unify quotes in fs.md
* avoid quote escaping in fs.md
* simplify logics in fs.md
* concatenation -> template literal in fs.md
* add missing callback in fs.md
* fix typo in fs.md
* update output example in fs.md
PR-URL: https://github.com/nodejs/node/pull/12035
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-03-27 10:33:23 -07:00
Vse Mozhet Byt
2dff3a22fe
test: do not use more command on Windows
...
PR-URL: https://github.com/nodejs/node/pull/11953
Fixes: https://github.com/nodejs/node/issues/11469
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2017-03-23 05:52:35 +02:00
Vse Mozhet Byt
76279cbb5c
doc: correct info in child_process.md
...
`child.stderr`, `child.stdin`, and `child.stdout`
are `null`, not `undefined`, if the relevant `stdio` properties
are set to anything other than 'pipe'.
PR-URL: https://github.com/nodejs/node/pull/11949
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-03-22 09:16:02 -07:00
Vse Mozhet Byt
ae8a8691e6
benchmark: add final clean-up to module-loader.js
...
PR-URL: https://github.com/nodejs/node/pull/11924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-03-21 22:10:06 -07:00
Vse Mozhet Byt
4b841cb0b6
benchmark: harmonize progress bar + stderr output
...
Add a space for minimal readability.
PR-URL: https://github.com/nodejs/node/pull/11925
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-03-21 21:58:18 -07:00
Vse Mozhet Byt
ab2d49bcac
benchmark: fix fs\bench-realpathSync.js
...
Make it call-site-cwd-independent.
PR-URL: https://github.com/nodejs/node/pull/11904
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-03-21 14:04:03 +02:00
Vse Mozhet Byt
4895e0c1f0
doc: add vsemozhetbyt to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/11932
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2017-03-20 03:16:59 +02:00
Vse Mozhet Byt
4d52d12fd1
doc: console.log() -> console.error() in events.md
...
PR-URL: https://github.com/nodejs/node/pull/11810
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-03-14 17:09:19 -07:00
Vse Mozhet Byt
e494e427c9
doc: var -> let / const in events.md
...
PR-URL: https://github.com/nodejs/node/pull/11810
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-03-14 17:09:13 -07:00
Vse Mozhet Byt
c500b5af14
test: fix args in parallel/test-fs-null-bytes.js
...
The functions `fs.appendFile()` and `fs.writeFile()`
were being called without the required `data` argument.
Refs: https://github.com/nodejs/node/issues/11595
PR-URL: https://github.com/nodejs/node/pull/11601
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com >
2017-03-03 16:09:43 +02:00
Vse Mozhet Byt
6aa18aae39
doc: fixup errors.md
...
* add semicolons in examples
* fix indentation in code example
* add spaces in code examples
* console.log() -> console.error()
* fix level of headings
* update comment code example
* delete obsolete info and example
Fixes: https://github.com/nodejs/node/issues/11558
PR-URL: https://github.com/nodejs/node/pull/11566
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2017-03-01 07:51:08 -08:00
Vse Mozhet Byt
dd81d539e2
child_process: fix deoptimizing use of arguments
...
Removed or fixed use of arguments in execFile(),
normalizeExecArgs(), and normalizeSpawnArguments().
Refs: https://github.com/nodejs/node/issues/10323
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=6010
PR-URL: https://github.com/nodejs/node/pull/11535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2017-03-01 10:24:03 -05:00
Vse Mozhet Byt
1162e284ca
benchmark: add dgram bind(+/- params) benchmark
...
Refs: https://github.com/nodejs/node/pull/11242
PR-URL: https://github.com/nodejs/node/pull/11313
Reviewed-By: Brian White <mscdex@mscdex.net >
2017-02-21 18:27:11 +01:00
Vse Mozhet Byt
52b253677a
doc: fix sorting in API references
...
PR-URL: https://github.com/nodejs/node/pull/11331
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
2017-02-20 13:11:11 -08:00
Vse Mozhet Byt
adf1ed0146
dgram: fix possibly deoptimizing use of arguments
...
This commit adds a guard against an out of bounds access of
arguments, and replaces another use of arguments with a named
function parameter.
Refs: https://github.com/nodejs/node/issues/10323
PR-URL: https://github.com/nodejs/node/pull/11242
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-02-16 12:24:07 -05:00
Vse Mozhet Byt
e4e7cd5bd2
doc: synchronize + update _toc.md and all.md
...
PR-URL: https://github.com/nodejs/node/pull/11206
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-02-14 19:07:02 -05:00
Vse Mozhet Byt
5a42cd1505
doc: update code examples in domain.md
...
* var -> const
* string concatenation -> template strings
PR-URL: https://github.com/nodejs/node/pull/11110
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-02-14 16:13:44 -06:00
Vse Mozhet Byt
a29c85a28d
test: adapt test-debugger-pid to localized Windows
...
PR-URL: https://github.com/nodejs/node/pull/11270
Fixes: https://github.com/nodejs/node/issues/11250
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-02-11 08:56:23 -08:00
Vse Mozhet Byt
ca8c30a35c
doc: update output examples in debugger.md
...
PR-URL: https://github.com/nodejs/node/pull/10944
Reviewed-By: Josh Gavant <joshgavant@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2017-02-10 07:53:42 -08:00
Vse Mozhet Byt
9682151a1c
doc: improve consistency in documentation titles
...
Unify capitalization and spaces and add some info for consistency,
clarity and coherence with sorting in the all.md / _toc.md.
PR-URL: https://github.com/nodejs/node/pull/11230
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2017-02-09 16:00:43 -08:00
Vse Mozhet Byt
110b7cf2e4
doc: fix confusing example in dns.md
...
Currently, the example throws 'Error: getHostByAddr ENOTFOUND'
The previous example is edited for consistency.
PR-URL: https://github.com/nodejs/node/pull/11022
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2017-01-31 21:36:30 +00:00
Vse Mozhet Byt
3e9c8ef53b
doc: update examples in api/crypto.md
...
* var -> const / let in crypto.md
* fix error in crypto.md code example
* equal -> strictEqual, == -> === in crypto.md
* update estimated outputs in crypto.md
* snake_case -> camelCase in crypto.md examples
* concatenation -> multiline template in crypto
* add missing line break in crypto code example
* add missing link reference in crypto.md
PR-URL: https://github.com/nodejs/node/pull/10909
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-01-24 10:49:32 -08:00
Vse Mozhet Byt
3e4dc60fae
doc: more efficient example in the console.md
...
Object.setPrototypeOf() -> Object.create()
PR-URL: https://github.com/nodejs/node/pull/10451
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-27 13:16:13 -08:00
Vse Mozhet Byt
2b4dfeba1d
doc: var -> const / let in the console.md
...
PR-URL: https://github.com/nodejs/node/pull/10451
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-27 13:16:05 -08:00
Vse Mozhet Byt
f5011786ba
doc: add the valid link for curl(1) in repl.md
...
The current autoinserted link leads to 404 page.
PR-URL: https://github.com/nodejs/node/pull/10244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-25 19:50:35 +01:00
Vse Mozhet Byt
5f8aa1fcb1
doc: replace anonymous functions in repl.md
...
Replaced with an object shorthand and an arrow function.
PR-URL: https://github.com/nodejs/node/pull/10244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-25 19:50:32 +01:00
Vse Mozhet Byt
224cbf8bd8
doc: fix a function name in repl.md
...
`eval` => `myEval` to not shadow the global `eval`
PR-URL: https://github.com/nodejs/node/pull/10244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-25 19:50:29 +01:00
Vse Mozhet Byt
4936c41194
doc: fix an output example in repl.md
...
Make `_` reassignment example match more with the current output.
Extend the example for more clarity.
PR-URL: https://github.com/nodejs/node/pull/10244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-25 19:50:25 +01:00
Vse Mozhet Byt
cb507af454
doc: white space unification in repl.md
...
Add an infix space in an argument list.
Change `>` into `> ` in code bits and output examples.
Explicitly clarify that default REPL prompt contains a trailing space.
PR-URL: https://github.com/nodejs/node/pull/10244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-25 19:50:22 +01:00
Vse Mozhet Byt
c919dd7788
doc: var => let / const in repl.md
...
PR-URL: https://github.com/nodejs/node/pull/10244
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-12-25 19:49:05 +01:00
Vse Mozhet Byt
e03ee719e6
doc: modernize code examples in the cluster.md
...
- Fixes https://github.com/nodejs/node/issues/10255
- It also will be consistent with a previous code example.
- `cluster.workers` iteration: `Object.keys().forEach` -> `for`...`in`
PR-URL: https://github.com/nodejs/node/pull/10270
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
2016-12-22 09:18:57 -05:00
Vse Mozhet Byt
50cb3a3711
doc: document argument variant in the repl.md
...
`options` in the `repl.start([options])` can be a string.
Ref: https://github.com/nodejs/node/pull/10160
PR-URL: https://github.com/nodejs/node/pull/10221
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2016-12-12 16:31:01 -05:00
Vse Mozhet Byt
f418a22767
doc: modernize child_process example code
...
1. equal => strictEqual.
2. let => const for the variable that is not reassigned.
3. fix spaces.
4. stringify erroneous raw buffer outputs.
5. fix a typo.
PR-URL: https://github.com/nodejs/node/pull/10102
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2016-12-12 07:56:14 -08:00
Vse Mozhet Byt
898c25aa64
doc: fix a wrong note in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:20:46 +01:00
Vse Mozhet Byt
dede04c686
doc: remove an extraneous word in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:20:43 +01:00
Vse Mozhet Byt
0d0028935b
doc: fix examples in buffer.md to avoid confusion
...
On some systems, some first bytes of allocated buffer can be zeroed
by default, so the example doesn't work well - the buffer looks zeroed
even before the fill.
Fixes: https://github.com/nodejs/node/issues/9786
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:20:12 +01:00
Vse Mozhet Byt
ae2b19687b
doc: remove a wrong remark in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:20:09 +01:00
Vse Mozhet Byt
39ed512d8a
doc: add a variable declaration in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:20:02 +01:00
Vse Mozhet Byt
b20cb6f469
doc: repeat a remark as needed in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:19:59 +01:00
Vse Mozhet Byt
96e5017449
doc: fix copy-paste artifacts in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:19:56 +01:00
Vse Mozhet Byt
6050bbe60a
doc: fix wrong function arguments in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:19:54 +01:00
Vse Mozhet Byt
8fbcf78d85
doc: fix a syntax error in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:19:51 +01:00
Vse Mozhet Byt
69a34e4a07
doc: var => const/let in the buffer.md
...
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-12-06 19:18:50 +01:00
Vse Mozhet Byt
7be1f186aa
doc: var => const in js code examples of addons.md
...
PR-URL: https://github.com/nodejs/node/pull/10092
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2016-12-03 14:12:50 +01:00
Vse Mozhet Byt
929fd4a892
doc: fix typo in assert code example
...
PR-URL: https://github.com/nodejs/node/pull/9704
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-11-22 17:27:05 +01:00
Vse Mozhet Byt
45279947f1
doc: small improvements in readline code examples
...
1. Consistent template literals in `console.log()`.
2. === instead of ==.
3. const instead of var.
PR-URL: https://github.com/nodejs/node/pull/9628
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jackson Tian <shyvo1987@gmail.com >
2016-11-19 18:05:53 +01:00
Vse Mozhet Byt
74f0e51b4d
doc: fix a typo in the assert.md
...
PR-URL: https://github.com/nodejs/node/pull/9598
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-11-15 22:49:06 +01:00
Vse Mozhet Byt
0de55d864d
test: decrease inconsistency in the common.js
...
1. `process.env['PROCESSOR_ARCHITEW6432']` ->
`process.env.PROCESSOR_ARCHITEW6432`.
2. `path.dirname(__filename)` -> `__dirname`.
3. `path.resolve(__dirname)` -> `__dirname`.
PR-URL: https://github.com/nodejs/node/pull/7758
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2016-08-01 14:17:20 +02:00
Vse Mozhet Byt
ea725eda42
test: ensure stream preprocessing order
...
Sometimes it is necessary to preprocess some initial bit
of a stream data before giving the entire stream
to the main processing function. Sometimes this bit should be extracted
from the stream before the main processing; sometimes it should be
returned to the stream. This test checks an order of stream
modes, methods and events for a possible preprocessing algorithm.
Stream BOM stripping is selected as a use case.
See https://github.com/nodejs/help/issues/221 as the prehistory.
PR-URL: https://github.com/nodejs/node/pull/7741
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-27 13:56:55 +02:00
vsemozhetbyt
80478a5240
doc: fix typo in the CHANGELOG_V6
...
compliment -> complement
PR-URL: https://github.com/nodejs/node/pull/7568
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-07-13 21:49:26 +02:00
vsemozhetbyt
58a241d537
doc: fix typos in the stream doc
...
PR-URL: https://github.com/nodejs/node/pull/7336
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-06-21 18:57:43 +02:00
vsemozhetbyt
563c9f8687
doc: extra clarification of historySize option
...
History caching in the `readline` io is active only for terminal
interaction. Appropriate variables are initialized and relevant
`_addHistory()` function is called only if exposed `terminal` option
of `readline.createInterface()` is set `true` by user or internal
output check.
This clarification is useful to assure users there will be now wasted
overhead connected with history caching if `readline` is used not
for terminal interaction (e.g. for reading files line by line).
Particularly this fix is helpful after #6352 landing.
PR-URL: https://github.com/nodejs/node/pull/6397
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2016-05-01 14:33:28 -07:00
vsemozhetbyt
f6d90a912b
doc: fix a typo in the CONTRIBUTING.md
...
Delete a typo dot in the link to stability index.
PR-URL: https://github.com/nodejs/node/pull/6343
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com >
2016-04-22 08:35:39 -07:00