BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
35,490 Commits 266 Branches 972 Tags
05e9cb6f22930bf7332fc0dee6766b6578682c02
Commit Graph
35490 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Benjamin Gruenbaum 05e9cb6f22 test: make fs watch test more stable 
PR-URL: https://github.com/nodejs/node/pull/41715
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-29 19:49:26 +00:00
Node.js GitHub Bot 39e26ae2e5 tools: update eslint to 8.8.0 
PR-URL: https://github.com/nodejs/node/pull/41738
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-01-29 19:34:51 +00:00
Rich Trott 3e0526ce33 meta: adjust mailmap/AUTHORS to reflect README change 
Refs: https://github.com/nodejs/node/pull/41683#pullrequestreview-861551695

PR-URL: https://github.com/nodejs/node/pull/41751
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-01-29 18:31:31 +00:00
Tobias Nießen 74de55533d test: fix typo in MessageChannel test 
PR-URL: https://github.com/nodejs/node/pull/41746
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-01-29 18:53:28 +01:00
Darshan Sen ef4c115cc8 test: replace commented out expectations with tests 
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/41667
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-29 10:01:10 +00:00
Mestery 44f8b4f506 doc: update Mesteery email 
PR-URL: https://github.com/nodejs/node/pull/41683
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-29 08:10:05 +00:00
himself65 2818fa6089 build: check if python is a executable program 
After Windows 10 version 1903, placeholder files named "python.exe"
and "python3.exe" appear, not executable programs, and open the
MS Store when running without parameters.

Fixes: https://github.com/nodejs/node/issues/36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update

PR-URL: https://github.com/nodejs/node/pull/36696
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-29 01:31:12 +00:00
Michael Dawson d86dcaa631 perf_hooks: remove useless calls in Histogram 
Coverity reported some calls that had no effect,
remove them

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41579
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-01-28 17:20:32 -05:00
Benjamin Gruenbaum 64c4b551ba process: unhandledRejection support more errors 
Support cross realm errors where `instanceof` errors in our
unhandledRejection warning to print better error with stack traces.

PR-URL: https://github.com/nodejs/node/pull/41682
Refs: https://github.com/nodejs/node/issues/41676
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-01-28 19:11:26 +00:00
Tobias Nießen 0172d1d48c doc: avoid incomplete sentence in cluster docs 
PR-URL: https://github.com/nodejs/node/pull/41701
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2022-01-28 16:55:03 +00:00
Tobias Nießen 334fb38435 tools: use Set instead of { [key]: true } object 
Refs: https://github.com/nodejs/node/pull/41675

PR-URL: https://github.com/nodejs/node/pull/41695
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-28 16:41:16 +00:00
Rafael Silva f98a785dab http2: fix memory leak on nghttp2 hd threshold 
PR-URL: https://github.com/nodejs/node/pull/41502
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2022-01-28 16:28:46 +00:00
Yoshiki Kurihara 5a61ca63b9 doc: fix typo in contributing guides 
PR-URL: https://github.com/nodejs/node/pull/41723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-01-28 11:07:55 +00:00
Harshil jain a4183b666e doc: improve docs to give descriptive info for the platform property 
PR-URL: https://github.com/nodejs/node/pull/41650
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-01-28 00:12:01 +00:00
Antoine du Hamel 40ef144b65 doc: fix link to npm documentation 
The previous link led to an old page that does not document all the
`package.json` fields used by npm.

PR-URL: https://github.com/nodejs/node/pull/41712
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-27 23:35:23 +00:00
Rich Trott acc92a77cb util: use hasOwnProperty() primordial 
Avoid Object.prototype.hasOwnProperty. Use primordial instead.

PR-URL: https://github.com/nodejs/node/pull/41692
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-27 11:49:18 -08:00
iMoses 5d9caa1c2f stream: use synchronous error validation on iteration helpers 
is no longer a generator function,
instead it returns a called generator so that validation can be
synchronous and not wait for the first iteration

Fixes: https://github.com/nodejs/node/issues/41648

PR-URL: https://github.com/nodejs/node/pull/41652
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2022-01-27 16:53:00 +00:00
Benjamin Gruenbaum 7752eedcc7 test: improve stability of oom test 
The OOM test uses a value that caused an OOM crash from V8 on certain
machines when V8 did not notify the host of OOM soon enough.

PR-URL: https://github.com/nodejs/node/pull/41681
Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-01-27 13:04:51 +02:00
Benjamin Gruenbaum 830007dafd stream: add asIndexedPairs 
Add the asIndexedPairs method for readable streams.

PR-URL: https://github.com/nodejs/node/pull/41681
Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-01-27 13:04:49 +02:00
Rich Trott c15639dbdc doc: clarify treatment of non-string base in URL() 
PR-URL: https://github.com/nodejs/node/pull/41685
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-01-27 05:45:53 +00:00
akhil marsonya ccb8aae393 doc: fix typo in technical-priorities.md 
`heap dumps` spelled as `headumps`

PR-URL: https://github.com/nodejs/node/pull/41694
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-01-26 05:05:51 +00:00
Tobias Nießen 6fc6ba74f5 doc: remove unadvisable cluster example 
Applications should usually keep track of workers themselves to prevent
cross-referencing workers from different "groups" that are assigned to
separate tasks.

Additionally, it is unreasonable to assume that the 'data' event emitted
by a socket object will be an integer. While the example works when the
argument is a string (or Buffer), it can result in various issues (e.g.,
when id === '__proto__' since cluster.workers has a non-null prototype).

Refs: https://github.com/nodejs/node/commit/5f08c3cfa1ee3ece6032d1ffeda6f403e54dd5c0

PR-URL: https://github.com/nodejs/node/pull/41668
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-01-25 19:36:51 +00:00
Michael Dawson 670dbba4dc doc: document flow for supporting type generation 
Refs: https://github.com/nodejs/next-10/issues/104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-01-25 11:41:35 -05:00
Michael Dawson a2dead4171 doc: clarify parameter for napi_get_cb_info 
Refs: https://github.com/nodejs/help/issues/3698

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41635
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-01-25 11:39:23 -05:00
Rich Trott e2e2bc83c0 test: use Object.hasOwn() where applicable 
Replace Object.prototpye.hasOwnProperty() with Object.hasOwn() where
applicable.

PR-URL: https://github.com/nodejs/node/pull/41664
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-25 07:03:17 +00:00
Rich Trott ff5766fc2e test: remove unneeded test statement 
The statement removed was added in 6657b153ab but it was not added
as an assertion. It currently returns false but t0he test does not fail
because of the missing assertion. Since the property is no longer one
that exists, there is no need to test its existence. Remove the line.

PR-URL: https://github.com/nodejs/node/pull/41663
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-01-25 06:04:28 +00:00
Rich Trott 6023bedc07 doc: revise url.resolve() text 
PR-URL: https://github.com/nodejs/node/pull/41661
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-25 03:43:55 +00:00
Rich Trott 88a3bd5fcd doc: clarify treatment of non-string argument to new URL() 
Closes: https://github.com/nodejs/node/issues/41653

PR-URL: https://github.com/nodejs/node/pull/41658
Fixes: https://github.com/nodejs/node/issues/41653
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-01-25 02:04:22 +00:00
Jithil P Ponnan 938ab0e267 test: remove error allowance in debugger test 
Remove allowance for FATAL ERROR. It is no longer needed.

PR-URL: https://github.com/nodejs/node/pull/41640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2022-01-25 01:38:05 +00:00
Giora Guttsait b27ae24dcc lib: throw error in structuedClone when no arguments are passed 
PR-URL: https://github.com/nodejs/node/pull/41651
Fixes: https://github.com/nodejs/node/issues/41450
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-01-24 23:17:37 +00:00
Antoine du Hamel 5d88f59fdb doc: fix documentation for MODULE_NOT_FOUND and ERR_MODULE_NOT_FOUND 
PR-URL: https://github.com/nodejs/node/pull/41645
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-24 21:59:26 +00:00
Darshan Sen 726711fe4e node-api: add node_api_symbol_for() 
Fixes: https://github.com/nodejs/node/issues/41294

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/41329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-01-24 16:35:07 -05:00
Tobias Nießen 3657c14598 doc: improve TLS/SSL introduction 
PR-URL: https://github.com/nodejs/node/pull/41649
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-01-24 19:50:37 +00:00
Benjamin GruenbaumandAntoine du Hamel ce41395f89 test: add stream map tests 
Add more tests to check and enforce the behavior of the map method.

Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/41642
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-01-24 20:15:58 +02:00
Yash Ladha 3ee8c3e45e tools: add compile_commands to ignore file 
For developing c++ source files, clangd generates an index file for
project via `./configure -C`. We can safely ignore the file from
tracking.

PR-URL: https://github.com/nodejs/node/pull/41580
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-01-24 14:39:31 +00:00
Rich Trott 49ba2104c4 util: remove unused fast path in internal debuglog 
The internal `debuglog()` is never called with 0 parameters. Remove the
fast-path for that situation. If it ever occurs, it will fall through to
the default path.

PR-URL: https://github.com/nodejs/node/pull/41605
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-01-24 14:39:22 +00:00
npm team c0ef0d5a66 deps: upgrade npm to 8.3.2 
PR-URL: https://github.com/nodejs/node/pull/41621
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-01-24 15:26:39 +01:00
Tobias Nießen 400b7c242b tools: use Set instead of { [key]: true } object 
PR-URL: https://github.com/nodejs/node/pull/41675
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-01-24 11:46:47 +00:00
Luigi Pinca 7ce8403ef1 test: simplify test-gc-http-client 
Instead of sending a fixed number of requests, detect when GC has
started and stop sending requests at that point.

PR-URL: https://github.com/nodejs/node/pull/41620
Refs: https://github.com/nodejs/node/commit/47ecf2060343
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-01-23 21:26:51 +01:00
Benjamin GruenbaumandRobert Nagy a8afe26fca stream: add drop and take 
This adds the `drop` and `take` methods to readable streams allowing
users easily drop and take items from the stream.

This continues the iterator-helper proposal alignment task.

Co-Authored-By: Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/41630
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-01-23 18:43:16 +02:00
Node.js GitHub Bot 3d27a04b56 meta: update AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/41659
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-01-23 14:50:51 +00:00
Tobias Nießen 0e6db9c3b0 doc: modernize and simplify cluster example 
PR-URL: https://github.com/nodejs/node/pull/41626
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-01-23 12:14:11 +00:00
Tobias Nießen c18ca140a1 tools: fix typo in tools/code_cache/README.md 
PR-URL: https://github.com/nodejs/node/pull/41657
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-01-23 12:31:42 +01:00
Benjamin Gruenbaum ca489497be stream: never flatten on toArray 
PR-URL: https://github.com/nodejs/node/pull/41615
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-01-23 08:19:53 +00:00
Benjamin GruenbaumandRobert Nagy cc8931a916 stream: support flatMap 
Support the `flatMap` method from the iterator helper TC39 proposal on
readable streams.

Co-Authored-By: Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/41612
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-01-23 10:13:17 +02:00
Rich Trott 68bb83f11b tools: enable no-cond-assign-ESLint rule 
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: https://github.com/nodejs/node/pull/41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-01-22 19:38:19 -08:00
Rich Trott d77754bfc7 test: prepare tests for no-cond-assign ESLint rule 
PR-URL: https://github.com/nodejs/node/pull/41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-01-22 19:38:17 -08:00
Rich Trott 348469b87a repl: check for precise values rather than falsy in loops 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: https://github.com/nodejs/node/pull/41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-01-22 19:38:15 -08:00
Rich Trott ac06951049 util: check for null instead of flasy in loop 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: https://github.com/nodejs/node/pull/41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-01-22 19:38:13 -08:00
Rich Trott bd422452da timers: check for nullish instead of falsy in loops 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: https://github.com/nodejs/node/pull/41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-01-22 19:38:11 -08:00