Commit Graph
43207 Commits
Author SHA1 Message Date
Burkov Egor 0a8e474bdc src: add nullptr handling for NativeKeyObject
Fixes: https://github.com/nodejs/node/issues/56899
PR-URL: https://github.com/nodejs/node/pull/56900
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2025-04-16 03:29:19 -03:00
Yagiz Nizipli 2244a2776a test: execute shell directly for refresh()
PR-URL: https://github.com/nodejs/node/pull/55051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-04-16 03:29:19 -03:00
Yagiz Nizipli 1ea6198a5a src: disallow copy/move fns/constructors
PR-URL: https://github.com/nodejs/node/pull/56811
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-04-16 03:29:18 -03:00
Ian Kerins 14b2d496a0 fs: make FileHandle.readableWebStream always create byte streams
The original implementation of the experimental
`FileHandle.readableWebStream` API created non-`type: 'bytes'` streams,
which prevented callers from creating `mode: 'byob'` readers from the
returned stream, which means they could not achieve the associated
"zero-copy" performance characteristics.

Then, #46933 added a parameter allowing callers to pass the `type`
parameter down to the ReadableStream constructor, exposing the same
semantics to callers of `FileHandle.readableWebStream`.

But there is no point to giving callers this choice: FileHandle-derived
streams are by their very nature byte streams. We should not require
callers to explicitly opt in to having byte stream semantics. Moreover,
I do not see a situation in which callers would ever want to have a
non-bytes stream: bytes-streams only do anything differently than normal
ones if `mode: 'byob'` is passed to `getReader`.

So, remove the `options` parameter and always create a ReadableStream
with `type: 'bytes'`.

Fixes #54041.

PR-URL: https://github.com/nodejs/node/pull/55461
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2025-04-16 03:29:18 -03:00
Node.js GitHub Bot 7eb3b44010 deps: update zlib to 1.3.0.1-motley-788cb3c
PR-URL: https://github.com/nodejs/node/pull/56655
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-04-16 03:29:18 -03:00
Stefan Stojanovic 901685c723 build,win: enable ccache
PR-URL: https://github.com/nodejs/node/pull/56847
Refs: https://github.com/nodejs/node/pull/56705
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-04-16 03:29:18 -03:00
Node.js GitHub Bot 257d22e181 deps: update sqlite to 3.49.0
PR-URL: https://github.com/nodejs/node/pull/56654
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-04-16 03:29:17 -03:00
Chengzhong Wu 787e93f75a inspector: add Network.Initiator in inspector protocol
Add initiator stack trace in inspector network events, reflecting
the location where the script created the request.

The `http.client.request.created` event is closer to where user code
creates the http request, and correctly reflects which script
initiated the request.

PR-URL: https://github.com/nodejs/node/pull/56805
Refs: https://github.com/nodejs/node/issues/53946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-04-16 03:29:17 -03:00
Chengzhong Wu e4100853cb src: add a hard dependency v8_inspector_headers
A GYP hard dependency instructs GYP to not remove the dependency link
between two static library targets in its generated output. This
allows V8 dependents to include V8 inspector protocol headers.

PR-URL: https://github.com/nodejs/node/pull/56805
Refs: https://github.com/nodejs/node/issues/53946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-04-16 03:29:17 -03:00
Jan Krems 4991e5d826 zlib: add zstd support
Fixes: https://github.com/nodejs/node/issues/48412
PR-URL: https://github.com/nodejs/node/pull/52100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-04-16 03:29:16 -03:00
Jan Krems f9f611fb58 deps,tools: add zstd 1.5.6
PR-URL: https://github.com/nodejs/node/pull/52100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-04-16 03:29:16 -03:00
dependabot[bot] 35b3140d03 meta: bump actions/setup-node from 4.1.0 to 4.2.0
PR-URL: https://github.com/nodejs/node/pull/56868
Refs: https://github.com/actions/setup-node/commit/1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-04-16 03:29:16 -03:00
Jimmy Leung afa6f93a32 doc: update history of stream.Readable.toWeb()
Adds the exact version for when the 2nd `options` argument is available.

Refs: https://github.com/nodejs/node/pull/43515
PR-URL: https://github.com/nodejs/node/pull/56928
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:29:16 -03:00
deepak1556 fd3053e947 build: gyp exclude libm linking on macOS
PR-URL: https://github.com/nodejs/node/pull/56901
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
2025-04-16 03:29:15 -03:00
deepak1556 5ec6b9a50f build: remove explicit linker call to libm on macOS
/usr/lib/libm.tbd is available via libSystem.*.dylib and
reexports sanitizer symbols. When building for asan
this becomes an issue as the linker will resolve the symbols
from the system library rather from libclang_rt.*

For V8 that rely on specific version of these symbols
that get bundled as part of clang, for ex:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/cppgc/platform.cc;l=93-97
accepting nullptr for shadow_offset in `asan_get_shadow_mapping`,
linking to system version that doesn't support this will lead to
a crash.

Clang driver eventually links with `-lSystem`
https://github.com/llvm/llvm-project/blob/e82f93890daefeb38fe2a22ee3db87a89948ec57/clang/lib/Driver/ToolChains/Darwin.cpp#L1628-L1631,
this is done after linking the sanitizer libraries which
ensures right order of resolution for the symbols.

PR-URL: https://github.com/nodejs/node/pull/56901
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
2025-04-16 03:29:15 -03:00
Joyee Cheung 03a0f3a56b crypto: support --use-system-ca on Windows
This patch adds support for --use-system-ca on Windows, the
certificates are collected following Chromium's policy,
though the following are left as TODO and out of this patch.

- Support for user-added intermediate certificates
- Support for distrusted certificates

Since those aren't typically supported by other runtimes/tools
either, and what's implemented in this patch is sufficient for
enough use cases already.

PR-URL: https://github.com/nodejs/node/pull/56833
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:29:15 -03:00
Antoine du Hamel cc644de126 doc: make MDN links to global classes more consistent
PR-URL: https://github.com/nodejs/node/pull/56924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:29:14 -03:00
Antoine du Hamel 93bba4eee1 doc: make MDN links to global classes more consistent in assert.md
PR-URL: https://github.com/nodejs/node/pull/56920
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-04-16 03:29:14 -03:00
Antoine du Hamel ad03c85f98 doc: make MDN links to global classes more consistent
PR-URL: https://github.com/nodejs/node/pull/56923
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-04-16 03:29:14 -03:00
Antoine du Hamel 96c2a90dee doc: make MDN links to global classes more consistent in util.md
PR-URL: https://github.com/nodejs/node/pull/56922
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-04-16 03:29:14 -03:00
Antoine du Hamel 6bb73c0745 doc: make MDN links to global classes more consistent in buffer.md
PR-URL: https://github.com/nodejs/node/pull/56921
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-04-16 03:29:13 -03:00
Cheng a893da9be7 build: link with Security.framework in GN build
PR-URL: https://github.com/nodejs/node/pull/56895
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:29:13 -03:00
Joyee Cheung bbdb10bc2c crypto: fix X509* leak in --use-system-ca
The X509 structures are never freed. Use ncrypto::X509Pointer to
manage it automatically and move the X509* to PEM conversion into
a helper to be reused by integration in other systems.

PR-URL: https://github.com/nodejs/node/pull/56832
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:29:13 -03:00
James M Snell a1f92898c0 src: improve error handling in encoding_binding.cc
PR-URL: https://github.com/nodejs/node/pull/56915
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-04-16 03:29:12 -03:00
Colin Ihrig 6067bea027 sqlite: restore changes from #55373
PR #55373 introduced a performance improvement for the all()
method of prepared statements. Those changes appear to have been
accidentally overwritten in #54181. This change restores the
overwritten code.

Refs: https://github.com/nodejs/node/pull/55373
Refs: https://github.com/nodejs/node/pull/54181
PR-URL: https://github.com/nodejs/node/pull/56908
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-04-16 03:29:12 -03:00
Rafael Gonzaga 824cf35475 doc: update post sec release process
PR-URL: https://github.com/nodejs/node/pull/56907
Fixes: https://github.com/nodejs-private/security-release/issues/52
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-04-16 03:29:12 -03:00
James M Snell dee8793d94 src: improve error handling in permission.cc
PR-URL: https://github.com/nodejs/node/pull/56904
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
2025-04-16 03:29:12 -03:00
James M Snell f41bc4cfd7 src: improve error handling in node_sqlite
PR-URL: https://github.com/nodejs/node/pull/56891
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-04-16 03:29:11 -03:00
Chengzhong Wu 027749eb17 doc: update websocket link to avoid linking to self
The link `WebSocket` is pointing to the section itself.

PR-URL: https://github.com/nodejs/node/pull/56897
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-04-16 03:29:11 -03:00
Node.js GitHub Bot 815fcef73d meta: move one or more collaborators to emeritus
PR-URL: https://github.com/nodejs/node/pull/56889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-04-16 03:29:11 -03:00
Juan José 5dcb9d632b doc: mark --env-file-if-exists flag as experimental
As `--env-file` is experimental, this must be marked as experimental as
well.

Refs: https://github.com/nodejs/node/issues/56887
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56893
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-04-16 03:29:11 -03:00
James M Snell e4df6181bf src: improve error handling in node_os by removing ToLocalChecked
PR-URL: https://github.com/nodejs/node/pull/56888
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-04-16 03:29:10 -03:00
James M Snell 2c96e7a32c src: improve error handling in node_url
Eliminate uses of USE and ToLocalChecked to properly
propagate errors

PR-URL: https://github.com/nodejs/node/pull/56886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-04-16 03:29:10 -03:00
Cheng 02cd8e0a50 build: do not put commands in sources variables
PR-URL: https://github.com/nodejs/node/pull/56885
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-04-16 03:29:10 -03:00
Levi Zim 53a7bfce01 deps: V8: cherry-pick 9ab40592f697
Original commit message:

    [riscv] Flush icache in both local and remote harts

    Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

    Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
    Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#97673}

Refs: https://github.com/v8/v8/commit/9ab40592f697795f13e71325a18ecbe8cf5857ed
PR-URL: https://github.com/nodejs/node/pull/56781
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-04-16 03:28:05 -03:00
Michael Dawson 636f65cb1a deps: update cjs-module-lexer to 2.0.0
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/56855
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-04-16 03:28:04 -03:00
Node.js GitHub Bot 8f7b86a6e7 deps: update timezone to 2025a
PR-URL: https://github.com/nodejs/node/pull/56876
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-04-16 03:28:04 -03:00
Node.js GitHub Bot db31276bfa deps: update simdjson to 3.12.0
PR-URL: https://github.com/nodejs/node/pull/56874
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-04-16 03:28:04 -03:00
Node.js GitHub Bot d1d58d6198 deps: update googletest to e235eb3
PR-URL: https://github.com/nodejs/node/pull/56873
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-04-16 03:28:03 -03:00
Carlos Espa afae4b1216 test: change jenkins reporter
PR-URL: https://github.com/nodejs/node/pull/56808
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-04-16 03:26:28 -03:00
Colin Ihrig b26592a7c4 test: fix race condition in test-child-process-bad-stdio
test-child-process-bad-stdio.js contains a race condition between
a timeout in the test process and a timeout in the spawned child
process. This commit addresses the race condition by having the
child process wait indefinitely to be killed.

PR-URL: https://github.com/nodejs/node/pull/56845
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2025-04-16 03:26:27 -03:00
René bc672fcfdd sqlite: allow returning ArrayBufferViews from user-defined functions
PR-URL: https://github.com/nodejs/node/pull/56790
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:26:27 -03:00
Michaël Zasso ca4121b95a tools: remove test-asan/ubsan workflows
They have been disabled for months without anyone looking into fixing
the builds.

PR-URL: https://github.com/nodejs/node/pull/56823
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-16 03:26:23 -03:00
Luigi Pinca 73dc8c2140 build: add double quotes around <(python)
Handle cases where the path to the Python executable contains spaces.

Refs: https://github.com/nodejs/node/pull/56791
PR-URL: https://github.com/nodejs/node/pull/56826
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-04-02 15:15:49 +02:00
Michael Dawson 72c2279649 test: adjust check to use OpenSSL sec level
Some checks should use the sec level instead of the
OpenSSL version, adjust test-tls-client-mindhsize.js

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/56819
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-04-02 15:15:49 +02:00
ywave620 9192b7fa25 http: be more generational GC friendly
Avoid any potential ref to Buffer in new generation
from old generation

PR-URL: https://github.com/nodejs/node/pull/56767
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-04-02 15:15:49 +02:00
Node.js GitHub Bot 05b3dff275 deps: update simdjson to 3.11.6
PR-URL: https://github.com/nodejs/node/pull/56250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-04-02 15:15:49 +02:00
Michaël Zasso 866ac37255 tools: run macOS test workflow with Xcode 16.1
We have to remove `macos-13` as it doesn't have Xcode 16 available.

Refs: https://github.com/nodejs/node/pull/56824
PR-URL: https://github.com/nodejs/node/pull/56831
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-04-02 15:15:48 +02:00
Michaël Zasso 55ca46ad8e tools: update sccache and sccache-action
Respectively to v0.9.1 and v0.0.7.

PR-URL: https://github.com/nodejs/node/pull/56815
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-04-02 15:15:48 +02:00
Meghan Denny 9551b27651 test: test-crypto-scrypt.js doesn't need internals
PR-URL: https://github.com/nodejs/node/pull/56673
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-04-02 15:15:48 +02:00