BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
38,465 Commits 266 Branches 972 Tags
0d575fe61a8cbee00a7eba3a26b4652a8d6ef0ff
Commit Graph
38465 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Cheng Zhao 0d575fe61a gyp: put filenames in variables 
PR-URL: https://github.com/nodejs/node/pull/46965
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-03-18 10:24:38 +01:00
Nicolas DUBIEN aa6e9c80cf vm: properly handle defining props on any value 
While it was supposed to fix most of the remaining issues,
https://github.com/nodejs/node/pull/46458 missed some in strict mode.

This PR adds some additional checks. It also clarifies what we are
really checking to execute or not the `GetReturnValue`.

PR-URL: https://github.com/nodejs/node/pull/46615
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-03-18 09:19:19 +00:00
Joyee Cheung 30d92e88c6 doc: rename the startup performance initiative to startup snapshot (#47111) 
The initiative has been more focused on startup snapshot integration
which is more of a feature on its own, so rename it to "startup
snapshot".

Background: we are also considering adding a more generic performance
initiative in https://github.com/nodejs/TSC/issues/1343.
 2023-03-17 16:22:16 -04:00
Tobias Nießen 9e9f68af95 test: mark test-http-max-sockets as flaky on win32 
Refs: https://github.com/nodejs/node/issues/47116
PR-URL: https://github.com/nodejs/node/pull/47134
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
 2023-03-17 16:33:03 +00:00
Daniel Roe 7deb09cd96 doc: indicate that name is no longer an optional argument 
PR-URL: https://github.com/nodejs/node/pull/47102
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2023-03-17 12:48:53 +00:00
Keyhan Vakil c3537ae8cc src: fix duplication of externalized builtin code 
The `else` here was missing, causing us to append the file to its
existing `source` already in the map.

Refs: https://github.com/nodejs/node/pull/45942
PR-URL: https://github.com/nodejs/node/pull/47079
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-17 00:20:22 +00:00
Debadree Chatterjee d51541b720 test_runner: accept \x1b as a escape symbol 
Fixes: https://github.com/nodejs/node/issues/46959
PR-URL: https://github.com/nodejs/node/pull/47050
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-16 20:39:36 +00:00
Keyhan Vakil 8713c83462 src: remove dead comments about return_code_cache 
This behavior of sometimes returning the function & other times
returning the code cache was removed a long time ago in the referenced
PR, as evinced by the return type `MaybeLocal<Function>`. Remove these
incorrect comments.

Refs: https://github.com/nodejs/node/pull/24950
PR-URL: https://github.com/nodejs/node/pull/47083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-03-16 06:55:19 +00:00
Xuguang Mei 2566400aa2 repl: preserve preview on ESCAPE key press 
Fix: #46876
PR-URL: https://github.com/nodejs/node/pull/46878
Fixes: https://github.com/nodejs/node/issues/46876
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2023-03-16 03:24:23 +00:00
Node.js GitHub Bot 2fc6e03bfa tools: update lint-md-dependencies to rollup@3.19.1 
PR-URL: https://github.com/nodejs/node/pull/47045
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-15 19:04:10 +00:00
Tony Gorez d4ac94502e tools: align update-ada.sh with other scripts 
PR-URL: https://github.com/nodejs/node/pull/47044
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-03-15 19:03:58 +00:00
Michaël Zasso fa8465794d 2023-03-15, Version 19.8.1 (Current) 
Notable changes:

This release contains a single revert of a change that was introduced in v19.8.0
and introduced application crashes.

Fixes: https://github.com/nodejs/node/issues/47096
PR-URL: https://github.com/nodejs/node/pull/47104
 2023-03-15 18:11:57 +01:00
Tobias Nießen 124bda90e9 src: remove SSL_CTX_get_tlsext_ticket_keys guards 
OPENSSL_NO_TLSEXT was removed from OpenSSL a long time ago and both
OpenSSL and BoringSSL always unconditionally define
SSL_CTX_get_tlsext_ticket_keys now.

PR-URL: https://github.com/nodejs/node/pull/47068
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-15 16:38:58 +00:00
Chengzhong Wu e6b4d30a2f src: bootstrap Web [Exposed=*] APIs in the shadow realm 
This is the initial work to bootstrap Web interfaces that are defined
with extended attributes `[Exposed=*]`.

The ShadowRealm instances are garbage-collected once it is
unreachable. However, V8 can not infer the reference cycles between
the per-realm strong persistent function handles and the realm's
context handle. To allow the context to be gc-ed once it is not
reachable, the per-realm persistent handles are attached to the
context's global object and the persistent handles are set as weak.

PR-URL: https://github.com/nodejs/node/pull/46809
Refs: https://github.com/nodejs/node/issues/42528
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-03-16 00:22:06 +08:00
Chengzhong Wu 41b186722c lib: distinguish webidl interfaces with the extended property "Exposed" 
PR-URL: https://github.com/nodejs/node/pull/46809
Refs: https://github.com/nodejs/node/issues/42528
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-03-16 00:21:58 +08:00
Michaël Zasso d0153aee36 Revert "vm: fix leak in vm.compileFunction when importModuleDynamically is used" 
This reverts commit 986498b7b3.

Fixes: https://github.com/nodejs/node/issues/47096
PR-URL: https://github.com/nodejs/node/pull/47101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-03-15 14:35:06 +00:00
Rafael Gonzaga 1726da9300 permission: add path separator to loader check 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/47030
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-03-15 14:27:26 +00:00
Keyhan Vakil 0b328b2e8f doc: fix "maintaining dependencies" heading typos 
Fix the obvious "IZA" typo. Also remove a period, since that seems to
match the rest of the doc folder.

PR-URL: https://github.com/nodejs/node/pull/47082
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-03-15 07:18:53 +00:00
Keyhan Vakil 85d614090b src: fix clang 14 linker error 
Compiling with clang 14 on Ubuntu was failing with a linker error that
`node::MaybeStackBuffer::AllocateSufficientStorage` was undefined in
`src/inspector/node_string.cc`. I bisected it to the referenced PR.
Include `util-inl.h` which defines
`node::MaybeStackBuffer::AllocateSufficientStorage`.

Refs: https://github.com/nodejs/node/pull/46817
PR-URL: https://github.com/nodejs/node/pull/47057
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-03-15 03:20:22 +00:00
Tobias Nießen 1cfe058778 test: fix test-permission-deny-fs-wildcard (win32) 
The test fails on Windows when the working directory is not on a 'C:'
drive. For example, it always fails during the coverage-windows GitHub
action, which runs tests on drive 'D:'.

Fixes: https://github.com/nodejs/node/issues/47093
PR-URL: https://github.com/nodejs/node/pull/47095
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-03-15 01:57:15 +00:00
theanarkh f543c054fc inspector: fix session.disconnect crash 
PR-URL: https://github.com/nodejs/node/pull/46942
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-03-14 23:27:27 +00:00
Michaël Zasso 115c9ac68d 2023-03-14, Version 19.8.0 (Current) 
Notable changes:

buffer:
  * (SEMVER-MINOR) add Buffer.copyBytesFrom(...) (James M Snell) https://github.com/nodejs/node/pull/46500
doc:
  * add marco-ippolito to collaborators (Marco Ippolito) https://github.com/nodejs/node/pull/46816
events:
  * (SEMVER-MINOR) add listener argument to listenerCount (Paolo Insogna) https://github.com/nodejs/node/pull/46523
lib:
  * (SEMVER-MINOR) add AsyncLocalStorage.bind() and .snapshot() (flakey5) https://github.com/nodejs/node/pull/46387
src:
  * (SEMVER-MINOR) add `fs.openAsBlob` to support File-backed Blobs (James M Snell) https://github.com/nodejs/node/pull/45258
tls:
  * (SEMVER-MINOR) support automatic DHE (Tobias Nießen) https://github.com/nodejs/node/pull/46978
url:
  * (SEMVER-MINOR) implement URLSearchParams size getter (James M Snell) https://github.com/nodejs/node/pull/46308
wasi:
  * (SEMVER-MINOR) add support for version when creating WASI (Michael Dawson) https://github.com/nodejs/node/pull/46469
worker:
  * (SEMVER-MINOR) add support for worker name in inspector and trace_events (Debadree Chatterjee) https://github.com/nodejs/node/pull/46832

PR-URL: https://github.com/nodejs/node/pull/47087
 2023-03-14 19:52:10 +01:00
Steve Herzog 334bb179df test_runner: support defining test reporter in NODE_OPTIONS 
Adds --test-reporter and --test-reporter-destination as
allowable options in NODE_OPTIONS. Also adds the CLI flag
--test-child-process to allow forcing the default
test-reporter for inter-process communication.

Fixes: https://github.com/nodejs/node/issues/46484
PR-URL: https://github.com/nodejs/node/pull/46688
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-03-14 16:59:35 +00:00
Chengzhong Wu b80ab31124 node-api: verify cleanup hooks order 
Cleanup hooks are called before the environment shutdown finalizer
invocations.

PR-URL: https://github.com/nodejs/node/pull/46692
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-03-15 00:57:25 +08:00
Ben Noordhuis 4ae7c7a002 meta: ask expected behavior reason in bug template 
It happens too often that bug reporters only report _what_ they expect
to see without motivating _why_. Having to repeatedly ask for that info
gets old.

PR-URL: https://github.com/nodejs/node/pull/47049
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-14 10:20:13 +00:00
Node.js GitHub Bot aa93c8b8c6 tools: update eslint to 8.36.0 
PR-URL: https://github.com/nodejs/node/pull/47046
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-03-14 08:51:36 +00:00
Filip Skokan f41d507862 tools: add daily WPT Report workflow step summary 
PR-URL: https://github.com/nodejs/node/pull/46763
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-03-13 22:01:08 +00:00
Filip Skokan 22e22e023e tools: add undici WPTs to daily WPT Report 
PR-URL: https://github.com/nodejs/node/pull/46763
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-03-13 22:01:07 +00:00
Node.js GitHub Bot f6e4e12d29 deps: update undici to 5.21.0 
PR-URL: https://github.com/nodejs/node/pull/47063
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-03-13 20:36:46 +00:00
Anna Henningsen f95d7c0179 src: use std::array for passing argv in node::url 
Implements a review suggestion from 72e971ee2e.

Refs: https://github.com/nodejs/node/pull/47001#issuecomment-1462999332
PR-URL: https://github.com/nodejs/node/pull/47035
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-03-13 20:28:57 +00:00
Tobias Nießen 51380f20cf doc: remove remaining SSL_OP_NETSCAPE_*_BUG 
I missed these two in db81af61ce because I
went by OpenSSL's list of obsolete flags, which turned out to be
incomplete. See https://github.com/openssl/openssl/pull/20443.

Refs: https://github.com/nodejs/node/pull/46954
Refs: https://github.com/openssl/openssl/pull/20443
PR-URL: https://github.com/nodejs/node/pull/47066
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-13 17:49:39 +00:00
Tobias Nießen c2e4b1fa9a crypto: remove ALPN_ENABLED 
This constant was likely introduced for feature detection, but it has
been pointless for a long time.

1. I am not aware of any possible Node.js build configuration (on any
   recent/supported release line) that would have crypto.constants but
   not crypto.constants.ALPN_ENABLED.
2. There is no evidence of this constant being used for feature
   detection in the ecosystem. In fact, both internal and external type
   definitions for crypto.constants simply assume that the constant
   exists.
3. There is no good reason for any modern TLS stack to not support ALPN.
   It looks like ALPN might have been optional in much earlier versions
   of OpenSSL, but all recent versions of OpenSSL unconditionally
   support ALPN as far as I can tell.

Refs: https://github.com/nodejs/node/pull/46956
PR-URL: https://github.com/nodejs/node/pull/47028
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-03-13 14:11:35 +00:00
Victor Hiairrassary 1ef4faa29b doc: fix typo in test.md 
PR-URL: https://github.com/nodejs/node/pull/47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-03-13 12:01:15 +00:00
Debadree Chatterjee 28c9fb9592 benchmark: add a benchmark for URLSearchParams creation and toString() 
Refs: https://github.com/nodejs/performance/issues/56
PR-URL: https://github.com/nodejs/node/pull/46810
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-03-13 10:37:41 +00:00
Eungyu Lee f8bf4987e9 debugger: improve validations and documents for watch and unwatch 
- debugger: add string validation for watch(expr)
- debugger: add help document for watch(index)
- test: add test for watch(index) command
- doc: add information on unwatch(index) option

PR-URL: https://github.com/nodejs/node/pull/46947
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
 2023-03-13 04:29:53 +00:00
Gireesh Punathil 59dd9caecb doc: amend support tier qualifier 
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: https://github.com/nodejs/node/pull/42802
PR-URL: https://github.com/nodejs/node/pull/42805
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-13 08:21:21 +05:30
Tobias Nießen 2660a321e1 tls: support automatic DHE 
Node.js has so far only supported user-defined DHE parameters and even
recommended generating custom parameters. This change lets users set the
dhparam option to 'auto' instead, in which case DHE parameters of
sufficient strength are selected automatically (from a small set of
well-known parameters). This has been recommended by OpenSSL for quite a
while, and it makes it much easier for Node.js TLS servers to properly
support DHE-based perfect forward secrecy.

This also updates the documentation to prioritize ECDHE over DHE, mostly
because the former tends to be more efficient and is enabled by default.

PR-URL: https://github.com/nodejs/node/pull/46978
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-03-12 18:35:55 +00:00
Eungyu Lee 7f2ab4e629 debugger: add a command to set which lines to check for context 
PR-URL: https://github.com/nodejs/node/pull/46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
 2023-03-12 04:47:18 +00:00
Antoine du Hamel 03fd5ae04d test: move test-tls-autoselectfamily-servername to test/internet 
And switch from `google.com` to `nodejs.org`.

PR-URL: https://github.com/nodejs/node/pull/47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-03-11 13:52:43 +00:00
Theodor Steiner 10c1ab00fd benchmark: replace table in docs with description of file tree structure 
The markdown table in `benchmark/README.md` has grown stale, no
longer providing an overview over all existing benchmarks. As it has
proven difficult to keep an exhaustive listing of available benchmarks
up to date, this commit provides a description of how the directory is
structured instead.

PR-URL: https://github.com/nodejs/node/pull/46991
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-11 09:53:50 +00:00
Darshan Sen 86c831f643 doc,test: extend the list of platforms supported by single-executables 
Now that https://github.com/nodejs/node/pull/46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/47026
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-03-11 08:58:52 +00:00
Filip Skokan 27a5bd7f30 tools: dont use cached node versions in daily wpt 
PR-URL: https://github.com/nodejs/node/pull/47024
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-03-11 07:22:39 +00:00
Abdirahim Musse 5012ab4e86 test: fallback to IPv4 if IPv6 is unavailable 
openssl seems to default to use IPv6.
This change adds a checks if IPv6 is unavailable and uses IPv4 instead.
On the Node.js CI IBM i build system IPv6 is currently disabled.
This change should resolve the following test case failures:
- https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1085/testReport/(root)/test/sequential_test_tls_psk_client_/
- https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1085/testReport/(root)/test/sequential_test_tls_securepair_client_/

PR-URL: https://github.com/nodejs/node/pull/47017
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-11 06:26:25 +00:00
Marco Ippolito 359172868f tools: automate cares update 
PR-URL: https://github.com/nodejs/node/pull/46993
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-03-10 21:17:06 +00:00
Ruy Adorno 59d85f50ea doc: fix typo on esm loaders example 
Fixes a small typo on the Transpiler loader example.

PR-URL: https://github.com/nodejs/node/pull/47015
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-10 17:09:54 +00:00
Deokjin Kim b0d31bb854 net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout' 
Document describes that the value have to be 10 if passed value to
`setDefaultAutoSelectFamilyAttemptTimeout` is less than 10.
So need to use 10 for 'if' statement and fix typo in document.

Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue
PR-URL: https://github.com/nodejs/node/pull/47012
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-03-10 15:07:55 +00:00
Yagiz Nizipli 72e971ee2e url: fix array overrun in node:url::SetArgs() 
PR-URL: https://github.com/nodejs/node/pull/47001
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-10 14:09:53 +00:00
Joyee Cheung 1ccc8cc858 meta: add single-executable labels and code owners 
PR-URL: https://github.com/nodejs/node/pull/47004
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-10 11:47:47 +00:00
Filip Skokan 57c4070c86 test,crypto: update WebCryptoAPI WPT 
PR-URL: https://github.com/nodejs/node/pull/47010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-10 10:51:50 +00:00
Tobias Nießen bcebb914f5 test: simplify test-tls-ecdh-multiple 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: https://github.com/nodejs/node/pull/46751
PR-URL: https://github.com/nodejs/node/pull/46963
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-03-09 11:54:28 +00:00