BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
42,453 Commits 236 Branches 964 Tags
195df659e9143635c78e124ca8a09cf87dbc4b3e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Antoine du Hamel 195df659e9 doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors 
PR-URL: https://github.com/nodejs/node/pull/55248
Refs: https://github.com/nodejs/node/pull/17887
Refs: https://github.com/nodejs/node/pull/32997
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-10-05 12:36:27 +02:00
Antoine du Hamel 8a57550d20 doc: fix unordered error anchors 
PR-URL: https://github.com/nodejs/node/pull/55242
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-10-04 19:20:21 +02:00
Antoine du Hamel 7c9ceabf38 doc: use correct dash in stability status 
All other stability statuses use `-`, this one uses `–`. This commit
removes the inconsistency.

PR-URL: https://github.com/nodejs/node/pull/55200
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2024-10-04 19:20:21 +02:00
Antoine du Hamel 65fbe94d45 test: add escapePOSIXShell util 
PR-URL: https://github.com/nodejs/node/pull/55125
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-10-04 19:20:18 +02:00
Antoine du Hamel c308862d2e test_runner: avoid spread operator on arrays 
PR-URL: https://github.com/nodejs/node/pull/55143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 19:20:18 +02:00
Antoine du Hamel b1ebb0d8ca buffer: coerce extrema to int in blob.slice 
PR-URL: https://github.com/nodejs/node/pull/55141
Fixes: https://github.com/nodejs/node/issues/55139
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 19:20:17 +02:00
Antoine du Hamel 7982d3d4ed tools: only check teams on the default branch 
PR-URL: https://github.com/nodejs/node/pull/55124
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 19:20:17 +02:00
Antoine du Hamel b12b4a23e4 doc: remove random horizontal separators in process.md 
PR-URL: https://github.com/nodejs/node/pull/55149
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2024-10-04 19:20:14 +02:00
Antoine du Hamel 0fb446e207 esm: do not interpret "main" as a URL 
As documented, its value is a path.

PR-URL: https://github.com/nodejs/node/pull/55003
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-10-04 19:20:13 +02:00
Antoine du Hamel b885f0583c test: fix more tests that fail when path contains a space 
PR-URL: https://github.com/nodejs/node/pull/55088
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-10-04 10:20:28 +02:00
Antoine du Hamel 85f1187942 test: fix assertSnapshot when path contains a quote 
PR-URL: https://github.com/nodejs/node/pull/55087
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2024-10-04 10:20:27 +02:00
Antoine du Hamel 7eaeba499a test_runner: fix mocking modules with quote in their URL 
PR-URL: https://github.com/nodejs/node/pull/55083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2024-10-04 10:20:27 +02:00
Antoine du Hamel fdae57f1e1 test: fix some tests when path contains % 
Tests should pass even if the path where the repo is cloned contains
URL-significant chars.

PR-URL: https://github.com/nodejs/node/pull/55082
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2024-10-04 10:20:27 +02:00
Antoine du Hamel a50dd21423 test: do not assume process.execPath contains no spaces 
We had a bunch of tests that would fail if run from an executable that
contains any char that should be escaped when run from a shell.

PR-URL: https://github.com/nodejs/node/pull/55028
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 10:20:19 +02:00
Antoine du Hamel c56e324cb8 test: fix test-vm-context-dont-contextify when path contains a space 
Because of the double encoding, the test would fail as soon as the path
contains a space or any other char that's already encoded by
`pathToFileURL`.

PR-URL: https://github.com/nodejs/node/pull/55026
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 10:20:19 +02:00
Antoine du Hamel 1d169764db module: report unfinished TLA in ambiguous modules 
PR-URL: https://github.com/nodejs/node/pull/54980
Fixes: https://github.com/nodejs/node/issues/54931
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2024-10-04 10:20:09 +02:00
Antoine du Hamel fc90d7c63a worker: handle --input-type more consistently 
PR-URL: https://github.com/nodejs/node/pull/54979
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-10-04 10:20:09 +02:00
Antoine du Hamel f2d74a26a3 doc: fix history of process.features 
PR-URL: https://github.com/nodejs/node/pull/54982
Refs: https://github.com/nodejs/node/commit/aa0308d6182b2f7a2508373770952eefd2fdb0ac
Refs: https://github.com/nodejs/node/commit/9010f5fbab2695e6c0435db396f3e92118da6d76
Refs: https://github.com/nodejs/node/commit/52a40e0fd5f59b295fe9bb74e7f14b35ca4bf96c
Refs: https://github.com/nodejs/node/commit/b3ef289ffb7db476d284866658213f04415ea92d
Refs: https://github.com/nodejs/node/pull/2564
Refs: https://github.com/nodejs/node/pull/25819
Refs: https://github.com/nodejs/node/pull/27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-10-04 10:20:04 +02:00
Antoine du Hamel a624002fff esm: throw ERR_REQUIRE_ESM instead of ERR_INTERNAL_ASSERTION 
PR-URL: https://github.com/nodejs/node/pull/54868
Fixes: https://github.com/nodejs/node/issues/54773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-09-14 00:20:35 +02:00
Antoine du Hamel 440c256d76 doc: add support link for aduh95 
PR-URL: https://github.com/nodejs/node/pull/54866
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-09-14 00:20:35 +02:00
Antoine du Hamel 5f02e1b850 lib: move Symbol[Async]Dispose polyfills to internal/util 
PR-URL: https://github.com/nodejs/node/pull/54853
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-14 00:20:34 +02:00
Antoine du Hamel 31d4ef91ee esm: fix support for URL instances in import.meta.resolve 
PR-URL: https://github.com/nodejs/node/pull/54690
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-14 00:20:25 +02:00
Antoine du Hamel b5137f6405 test: fix test-process-load-env-file when path contains ' 
If the repo is cloned on a path that contains a quote, the test should
not fail.

PR-URL: https://github.com/nodejs/node/pull/54511
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-12 11:06:44 +02:00
Antoine du Hamel 93fab49099 tools: add util scripts to land and rebase PRs 
PR-URL: https://github.com/nodejs/node/pull/54656
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2024-09-12 11:06:43 +02:00
Antoine du Hamel 02ac5376b9 crypto: remove unused kHashTypes internal 
PR-URL: https://github.com/nodejs/node/pull/54627
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-09-12 11:06:38 +02:00
Antoine du Hamel 02d664b75f test: fix improper path to URL conversion 
PR-URL: https://github.com/nodejs/node/pull/54509
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-30 15:52:12 -03:00
Antoine du Hamel 0cf78aa24b test_runner: refactor mock_loader 
PR-URL: https://github.com/nodejs/node/pull/54223
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-30 15:52:11 -03:00
Antoine du Hamel 1c29e74d30 test_runner: make mock.module's specifier consistent with import() 
The previous implementation was trying to follow both `require` and
`import` conventions. It is not practical to try to follow both,
and aligning with `import()` seems to be what makes the most sense.

PR-URL: https://github.com/nodejs/node/pull/54416
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-25 18:19:12 -03:00
Antoine du Hamel fe793a6103 test_runner: do not expose internal loader 
PR-URL: https://github.com/nodejs/node/pull/54106
Fixes: https://github.com/nodejs/node/issues/54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-14 08:37:04 +02:00
Antoine du Hamel 100225fbe1 module: do not attempt to strip type when there's no source 
PR-URL: https://github.com/nodejs/node/pull/54287
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-14 08:37:02 +02:00
Antoine du Hamel f5cfa4454e test: refactor test-runner-module-mocking 
PR-URL: https://github.com/nodejs/node/pull/54233
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2024-08-14 08:15:28 +02:00
Antoine du Hamel 3835131559 tools: add workflow to ensure README lists are in sync with gh teams 
PR-URL: https://github.com/nodejs/node/pull/53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:14:58 +02:00
Antoine du Hamel 98fed763f7 build: add --without-amaro build flag 
PR-URL: https://github.com/nodejs/node/pull/54136
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-14 08:14:48 +02:00
Antoine du Hamel 7772b46038 doc: update list of Triagers on the README.md 
PR-URL: https://github.com/nodejs/node/pull/54138
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-14 08:14:48 +02:00
Antoine du Hamel 43afcbf9dd tools: fix SLACK_TITLE in invalid commit workflow 
PR-URL: https://github.com/nodejs/node/pull/53912
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-05 11:15:41 -03:00
Antoine du Hamel 5cea7ed706 test: reduce flakiness of test-assert-esm-cjs-message-verify 
PR-URL: https://github.com/nodejs/node/pull/53967
Fixes: https://github.com/nodejs/node/issues/53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-05 11:15:41 -03:00
Antoine du Hamel 58cb0dd8a6 test: use PYTHON executable from env in assertSnapshot 
PR-URL: https://github.com/nodejs/node/pull/53938
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-08-05 11:15:41 -03:00
Antoine du Hamel 44a08f75b0 doc,tools: enforce use of node: prefix 
PR-URL: https://github.com/nodejs/node/pull/53950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2024-08-05 11:15:41 -03:00
Antoine du Hamel dcca9ba560 esm: refactor get_format 
PR-URL: https://github.com/nodejs/node/pull/53872
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2024-07-28 09:51:30 +02:00
Antoine du Hamel 5b8dd78112 doc: fix release date for 22.5.0 
The release has been postponed and I forgot to update the date in the
`CHANGELOG_V22.md`.

PR-URL: https://github.com/nodejs/node/pull/53889
Refs: https://github.com/nodejs/node/pull/53826
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2024-07-28 08:53:28 +02:00
Antoine du Hamel dd2c0f349a doc: fix casing of GitHub handle for two collaborators 
PR-URL: https://github.com/nodejs/node/pull/53857
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2024-07-28 08:53:27 +02:00
Antoine du Hamel 34de83994e 2024-07-17, Version 22.5.0 (Current) 
Notable changes:

http:
  * (SEMVER-MINOR) expose websockets (Natalia Venditto) https://github.com/nodejs/node/pull/53721
lib:
  * (SEMVER-MINOR) add `node:sqlite` module (Colin Ihrig) https://github.com/nodejs/node/pull/53752
module:
  * add `__esModule` to `require()`'d ESM (Joyee Cheung) https://github.com/nodejs/node/pull/52166
path:
  * (SEMVER-MINOR) add `matchesGlob` method (Aviv Keller) https://github.com/nodejs/node/pull/52881
process:
  * (SEMVER-MINOR) port on-exit-leak-free to core (Vinicius Lourenço) https://github.com/nodejs/node/pull/53239
stream:
  * (SEMVER-MINOR) pipeline wait for close before calling the callback (jakecastelli) https://github.com/nodejs/node/pull/53462
test_runner:
  * support glob matching coverage files (Aviv Keller) https://github.com/nodejs/node/pull/53553
worker:
  * (SEMVER-MINOR) add `postMessageToThread` (Paolo Insogna) https://github.com/nodejs/node/pull/53682

PR-URL: https://github.com/nodejs/node/pull/53826
 2024-07-17 10:15:03 +02:00
Antoine du HamelandYagiz Nizipli ab9adfc42a tls: remove prototype primordials 
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/53699
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-16 12:01:13 +02:00
Antoine du HamelandYagiz Nizipli 7debb6c36e http: remove prototype primordials 
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/53698
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-07-16 12:01:11 +02:00
Antoine du HamelandYagiz Nizipli 1397f5d9f4 http2: remove prototype primordials 
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/53696
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-07-16 12:01:10 +02:00
Antoine du Hamel bac28678e6 test: do not assume cwd in snapshot tests 
PR-URL: https://github.com/nodejs/node/pull/53146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-16 12:01:06 +02:00
Antoine du Hamel 6e66d9763f test: mark test-benchmark-crypto as flaky 
PR-URL: https://github.com/nodejs/node/pull/52955
Refs: https://github.com/nodejs/node/issues/52690
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-01 15:31:13 +02:00
Antoine du Hamel 9ece63d415 tools: do not run Corepack code before it's reviewed 
Also enable running `make corepack-update` when `node`/`npm` is not
available globally.

PR-URL: https://github.com/nodejs/node/pull/53405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-06-20 14:40:42 +02:00
Antoine du Hamel 33242ff042 build: add --skip-tests to test-ci-js target 
PR-URL: https://github.com/nodejs/node/pull/53105
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-06-01 10:55:07 +02:00
Antoine du Hamel 9a47792cd1 test: skip test-setproctitle when ps is not available 
PR-URL: https://github.com/nodejs/node/pull/53104
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-06-01 10:55:02 +02:00
Antoine du Hamel 4cdb05a7a2 module: do not set CJS variables for Worker eval 
PR-URL: https://github.com/nodejs/node/pull/53050
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-06-01 10:55:01 +02:00
Antoine du Hamel c1b3e0ed6f Revert "tools: add --certify-safe to nci-ci" 
This reverts commit 0fa07d4442.

PR-URL: https://github.com/nodejs/node/pull/53098
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2024-06-01 10:55:01 +02:00
Antoine du HamelandMichaël Zasso 494fa542af test: replace .substr with .slice 
`String.prototype.substr` is deprecated, and using it will raise an
error when using ESLint 9+.

Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/53070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2024-06-01 10:54:57 +02:00
Antoine du Hamel 466e0c1321 tools: update gr2m/create-or-update-pull-request-action 
PR-URL: https://github.com/nodejs/node/pull/52843
Refs: https://github.com/gr2m/create-or-update-pull-request-action/releases/tag/v1.9.4
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
 2024-05-08 07:12:45 +02:00
Antoine du Hamel 1ee38a5ec1 tools: specify a commit-message for V8 update workflow 
PR-URL: https://github.com/nodejs/node/pull/52844
Fixes: https://github.com/nodejs/node/issues/50497
Refs: https://github.com/gr2m/create-or-update-pull-request-action/issues/280
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-05-08 07:12:42 +02:00
Antoine du Hamel 317998a1e8 tools: fix V8 update workflow 
PR-URL: https://github.com/nodejs/node/pull/52822
Fixes: https://github.com/nodejs/node/issues/50497
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-05-08 07:12:42 +02:00
Antoine du Hamel a0147ff8d0 doc: simplify copy-pasting of branch-diff commands 
PR-URL: https://github.com/nodejs/node/pull/52757
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-05-08 07:12:26 +02:00
Antoine du Hamel 87b87a8f60 2024-05-02, Version 22.1.0 (Current) 
Notable changes:

buffer:
  * improve `base64` and `base64url` performance (Yagiz Nizipli) https://github.com/nodejs/node/pull/52428
dns:
  * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) https://github.com/nodejs/node/pull/52492
events,doc:
  * mark CustomEvent as stable (Daeyeon Jeong) https://github.com/nodejs/node/pull/52618
lib, url:
  * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) https://github.com/nodejs/node/pull/52509
module:
  * (SEMVER-MINOR) implement NODE_COMPILE_CACHE for automatic on-disk code caching (Joyee Cheung) https://github.com/nodejs/node/pull/52535
net:
  * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) https://github.com/nodejs/node/pull/52474
src:
  * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) https://github.com/nodejs/node/pull/52595
src,permission:
  * throw async errors on async APIs (Rafael Gonzaga) https://github.com/nodejs/node/pull/52730
test_runner:
  * (SEMVER-MINOR) add --test-skip-pattern cli option (Aviv Keller) https://github.com/nodejs/node/pull/52529
url:
  * (SEMVER-MINOR) implement parse method for safer URL parsing (Ali Hassan) https://github.com/nodejs/node/pull/52280

PR-URL: https://github.com/nodejs/node/pull/52768
 2024-05-02 09:54:38 +02:00
Antoine du Hamel d568a9a38e test: mark test-error-serdes as flaky 
PR-URL: https://github.com/nodejs/node/pull/52739
Refs: https://github.com/nodejs/node/issues/52630
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-04-29 22:46:32 +02:00
Antoine du Hamel db421bdefc tools: take co-authors into account in find-inactive-collaborators 
PR-URL: https://github.com/nodejs/node/pull/52669
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-04-29 22:46:32 +02:00
Antoine du Hamel d1adc9b140 lib: enforce ASCII order in error code imports 
PR-URL: https://github.com/nodejs/node/pull/52625
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2024-04-29 22:46:29 +02:00
Antoine du Hamel f9ddd77ff3 tools: add lint rule to keep primordials in ASCII order 
PR-URL: https://github.com/nodejs/node/pull/52592
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-04-29 22:46:28 +02:00
Antoine du Hamel 8ae1507ae1 tools: add a linter for README lists 
PR-URL: https://github.com/nodejs/node/pull/52476
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-04-29 22:46:22 +02:00
Antoine du HamelandVinícius Lourenço a8b21fdc90 process: wait for 'exit' before printing result 
Co-authored-by: Vinícius Lourenço <contact@viniciusl.com.br>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/52172
Refs: https://github.com/nodejs/node/pull/52077
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2024-03-25 12:28:54 +00:00
Antoine du Hamel bae14b7914 test: do not set concurrency on parallelized runs 
Our CI already run test files in parallel, having `node:test` spawns
child processes concurrently could lead to oversubscribing the CI
machine. This commit sets the `concurrency` depending
on the presence of `TEST_PARALLEL` in the env, so running the test
file individually still spawns child processes concurrently, and
running the whole test suite does not oversubscribe the machine.

PR-URL: https://github.com/nodejs/node/pull/52177
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-03-23 21:11:28 +00:00
Antoine du Hamel 6dd1c75f4a crypto: fix input validation in crypto.hash 
PR-URL: https://github.com/nodejs/node/pull/52070
Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-03-21 12:12:31 +01:00
Antoine du Hamel c714cda9a7 test: add spawnSyncAndAssert util 
PR-URL: https://github.com/nodejs/node/pull/52132
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-03-20 19:44:14 +01:00
Antoine du Hamel be75821a12 test: add test for using --print with promises 
PR-URL: https://github.com/nodejs/node/pull/52137
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2024-03-19 07:02:55 +00:00
Antoine du Hamel d78a565713 doc: clarify what moderation issues are for 
PR-URL: https://github.com/nodejs/node/pull/51990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-03-08 19:01:00 +00:00
Antoine du Hamel 16579d7191 test: reduce flakiness of test-runner-output 
PR-URL: https://github.com/nodejs/node/pull/51952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2024-03-05 18:53:26 +00:00
Antoine du Hamel 2a33e95093 build: respect the NODE env variable in Makefile 
PR-URL: https://github.com/nodejs/node/pull/51743
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-03-03 20:06:53 +00:00
Antoine du Hamel 14293814a7 doc: clarify Corepack threat model 
PR-URL: https://github.com/nodejs/node/pull/51917
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-03-01 23:02:41 +00:00
Antoine du Hamel 10c6596f6d doc: fix globals.md introduction 
Splitting the introduction sentence in two paragraphs so it's
clearer the list of variables only apply to the second sentence.

PR-URL: https://github.com/nodejs/node/pull/51742
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-02-15 08:30:44 +00:00
Antoine du Hamel 3fbe1579ce esm: improve error when calling import.meta.resolve from data: URL 
PR-URL: https://github.com/nodejs/node/pull/49516
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-01-31 23:22:18 +01:00
Antoine du Hamel 4ab63db9e2 tools: run build-windows workflow only on source changes 
PR-URL: https://github.com/nodejs/node/pull/51596
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
 2024-01-31 14:34:03 +00:00
Antoine du Hamel a7729737cf module: fix crash when built-in module export a default key 
PR-URL: https://github.com/nodejs/node/pull/51481
Fixes: https://github.com/nodejs/node/issues/51480
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2024-01-19 08:42:07 +00:00
Antoine du Hamel 9fce1df548 doc: add links in offboarding.md 
PR-URL: https://github.com/nodejs/node/pull/51440
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-01-14 10:26:35 +00:00
Antoine du Hamel a717fa2111 esm: fix hint on invalid module specifier 
PR-URL: https://github.com/nodejs/node/pull/51223
Fixes: https://github.com/nodejs/node/issues/51216
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-12-23 20:38:08 +00:00
Antoine du Hamel 825163c5ab lib: fix use of --frozen-intrinsics with --jitless 
PR-URL: https://github.com/nodejs/node/pull/51248
Fixes: https://github.com/nodejs/node/issues/51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-12-23 12:38:24 +00:00
Antoine du Hamel f58a31bece doc: mark --jitless as experimental 
It's already documented as such, but it doesn't have the label.

PR-URL: https://github.com/nodejs/node/pull/51247
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2023-12-23 12:38:14 +00:00
Antoine du Hamel bc16952cda lib: reduce overhead of SafePromiseAllSettledReturnVoid calls 
It was simply calling `SafePromiseAllSettled`, which itself calls
`arrayToSafePromiseIterable` which wraps all promises into new
`SafePromise` object and wraps it into a `SafeArrayIterator`. Since we
don't care about the return value, we can take some shortcuts.

PR-URL: https://github.com/nodejs/node/pull/51243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-12-22 18:34:17 +00:00
Antoine du Hamel 898149fed8 doc: remove version from maintaining-dependencies.md 
Those create unreasonable maintenance burden as updating one dependency
will conflict with another one. It's unclear we get much value out from
duplicating this information in this document, so this commit removes it

PR-URL: https://github.com/nodejs/node/pull/51195
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-12-19 10:04:25 +00:00
Antoine du Hamel a49b77b80d doc: add deprecation notice to dirent.path 
Refs: https://github.com/nodejs/node/pull/51020
PR-URL: https://github.com/nodejs/node/pull/51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-12-05 21:15:23 +00:00
Antoine du Hamel 5b6aa530d0 doc: deprecate dirent.path 
PR-URL: https://github.com/nodejs/node/pull/51020
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-12-04 23:11:36 +00:00
Antoine du Hamel 2e458d9736 fs: introduce dirent.parentPath 
The goal is to replace `dirent.path` using a name that's less likely to
create confusion.
`dirent.path` value has not been stable, moving it to a different
property name should avoid breaking some upgrading user expectations.

PR-URL: https://github.com/nodejs/node/pull/50976
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-12-02 22:49:21 +00:00
Antoine du Hamel 4eafcf8ff5 esm: fallback to getSource when load returns nullish source 
When using the Modules Customization Hooks API to load CommonJS modules,
we want to support the returned value of `defaultLoad` which must be
nullish to preserve backward compatibility. This can be achieved by
fetching the source from the translator.

PR-URL: https://github.com/nodejs/node/pull/50825
Fixes: https://github.com/nodejs/node/issues/50435
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-11-29 10:12:05 +01:00
Antoine du Hamel 7981e2ee64 meta: clarify recommendation for bug reproductions 
Sometimes reporters link to a repo for their repro, which
not only likely takes them more time to setup, but also is less
convenient for maintainers. Setting up a repo goes against the idea of a
minimal repro, as if it was actually minimal, they would not have
bothered creating a repo.

PR-URL: https://github.com/nodejs/node/pull/50882
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
 2023-11-25 16:32:15 +00:00
Antoine du Hamel b0443690f8 doc: add a section regarding instanceof in primordials.md 
PR-URL: https://github.com/nodejs/node/pull/50874
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-11-25 09:15:58 +00:00
Antoine du Hamel 5dd7ba66ad doc: get rid of unnecessary eslint-skip comments 
PR-URL: https://github.com/nodejs/node/pull/50829
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2023-11-22 19:03:33 +00:00
Antoine du Hamel 56ea071421 meta: fix spacing in collaborator list 
PR-URL: https://github.com/nodejs/node/pull/50641
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-11-11 14:50:06 +00:00
Antoine du Hamel 0dfc59e4fc esm: bypass CJS loader in default load under --default-type=module 
This allows user to opt-out from using the monkey-patchable CJS loader,
even to load CJS modules.

PR-URL: https://github.com/nodejs/node/pull/50004
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-11-10 09:20:46 +01:00
Antoine du Hamel 309c71ae38 lib: add --no-experimental-global-navigator CLI flag 
PR-URL: https://github.com/nodejs/node/pull/50562
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
 2023-11-08 17:24:51 +00:00
Antoine du Hamel a3e09b3fdd module: execute --import sequentially 
PR-URL: https://github.com/nodejs/node/pull/50474
Fixes: https://github.com/nodejs/node/issues/50427
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-11-01 12:38:01 +00:00
Antoine du Hamel 69c0571f47 tools: run coverage CI only on relevant files 
PR-URL: https://github.com/nodejs/node/pull/50349
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2023-10-25 21:03:06 +00:00
Antoine du Hamel 8f742bb13f test: ensure never settling promises are detected 
PR-URL: https://github.com/nodejs/node/pull/50318
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-23 17:55:50 +00:00
Antoine du Hamel 2da66c1444 vm: use import attributes instead of import assertions 
The old import assertions proposal has been
renamed to "import attributes" with the following major changes:

1. The keyword is now `with` instead of `assert`.
2. Unknown assertions cause an error rather than being ignored.

This PR updates the documentation to encourage folks to use the new
syntax, and add aliases to preserve backward compatibility.

PR-URL: https://github.com/nodejs/node/pull/50141
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-23 17:30:05 +00:00
Antoine du Hamel 08ae8401f1 esm: do not give wrong hints when detecting file format 
PR-URL: https://github.com/nodejs/node/pull/50314
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-10-23 16:01:59 +00:00
Antoine du Hamel 745979cf39 Revert "test: set test-esm-loader-resolve-type as flaky" 
This reverts commit 2e4bb3c017.

PR-URL: https://github.com/nodejs/node/pull/50315
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-21 15:54:28 +00:00
Antoine du Hamel c38ba67a0d test: deflake test-esm-loader-resolve-type 
PR-URL: https://github.com/nodejs/node/pull/50273
Fixes: https://github.com/nodejs/node/issues/50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-10-21 09:25:11 +00:00
Antoine du Hamel 765339a32c test: deflake test-loaders-workers-spawned 
PR-URL: https://github.com/nodejs/node/pull/50251
Fixes: https://github.com/nodejs/node/issues/50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-19 10:44:46 +02:00