Benjamin Gruenbaum
1a6d4dce6d
events: getEventListeners static
...
PR-URL: https://github.com/nodejs/node/pull/35991
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-11-09 07:39:31 +00:00
Antoine du Hamel
ad98cf04f3
stream: remove isPromise utility function
...
The function was not checking if the parameter was actually a Promise
instance, but if it has a `then` method. Removing the utility function
in favor of a clearer `typeof` check, handling the case when the
thenable throws if then method is accessed more than once.
PR-URL: https://github.com/nodejs/node/pull/35925
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-11-09 06:17:29 +00:00
Momtchil Momtchev
adae822035
http2: centralise socket event binding in Http2Session
...
Move the socket event binding to the
HTTP2Session constructor so that an error
event could be delivered should the
constructor fail
Ref: https://github.com/nodejs/node/pull/35772
PR-URL: https://github.com/nodejs/node/pull/35772
Fixes: https://github.com/nodejs/node/issues/35695
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
2020-11-08 06:28:05 -08:00
Momtchil Momtchev
6abb7e5944
http2: move events to the JSStreamSocket
...
When using a JSStreamSocket, the
HTTP2Session constructor will replace
the socket object
http2 events should be attached to the
JSStreamSocket object because the http2
session handle lives there
Fixes: https://github.com/nodejs/node/issues/35695
PR-URL: https://github.com/nodejs/node/pull/35772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
2020-11-08 06:28:03 -08:00
Antoine du Hamel
133fdd4662
doc: fix crypto doc linter errors
...
PR-URL: https://github.com/nodejs/node/pull/36035
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-08 05:14:56 -08:00
Filip Skokan
1f69aa0641
doc,crypto: added sign/verify method changes about dsaEncoding
...
PR-URL: https://github.com/nodejs/node/pull/35480
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2020-11-08 11:18:08 +00:00
Ben Noordhuis
f06f3c0ea0
fs: remove unnecessary Function#bind() in fs/promises
...
PR-URL: https://github.com/nodejs/node/pull/35208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Masashi Hirano <shisama07@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-11-07 22:57:10 +01:00
Benjamin Gruenbaum
d3969003b5
events: fire handlers in correct oder
...
PR-URL: https://github.com/nodejs/node/pull/35931
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 18:12:30 +02:00
Benjamin Gruenbaum
1c99cdebbc
events: define abort on prototype
...
PR-URL: https://github.com/nodejs/node/pull/35931
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 18:12:28 +02:00
Benjamin Gruenbaum
b80d847608
events: support event handlers on prototypes
...
PR-URL: https://github.com/nodejs/node/pull/35931
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 18:12:27 +02:00
Benjamin Gruenbaum
8e87efb849
events: define event handler as enumerable
...
PR-URL: https://github.com/nodejs/node/pull/35931
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 18:12:24 +02:00
Bartosz Sosnowski
bfc9847e0f
win, build: fix build time on Windows
...
Sets MSBuild experimental switches to make it build in parallel project
files generated by gyp 0.5.0.
Fixes: https://github.com/nodejs/node/issues/35921
PR-URL: https://github.com/nodejs/node/pull/35932
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 07:08:43 -08:00
Myles Borins
115722b553
tools: don't print gold linker warning w/o flag
...
Currently warning is printed called even if the selection ordering flag
has not been passed.
Only print warning if `--limit-configure-section-file`
has been passed to configure.
Fixes: https://github.com/nodejs/node/issues/35872
PR-URL: https://github.com/nodejs/node/pull/35955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 13:17:55 +00:00
Leko
cef144421c
tools: add new ESLint rule: prefer-primordials
...
I added a new custom ESLint rule to fix these problems.
We have a lot of replaceable codes with primordials.
Accessing built-in objects is restricted by existing rule
(no-restricted-globals), but accessing property in the built-in objects
is not restricted right now. We manually review codes that can be
replaced by primordials, but there's a lot of code that actually needs
to be fixed. We have often made pull requests to replace the primordials
with.
Restrict accessing global built-in objects such as `Promise`.
Restrict calling static methods such as `Array.from` or `Symbol.for`.
Don't restrict prototype methods to prevent false-positive.
PR-URL: https://github.com/nodejs/node/pull/35448
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Ben Coe <bencoe@gmail.com >
2020-11-07 18:28:14 +08:00
Rich Trott
1d525f55bc
fs: remove unused assignment
...
PR-URL: https://github.com/nodejs/node/pull/35882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2020-11-06 21:59:29 -08:00
Richard Lau
85b42af439
benchmark: ignore build artifacts for napi addons
...
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.
PR-URL: https://github.com/nodejs/node/pull/35970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-07 02:57:54 +00:00
Antoine du Hamel
3c9f072522
tools,doc: enable ecmaVersion 2021 in acorn parser
...
PR-URL: https://github.com/nodejs/node/pull/35994
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-07 01:30:21 +00:00
Antoine du Hamel
0ad4f70db5
domain: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35885
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-06 22:22:20 +00:00
bcoe
8fa90358d7
module: refactor to use iterable-weak-map
...
Using an iterable WeakMap (a data-structure that uses WeakRef and
WeakMap), we are able to: stop relying on Module._cache to
serialize source maps; stop requiring an error object when calling
findSourceMap().
PR-URL: https://github.com/nodejs/node/pull/35915
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-11-06 12:47:23 -08:00
David Halls
1fd7d8e903
http2: fix error stream write followed by destroy
...
PR-URL: https://github.com/nodejs/node/pull/35951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-06 05:38:36 -08:00
raisinten
be1788613e
test: update old comment style test_util.cc
...
PR-URL: https://github.com/nodejs/node/pull/35884
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-06 13:37:16 +00:00
Rich Trott
ec400f8056
doc: revise v8.getHeapSnapshot()
...
* move entry above v8.getHeapSpaceStatistics() (where it belongs
alphabetically and is not out of place logically)
* split lengthy sentence into two sentences
PR-URL: https://github.com/nodejs/node/pull/35849
Reviewed-By: Michael Dawson <midawson@redhat.com >
2020-11-06 04:59:31 -08:00
Daijiro Wachi
456b4e133c
doc: update core-validate-commit link in guide
...
PR-URL: https://github.com/nodejs/node/pull/35938
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2020-11-06 10:51:12 +00:00
Benjamin Gruenbaum
c5477be8a1
events: support emit on nodeeventtarget
...
PR-URL: https://github.com/nodejs/node/pull/35851
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
2020-11-06 10:51:02 +00:00
Benjamin Gruenbaum
2a1273c6df
events: port some wpt tests
...
PR-URL: https://github.com/nodejs/node/pull/33621
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-11-06 11:08:33 +02:00
Benjamin Gruenbaum
b5a136cd67
fs: add support for AbortSignal in readFile
...
PR-URL: https://github.com/nodejs/node/pull/35911
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-11-06 11:06:19 +02:00
Antoine du Hamel
e6e6070364
errors: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35944
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Ben Coe <bencoe@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 22:55:34 +00:00
Antoine du Hamel
c723e4cb0b
lib: refactor to use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35875
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 23:15:41 +01:00
Antoine du Hamel
1f6ca18c3b
console: use more primordials
...
PR-URL: https://github.com/nodejs/node/pull/35734
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 23:11:56 +01:00
Tobias Nießen
c9e38489e7
crypto: fix comment in ByteSource
...
PR-URL: https://github.com/nodejs/node/pull/35972
Refs: https://github.com/nodejs/node/pull/35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Ricky Zhou <0x19951125@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-05 20:49:56 +01:00
Rich Trott
c575aec2a7
doc: update benchmark CI test indicator in README
...
As of c7627da837 , benchmark tests are run
in CI, but the README was not updated to indicate this.
PR-URL: https://github.com/nodejs/node/pull/35945
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-05 05:52:42 -08:00
Rich Trott
088dfce777
test: fix error in test/internet/test-dns.js
...
Refs: https://github.com/nodejs/node/pull/35466#issuecomment-721936009
PR-URL: https://github.com/nodejs/node/pull/35969
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2020-11-05 05:50:20 -08:00
Pooja D.P
2b985a2027
doc: add new wordings to the API description
...
PR-URL: https://github.com/nodejs/node/pull/35588
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-05 18:06:19 +05:30
krank2me
eb24573987
doc: option --prof documentation help added
...
PR-URL: https://github.com/nodejs/node/pull/34991
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2020-11-05 13:03:59 +05:30
Richard Lau
540b79605b
benchmark: remove modules that require intl
...
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.
Refs: https://github.com/nodejs/node/pull/35816
PR-URL: https://github.com/nodejs/node/pull/35968
Fixes: https://github.com/nodejs/node/issues/35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2020-11-05 07:23:47 +00:00
Gabriel Schulhof
c822ba7121
n-api: unlink reference during its destructor
...
Currently, a reference is being unlinked from the list of references
tracked by the environment when `v8impl::Reference::Delete` is called.
This causes a leak when deletion must be deferred because the finalizer
hasn't yet run, but the finalizer does not run because environment
teardown is in progress, and so no more gc runs will happen, and the
`FinalizeAll` run that happens during environment teardown does not
catch the reference because it's no longer in the list. The test below
will fail when running with ASAN:
```
./node ./test/node-api/test_worker_terminate_finalization/test.js
```
OTOH if, to address the above leak, we make a special case to not
unlink a reference during environment teardown, we run into a
situation where the reference gets deleted by
`v8impl::Reference::Delete` but does not get unlinked because it's
environment teardown time. This leaves a stale pointer in the linked
list which will result in a use-after-free in `FinalizeAll` during
environment teardown. The test below will fail if we make the above
change:
```
./node -e "require('./test/node-api/test_instance_data/build/Release/test_ref_then_set.node');"
```
Thus, we unlink a reference precisely when we destroy it – in its
destructor.
Refs: https://github.com/nodejs/node/issues/34731
Refs: https://github.com/nodejs/node/pull/34839
Refs: https://github.com/nodejs/node/issues/35620
Refs: https://github.com/nodejs/node/issues/35777
Fixes: https://github.com/nodejs/node/issues/35778
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com >
PR-URL: https://github.com/nodejs/node/pull/35933
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
2020-11-04 22:00:42 -08:00
Daniel Bevenius
1387f4b938
src: remove ERR prefix in crypto status enums
...
This commit removes the ERR prefix of the remaining status enums in
crypto so they are consistent with Commit
923f76d523 ("src: remove ERR prefix in
WebCryptoKeyExportStatus").
PR-URL: https://github.com/nodejs/node/pull/35867
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
2020-11-05 05:29:28 +01:00
Daijiro Wachi
3fab511a9e
doc: fix release-schedule link in backport guide
...
PR-URL: https://github.com/nodejs/node/pull/35920
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-05 03:17:13 +00:00
Bryan Field
d4d6dfdb94
doc: fix incorrect heading level
...
PR-URL: https://github.com/nodejs/node/pull/35965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-04 22:16:10 +00:00
Michaël Zasso
8caa6a9d8c
2020-11-04, Version 15.1.0 (Current)
...
Notable changes:
child_process:
* (SEMVER-MINOR) add ChildProcess 'spawn' event (Matthew Francis Brunetti) https://github.com/nodejs/node/pull/35369
dns:
* (SEMVER-MINOR) add setLocalAddress to Resolver (Josh Dague) https://github.com/nodejs/node/pull/34824
http:
* (SEMVER-MINOR) report request start and end with diagnostics_channel (Stephen Belanger) https://github.com/nodejs/node/pull/34895
http2:
* (SEMVER-MINOR) add updateSettings to both http2 servers (Vincent Boivin) https://github.com/nodejs/node/pull/35383
lib:
* (SEMVER-MINOR) create diagnostics_channel module (Stephen Belanger) https://github.com/nodejs/node/pull/34895
src:
* (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) https://github.com/nodejs/node/pull/33010
v8:
* (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) https://github.com/nodejs/node/pull/33807
* (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) https://github.com/nodejs/node/pull/33807
worker:
* (SEMVER-MINOR) add eventLoopUtilization() (Trevor Norris) https://github.com/nodejs/node/pull/35664
PR-URL: https://github.com/nodejs/node/pull/35948
2020-11-04 21:43:02 +01:00
Tobias Nießen
9aafda586e
crypto: pass empty passphrases to OpenSSL properly
...
Fixes: https://github.com/nodejs/node/issues/35898
PR-URL: https://github.com/nodejs/node/pull/35914
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-11-04 16:55:48 +01:00
Momtchil Momtchev
5a3f43b255
stream: fix regression on duplex end
...
Decide the return status of writeOrBuffer before
calling stream.write which can reset state.length
Add unit test for #35926
Refs: https://github.com/nodejs/node/issues/35926
PR-URL: https://github.com/nodejs/node/pull/35941
Fixes: https://github.com/nodejs/node/issues/35926
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-04 05:12:38 -08:00
Rich Trott
72ce5dcd52
test: add missing ref comments to parallel.status
...
PR-URL: https://github.com/nodejs/node/pull/35896
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-11-04 04:56:52 -08:00
Gerhard Stoebich
9dbde1d4fc
test: correct test-worker-eventlooputil
...
The active worker check compared the time from sending message till
response arrived from worker with the complete time the worker was
running till it responses to the spin request.
If sending back the message is slow for some reason the test fails.
Adapt the test to compare the time seen inside the worker with the
time read from main thread.
PR-URL: https://github.com/nodejs/node/pull/35891
Fixes: https://github.com/nodejs/node/issues/35844
Refs: https://github.com/nodejs/node/pull/35886
Refs: https://github.com/nodejs/node/pull/35664
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-04 07:19:47 +00:00
Myles Borins
58280ff24f
deps: upgrade npm to 7.0.8
...
PR-URL: https://github.com/nodejs/node/pull/35953
Reviewed-By: Ruy Adorno <ruyadorno@github.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2020-11-03 23:19:41 -05:00
Joyee Cheung
dbcadf005e
benchmark: make the benchmark tool work with Node 10
...
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
PR-URL: https://github.com/nodejs/node/pull/35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
2020-11-04 10:40:14 +08:00
Joyee Cheung
38c15691eb
benchmark: add startup benchmark for loading public modules
...
Adding a new benchmark for testing the performance of loading
available public modules.
PR-URL: https://github.com/nodejs/node/pull/35816
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-11-04 10:39:13 +08:00
James M Snell
fc8e3e2cdc
src: remove redundant OpenSSLBuffer
...
Replace the OpenSSLBuffer utility with ByteSource and
remove OpenSSLBuffer.
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/35663
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-11-03 16:23:37 -08:00
Benjamin Gruenbaum
ee749ba2c6
events: add a few tests
...
PR-URL: https://github.com/nodejs/node/pull/35806
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2020-11-03 17:16:55 +00:00
Rich Trott
1bc1f847ca
tools: bump remark-lint-preset-node to 2.0.0
...
Update remark@13.0.0, remark-lint-preset-node@2.0.0 and other
dependencies in the lint-md rollup.
PR-URL: https://github.com/nodejs/node/pull/35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-11-03 05:18:09 -08:00