BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
41,931 Commits 266 Branches 972 Tags
1be0ee76efda95fda00a30cce76d65b7025fab36
Commit Graph
41931 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael Gonzaga 1be0ee76ef benchmark: change assert() to assert.ok() 
PR-URL: https://github.com/nodejs/node/pull/54254
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:36:57 +02:00
Hüseyin Açacak e676d98435 module,win: fix long path resolve 
PR-URL: https://github.com/nodejs/node/pull/53294
Fixes: https://github.com/nodejs/node/issues/50753
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2024-08-14 08:36:57 +02:00
HEESEUNG 37960a67ae console: use validateOneOf for colorMode validation 
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.

PR-URL: https://github.com/nodejs/node/pull/54245
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:36:57 +02:00
Node.js GitHub Bot b0c768dae1 deps: update undici to 6.19.7 
PR-URL: https://github.com/nodejs/node/pull/54286
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-14 08:36:56 +02:00
Stephen Belanger b8970570b0 lib: improve async_context_frame structure 
PR-URL: https://github.com/nodejs/node/pull/54239
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2024-08-14 08:36:56 +02:00
Rafael Gonzaga a4768374f2 typings: add util.styleText type definition 
PR-URL: https://github.com/nodejs/node/pull/54252
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-14 08:15:29 +02:00
Samuli Asmala 971b9f31f5 doc: update buffer.constants.MAX_LENGTH size 
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been
increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.

PR-URL: https://github.com/nodejs/node/pull/54207
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:15:29 +02:00
Marco Ippolito 1ba2000703 module: refactor ts parser loading 
PR-URL: https://github.com/nodejs/node/pull/54243
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-14 08:15:29 +02:00
Isaac-yz-Liu 2f68a74702 test: fix timeout not being cleared 
PR-URL: https://github.com/nodejs/node/pull/54242
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2024-08-14 08:15:28 +02:00
Antoine du Hamel f5cfa4454e test: refactor test-runner-module-mocking 
PR-URL: https://github.com/nodejs/node/pull/54233
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2024-08-14 08:15:28 +02:00
Jason Zhang 3106149965 doc: warn for windows build bug 
Refs: https://github.com/nodejs/build/issues/3739
PR-URL: https://github.com/nodejs/node/pull/54217
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-14 08:15:28 +02:00
Pietro Marchini 7fad771bbf test_runner: fix erroneous diagnostic warning when only: false 
Co-author: rstagi <r.stagi96@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-14 08:15:28 +02:00
Chengzhong Wu a394219fa5 src: skip inspector wait in internal workers 
Internal workers are essential to load user scripts and bootstrapped
with internal entrypoints. They should not be waiting for inspectors
even when `--inspect-brk` and `--inspect-wait` were specified, and avoid
blocking main thread to bootstrap.

IsolateData can be created with a specified PerIsolateOptions instead of
creating a copy from the per_process namespace. This also avoids
creating a copy bypassing the parent env's modified options, like
creating a worker thread from a worker thread.

PR-URL: https://github.com/nodejs/node/pull/54219
Fixes: https://github.com/nodejs/node/issues/53681
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-08-14 08:15:27 +02:00
Michael Dawson b93c6d9f38 tools: make undici updater build wasm from src 
- modify updater to include all files required to rebuild
  wasm from what's stored in the deps/undici directory
- modify updater to build wasm from source while updating

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/54128
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2024-08-14 08:15:27 +02:00
Node.js GitHub Bot 581c155cf8 meta: move one or more collaborators to emeritus 
PR-URL: https://github.com/nodejs/node/pull/54210
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-08-14 08:15:27 +02:00
Deokjin Kim 55f8ac3e89 doc: make some parameters optional in tracingChannel.traceCallback 
Plus, add missing `position` parameter to CJS example.

PR-URL: https://github.com/nodejs/node/pull/54068
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-14 08:15:27 +02:00
Luigi Pinca b85b13b418 test: use assert.{s,deepS}trictEqual() 
Use `asset.strictEqual()` and `asset.deepStrictEqual()` in
`test/parallel/test-tls-set-sigalgs.js`.

PR-URL: https://github.com/nodejs/node/pull/54208
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:15:00 +02:00
Jonas 112228c15a fs: remove unnecessary option argument validation 
PR-URL: https://github.com/nodejs/node/pull/53958
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:15:00 +02:00
Fedor Indutny 783322fa16 lib: fix unhandled errors in webstream adapters 
WebStream's Readable controller does not tolerate `.close()` being
called after an `error`. However, when wrapping a Node's Readable stream
it is possible that the sequence of events leads to `finished()`'s
callback being invoked after such `error`.

In order to handle this, in this change we call the `finished()` handler
earlier when controller is canceled, and always handle this as an error
case.

Fix: https://github.com/nodejs/node/issues/54205
PR-URL: https://github.com/nodejs/node/pull/54206
Fixes: https://github.com/nodejs/node/issues/54205
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-08-14 08:15:00 +02:00
Alfredo González e3e2f22cab doc: add esm examples to node:dns 
PR-URL: https://github.com/nodejs/node/pull/54172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-14 08:15:00 +02:00
Aviv Keller 3f0d7344e3 meta: add module label for the lib/internal/modules folder 
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:59 +02:00
Aviv Keller 4dd229f546 benchmark: support --help in CLI 
PR-URL: https://github.com/nodejs/node/pull/53358
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:59 +02:00
Node.js GitHub Bot ef9a950cb9 deps: update acorn to 8.12.1 
PR-URL: https://github.com/nodejs/node/pull/53465
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-08-14 08:14:59 +02:00
sungpaks 6bcbfcd7bc test: add subtests to test-node-run 
Added two subtests to test-node-run. First one is about unparsable
package.json file, and the second one is about there is no "script"
fields in package.json

PR-URL: https://github.com/nodejs/node/pull/54204
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-14 08:14:59 +02:00
Yelim Koo a5a320cd5b benchmark: remove force option as force defaults to true 
PR-URL: https://github.com/nodejs/node/pull/54203
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-14 08:14:58 +02:00
Antoine du Hamel 3835131559 tools: add workflow to ensure README lists are in sync with gh teams 
PR-URL: https://github.com/nodejs/node/pull/53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:14:58 +02:00
Chengzhong Wu 0429b1eb9d doc: add KevinEady as a triager 
PR-URL: https://github.com/nodejs/node/pull/54179
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
 2024-08-14 08:14:58 +02:00
Alfredo González 4bfa7d8e54 doc: add esm examples to node:console 
PR-URL: https://github.com/nodejs/node/pull/54108
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-14 08:14:58 +02:00
Hüseyin Açacak 8a770cf5c9 path: fix relative on Windows 
PR-URL: https://github.com/nodejs/node/pull/53991
Fixes: https://github.com/nodejs/node/issues/27534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-14 08:14:58 +02:00
Sung Ye In dc465736fb test_runner: make mock_loader not confuse CJS and ESM resolution 
PR-URL: https://github.com/nodejs/node/pull/53846
Fixes: https://github.com/nodejs/node/issues/53807
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-14 08:14:57 +02:00
Sadzurami 2f5309fc22 doc: fix sea assets example 
PR-URL: https://github.com/nodejs/node/pull/54192
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:57 +02:00
Stefan Stojanovic dafe97548f test: set test-structuredclone-jstransferable non-flaky 
Fixes: https://github.com/nodejs/node/issues/50260
PR-URL: https://github.com/nodejs/node/pull/54115
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2024-08-14 08:14:57 +02:00
Aviv Keller 88aef5a39d doc: add links to security steward companies 
PR-URL: https://github.com/nodejs/node/pull/52981
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-08-14 08:14:57 +02:00
devstone be61793db5 test: update wpt test for streams 
PR-URL: https://github.com/nodejs/node/pull/54129
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-14 08:14:56 +02:00
Aviv Keller 350e699443 build: support lint-js-fix in vcbuild.bat 
PR-URL: https://github.com/nodejs/node/pull/53695
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2024-08-14 08:14:56 +02:00
Node.js GitHub Bot 1597a1139a deps: update undici to 6.19.5 
PR-URL: https://github.com/nodejs/node/pull/54076
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-14 08:14:56 +02:00
Node.js GitHub Bot 103e4db3e0 deps: update simdutf to 5.3.1 
PR-URL: https://github.com/nodejs/node/pull/54196
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-14 08:14:56 +02:00
dependabot[bot] 0157ec6bbd meta: bump actions/upload-artifact from 4.3.3 to 4.3.4 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/65462800fd760344b1a7b4382951275a0abb4808...0b2256b8c012f0828dc542b3febcab082c67f72b)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54166
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:55 +02:00
dependabot[bot] 7fa95d2360 meta: bump actions/download-artifact from 4.1.7 to 4.1.8 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/65a9edc5881444af0b9093a5e628f2fe47ea3b2e...fa0a91b85d4f404e444e00e005971372dc801d16)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54167
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:55 +02:00
dependabot[bot] acc5b9a0c5 meta: bump actions/setup-python from 5.1.0 to 5.1.1 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/82c7e631bb3cdc910f68e0081d67478d79c6982d...39cd14951b08e74b54015e9e001cdefcf80e669f)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54165
Refs: https://github.com/actions/setup-python/commit/39cd14951b08e74b54015e9e001cdefcf80e669f
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-14 08:14:55 +02:00
dependabot[bot] dede30a8d0 meta: bump step-security/harden-runner from 2.8.1 to 2.9.0 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.8.1 to 2.9.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](https://github.com/step-security/harden-runner/compare/17d0e2bd7d51742c71671bd19fa12bdc9d40a3d6...0d381219ddf674d61a7572ddd19d7941e271515c)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54169
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-14 08:14:55 +02:00
dependabot[bot] b733854eac meta: bump actions/setup-node from 4.0.2 to 4.0.3 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/60edb5dd545a775178f52524783378180af0d1f8...1e60f620b9541d16bece96c5465dc8ee9832be0b)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54170
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:55 +02:00
dependabot[bot] 6a9f168cc6 meta: bump github/codeql-action from 3.25.11 to 3.25.15 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.15.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/b611370bb5703a7efb587f9d136a52ea24c5c38c...afb54ba388a7dca6ecae48f608c4ff05ff4cc77a)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54168
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-14 08:14:54 +02:00
dependabot[bot] 9bbd85e4fe meta: bump ossf/scorecard-action from 2.3.3 to 2.4.0 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](https://github.com/ossf/scorecard-action/compare/dc50aa9510b46c811795eb24b2f1ba02a914e534...62b2cac7ed8198b15735ed49ab1e5cf35480ba46)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54171
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-14 08:14:54 +02:00
sendoru 5175903c23 doc: move onread option from socket.connect() to new net.socket() 
Fixes: https://github.com/nodejs/node/issues/53792
PR-URL: https://github.com/nodejs/node/pull/54194
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
 2024-08-14 08:14:54 +02:00
James M Snell 8daeccfe92 src: shift more crypto impl details to ncrypto 
PR-URL: https://github.com/nodejs/node/pull/54028
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:14:54 +02:00
Joyee Cheung 31adeea855 sea: don't set code cache flags when snapshot is used 
When both useCodeCache and useSnapshot are set, we generate the
snapshot and skip the generation of the code cache since the
snapshot already includes the code cache. But we previously still
persist the code cache setting in the flags that got serialized
into the SEA, so the resulting executable would still try to read
the code cache even if it's not added to the SEA, leading to a flaky
crash caused by OOB on some platforms.

This patch fixes the crash by ignoring the code cache setting when
generating the flag if both snapshot and code cache is configured.

PR-URL: https://github.com/nodejs/node/pull/54120
Fixes: https://github.com/nodejs/node/issues/50740
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-08-14 08:14:53 +02:00
Aviv Keller 7c305a4900 doc, meta: replace command with link to keys 
PR-URL: https://github.com/nodejs/node/pull/53745
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-08-14 08:14:53 +02:00
Richard Lau 144637e845 doc: move release key for Myles Borins 
Myles has stepped down as a releaser. Move his key in `README.md`
to the "Other keys used to sign some previous releases" section.

PR-URL: https://github.com/nodejs/node/pull/54059
Refs: https://github.com/nodejs/Release/pull/1024
Refs: https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#offboarding-releasers
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-08-14 08:14:53 +02:00
James M Snell e619133ac9 src: move spkac methods to ncrypto 
PR-URL: https://github.com/nodejs/node/pull/53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:14:53 +02:00