Commit Graph
42619 Commits
Author SHA1 Message Date
Mert Can Altin 21ec855feb os: improve path check with direct index access
PR-URL: https://github.com/nodejs/node/pull/55434
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
2024-11-27 11:03:29 -05:00
James M Snell 3477b6b4a5 src: move more key related stuff to ncrypto
PR-URL: https://github.com/nodejs/node/pull/55368
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-11-27 11:03:29 -05:00
Antoine du Hamel 456b02351b tools: lint README lists more strictly
PR-URL: https://github.com/nodejs/node/pull/55625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-11-27 11:03:28 -05:00
Marco Ippolito 0a7f301a36 http: add diagnostic channel http.server.response.created
PR-URL: https://github.com/nodejs/node/pull/55622
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
2024-11-27 11:03:28 -05:00
Filip Skokan f1e0e0ba55 doc: remove mention of ECDH-ES in crypto.diffieHellman
PR-URL: https://github.com/nodejs/node/pull/55611
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2024-11-27 11:03:28 -05:00
Filip Skokan 38c047e38f src: refactor ECDHBitsJob signature
PR-URL: https://github.com/nodejs/node/pull/55610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2024-11-27 11:03:28 -05:00
Michaël Zasso 8c670496da build: use rclone instead of aws CLI
Use rclone to upload assets to Cloudflare as it is more reliable.

Refs: https://github.com/nodejs/build/issues/3508
PR-URL: https://github.com/nodejs/node/pull/55617
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-11-27 11:03:28 -05:00
Aviv Keller 827e2065bd build: stop pre-compiling lint-md
PR-URL: https://github.com/nodejs/node/pull/55266
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-11-27 11:03:28 -05:00
Aviv Keller 4cca54b161 meta: show PR/issue title on review-wanted
PR-URL: https://github.com/nodejs/node/pull/55606
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1730308054959239?thread_ts=1730296053.898089&cid=C019Y2T6STH
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-11-27 11:03:28 -05:00
RafaelGSS 4caaeb47b2 benchmark: add nodeTiming.uvmetricsinfo bench
PR-URL: https://github.com/nodejs/node/pull/55614
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2024-11-27 11:03:28 -05:00
RafaelGSS e14fb2defb src,lib: optimize nodeTiming.uvMetricsInfo
PR-URL: https://github.com/nodejs/node/pull/55614
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2024-11-27 11:03:28 -05:00
Node.js GitHub Bot d1cb7af95c deps: update amaro to 0.2.0
PR-URL: https://github.com/nodejs/node/pull/55601
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-11-27 11:03:28 -05:00
Gireesh Punathil 1d60b7ec97 doc: improve c++ embedder API doc
normalise the headers, fixup bullet points and
expand `node::IsolateData` scope for clarity.

PR-URL: https://github.com/nodejs/node/pull/55597
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:27 -05:00
theanarkh acbb62902a src: fix dns crash when failed to create NodeAresTask
PR-URL: https://github.com/nodejs/node/pull/55521
Fixes: https://github.com/nodejs/node/issues/52439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:27 -05:00
Orgad Shaneh d2430ee363 http2: fix client async storage persistence
Create and store an AsyncResource for each stream, following a similar
approach as used in HttpAgent.

Fixes: https://github.com/nodejs/node/issues/55376
PR-URL: https://github.com/nodejs/node/pull/55460
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2024-11-27 11:03:27 -05:00
Marco Ippolito 98bfc7dce5 http: add diagnostic channel http.client.request.created
PR-URL: https://github.com/nodejs/node/pull/55586
Fixes: https://github.com/nodejs/node/issues/55352
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
2024-11-27 11:03:27 -05:00
Tobias Nießen 4e5878536a sqlite: add readOnly option
Allow opening existing SQLite databases with SQLITE_OPEN_READONLY set.

PR-URL: https://github.com/nodejs/node/pull/55567
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-11-27 11:03:27 -05:00
Charles Kerr 547cab9433 src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT
Small efficiency improvement over NewFromUtf8(): the literal's
length is known at compile time, so V8 doesn't have to call
strlen() or ToLocalChecked().

PR-URL: https://github.com/nodejs/node/pull/55581
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-11-27 11:03:27 -05:00
Aviv Keller bf68733e7f dns: stop using deprecated ares_query
PR-URL: https://github.com/nodejs/node/pull/55430
Refs: https://github.com/nodejs/node/issues/52464
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2024-11-27 11:03:27 -05:00
Aviv Keller bbf51d7000 doc: capitalize "MIT License"
PR-URL: https://github.com/nodejs/node/pull/55575
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-11-27 11:03:27 -05:00
Julian Gassner a80c166733 test: split up test-runner-mock-timers test
PR-URL: https://github.com/nodejs/node/pull/55506
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
2024-11-27 11:03:26 -05:00
Michael Cho c3ca978d9c build: fix building with system icu 76
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer
add `icu-uc` when linking to shared libraries. This results in undefined
symbols/references when trying to build with system ICU 76.

[^1]: unicode-org/icu@199bc82

PR-URL: https://github.com/nodejs/node/pull/55563
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:26 -05:00
Luigi Pinca 8c2fc11f7c test: remove unneeded listeners
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: https://github.com/nodejs/node/pull/55486
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-11-27 11:03:26 -05:00
Joyee Cheung 91fdec3a52 module: fix error thrown from require(esm) hitting TLA repeatedly
This tracks the asynchronicity in the ModuleWraps when they turn out to
contain TLA after instantiation, and throw the right error
(ERR_REQUIRE_ASYNC_MODULE) when it's required again. It removes
the freezing of ModuleWraps since it's not meaningful to freeze
this when the rest of the module loader is mutable, and we
can record the asynchronicity in the ModuleWrap right after
compilation after we get a V8 upgrade that contains
v8::Module::HasTopLevelAwait() instead of searching through
the module graph repeatedly which can be slow.

PR-URL: https://github.com/nodejs/node/pull/55520
Fixes: https://github.com/nodejs/node/issues/55516
Refs: https://github.com/nodejs/node/issues/52697
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
2024-11-27 11:03:26 -05:00
Yagiz Nizipli 231fe7b953 src: do not run IsWindowsBatchFile on non-windows
PR-URL: https://github.com/nodejs/node/pull/55560
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
2024-11-27 11:03:26 -05:00
Node.js GitHub Bot 655e5600cb deps: update nghttp2 to 1.64.0
PR-URL: https://github.com/nodejs/node/pull/55559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-11-27 11:03:26 -05:00
Node.js GitHub Bot 992450c469 deps: update acorn to 8.13.0
PR-URL: https://github.com/nodejs/node/pull/55558
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-11-27 11:03:26 -05:00
Shelley Vohr 23e3287bbe build: fix GN arg used in generate_config_gypi.py
PR-URL: https://github.com/nodejs/node/pull/55530
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:26 -05:00
Marco Ippolito 0e69f6d123 doc: add suggested tsconfig for type stripping
PR-URL: https://github.com/nodejs/node/pull/55534
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2024-11-27 11:03:26 -05:00
Shelley Vohr 2b561abb0d build: fix GN build for sqlite and nghttp2
PR-URL: https://github.com/nodejs/node/pull/55529
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:26 -05:00
Alfredo González 67beb37f50 doc: add esm examples to node:string_decoder
PR-URL: https://github.com/nodejs/node/pull/55507
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-11-27 11:03:25 -05:00
Livia Medeiros 1c5872dbde test: avoid apply() calls with large amount of elements
PR-URL: https://github.com/nodejs/node/pull/55501
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2024-11-27 11:03:25 -05:00
Node.js GitHub Bot abd2bd4f64 deps: update undici to 6.20.1
PR-URL: https://github.com/nodejs/node/pull/55503
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:25 -05:00
Filip Skokan 445d117b67 test,crypto: update WebCryptoAPI WPT
PR-URL: https://github.com/nodejs/node/pull/55512
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 11:03:25 -05:00
Tobias Nießen 8c35ad12de sqlite: refactor open options
Move options that are only relevant for opening the database into a
self-contained class.

PR-URL: https://github.com/nodejs/node/pull/55442
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-11-27 11:03:25 -05:00
Juan José 2194eb4909 test: increase test coverage for http.OutgoingMessage.appendHeader()
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/55467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-11-27 11:03:25 -05:00
Jason Zhang acc6806900 doc: add jazelly to collaborators
PR-URL: https://github.com/nodejs/node/pull/55531
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-11-27 11:03:25 -05:00
Shelley Vohr cd0d748ede test,crypto: make crypto tests work with BoringSSL
PR-URL: https://github.com/nodejs/node/pull/55491
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2024-11-27 11:03:25 -05:00
adriancuadrado a6b3ed54ae doc: changed the command used to verify SHASUMS256
PR-URL: https://github.com/nodejs/node/pull/55420
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-11-27 11:03:24 -05:00
Cheng 7008f29d79 build: fix GN build for cares/uv deps
PR-URL: https://github.com/nodejs/node/pull/55477
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-11-27 02:25:39 -05:00
Joyee Cheung 0ad7ca4f1d doc: move dual package shipping docs to separate repo
Refs: https://github.com/nodejs/admin/issues/917
Refs: https://github.com/nodejs/package-examples/pull/1
Refs: https://github.com/nodejs/node/pull/54648
PR-URL: https://github.com/nodejs/node/pull/55444
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-11-27 02:25:39 -05:00
Marvin ROGER 8f59c41d52 stream: propagate AbortSignal reason
PR-URL: https://github.com/nodejs/node/pull/55473
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-11-27 02:25:38 -05:00
Antoine du Hamel 15dd43dd6e esm: add a fallback when importer in not a file
PR-URL: https://github.com/nodejs/node/pull/55471
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-11-27 02:25:38 -05:00
Shelley Vohr ad7e81379a test: make test-node-output-v8-warning more flexible
PR-URL: https://github.com/nodejs/node/pull/55401
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-11-27 02:25:38 -05:00
Node.js GitHub Bot 83a5983c7d tools: update lint-md-dependencies
- @rollup/plugin-commonjs@28.0.1
- @rollup/plugin-node-resolve@15.3.0
- remark-preset-lint-node@5.1.2
- rollup@4.24.0

PR-URL: https://github.com/nodejs/node/pull/55470
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-11-27 02:25:38 -05:00
Node.js GitHub Bot 72b4a8df6a tools: update gyp-next to 0.18.3
PR-URL: https://github.com/nodejs/node/pull/55464
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-11-27 02:25:38 -05:00
Aviv Keller d695bd4c4f fs: pass correct path to DirentFromStats during glob
PR-URL: https://github.com/nodejs/node/pull/55071
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2024-11-27 02:25:38 -05:00
Wuli Zuo c8e7f767b7 typings: add missing type of ArrayBufferPrototypeGetByteLength
PR-URL: https://github.com/nodejs/node/pull/55439
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 02:25:38 -05:00
Antoine du Hamel 6aeeaa719b test: fix addons and node-api test assumptions
PR-URL: https://github.com/nodejs/node/pull/55441
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 02:25:38 -05:00
devstone 73ab14fd8f test: update wpt test for webmessaging/broadcastchannel
PR-URL: https://github.com/nodejs/node/pull/55205
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-11-27 02:25:38 -05:00