BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
42,619 Commits 266 Branches 972 Tags
21ec855feb567f526ef09dadce16cdc4e88dae14
Commit Graph
2566 Commits
Author SHA1 Message Date
Antoine du Hamel 456b02351b tools: lint README lists more strictly 
PR-URL: https://github.com/nodejs/node/pull/55625
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-11-27 11:03:28 -05:00
Michaël Zasso 8c670496da build: use rclone instead of aws CLI 
Use rclone to upload assets to Cloudflare as it is more reliable.

Refs: https://github.com/nodejs/build/issues/3508
PR-URL: https://github.com/nodejs/node/pull/55617
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-11-27 11:03:28 -05:00
Aviv Keller 827e2065bd build: stop pre-compiling lint-md 
PR-URL: https://github.com/nodejs/node/pull/55266
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-11-27 11:03:28 -05:00
Shelley Vohr 23e3287bbe build: fix GN arg used in generate_config_gypi.py 
PR-URL: https://github.com/nodejs/node/pull/55530
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-11-27 11:03:26 -05:00
Node.js GitHub Bot 83a5983c7d tools: update lint-md-dependencies 
- @rollup/plugin-commonjs@28.0.1
- @rollup/plugin-node-resolve@15.3.0
- remark-preset-lint-node@5.1.2
- rollup@4.24.0

PR-URL: https://github.com/nodejs/node/pull/55470
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-11-27 02:25:38 -05:00
Node.js GitHub Bot 72b4a8df6a tools: update gyp-next to 0.18.3 
PR-URL: https://github.com/nodejs/node/pull/55464
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-11-27 02:25:38 -05:00
Cloorc 6ee94a394f build: fix uninstall script for AIX 7.1 
Signed-off-by: Cloorc <13597105+cloorc@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/55438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-11-27 01:42:45 -05:00
Richard Lau 6b6e6a5590 tools: add script to synch c-ares source lists 
Add step to the updater script for c-ares to synchronize the list
of sources in our gyp file with the lists in c-ares' Makefiles.

PR-URL: https://github.com/nodejs/node/pull/55445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-11-27 01:42:44 -05:00
Nathan Baulch a6c444291b tools: fix typos 
PR-URL: https://github.com/nodejs/node/pull/55061
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-11-27 01:23:23 -05:00
Stefan Stojanovic a21be0294d build,win: enable pch for clang-cl 
Fixes: https://github.com/nodejs/node/issues/55208
PR-URL: https://github.com/nodejs/node/pull/55249
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-11-27 01:15:01 -05:00
Antoine du Hamel d5e915ba5d tools: add polyfilled option to prefer-primordials rule 
PR-URL: https://github.com/nodejs/node/pull/55318
Backport-PR-URL: https://github.com/nodejs/node/pull/55421
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2024-11-27 00:48:28 -05:00
Aviv Keller d51e5a8667 tools: enforce errors to not be documented in legacy section 
PR-URL: https://github.com/nodejs/node/pull/55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-10-09 22:59:04 +02:00
Node.js GitHub Bot 6a7d201b80 tools: update gyp-next to 0.18.2 
PR-URL: https://github.com/nodejs/node/pull/55160
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2024-10-09 22:57:22 +02:00
dependabot[bot] c988e7e2e5 tools: bump the eslint group in /tools/eslint with 4 updates 
Bumps the eslint group in /tools/eslint with 4 updates: [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js), [eslint](https://github.com/eslint/eslint), [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) and [globals](https://github.com/sindresorhus/globals).

Updates `@stylistic/eslint-plugin-js` from 2.7.2 to 2.8.0
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
- [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v2.8.0/packages/eslint-plugin-js)

Updates `eslint` from 9.9.1 to 9.11.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v9.9.1...v9.11.1)

Updates `eslint-plugin-jsdoc` from 50.2.2 to 50.3.1
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v50.2.2...v50.3.1)

Updates `globals` from 15.9.0 to 15.10.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](https://github.com/sindresorhus/globals/compare/v15.9.0...v15.10.0)

---
updated-dependencies:
- dependency-name: "@stylistic/eslint-plugin-js"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: globals
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/55227
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-10-04 19:20:24 +02:00
Aviv Keller 60a35eddb0 tools: make choco install script more readable 
PR-URL: https://github.com/nodejs/node/pull/54002
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
 2024-10-04 19:20:14 +02:00
dependabot[bot] b7b1fa6dd3 tools: bump Rollup from 4.18.1 to 4.22.4 for lint-md 
Bumps [rollup](https://github.com/rollup/rollup) from 4.18.1 to 4.22.4.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v4.18.1...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/55093
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-10-04 10:20:29 +02:00
Aviv Keller 566179c9ec lib, tools: remove duplicate requires 
PR-URL: https://github.com/nodejs/node/pull/54987
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-10-04 10:20:25 +02:00
Michaël Zasso 3304bf387f tools: unlock versions of irrelevant DB deps 
This essentially reverts e0e0b1a70e.

We don't bundle ESLint anymore, so the change is no longer needed.

PR-URL: https://github.com/nodejs/node/pull/55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 10:20:24 +02:00
Aviv Keller d803355d92 lib: prefer optional chaining 
PR-URL: https://github.com/nodejs/node/pull/55045
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2024-10-04 10:20:24 +02:00
Aviv Keller f3ca9c669b build: update ruff and add lint-py-fix 
PR-URL: https://github.com/nodejs/node/pull/54410
Reviewed-By: Christian Clauss <cclauss@me.com>
 2024-10-04 10:20:23 +02:00
Aviv Keller 65c376a819 tools: remove redudant code from eslint require rule 
PR-URL: https://github.com/nodejs/node/pull/54892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-10-04 10:20:22 +02:00
Aviv Keller 295f684b69 tools: update error message for ICU in license-builder 
PR-URL: https://github.com/nodejs/node/pull/54742
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-10-04 10:20:14 +02:00
Yagiz Nizipli ce4b6e403d tools: refactor js2c.cc to use c++20 
PR-URL: https://github.com/nodejs/node/pull/54849
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
 2024-10-04 10:20:10 +02:00
dependabot[bot] 31f0ef6ea3 tools: bump the eslint group in /tools/eslint with 7 updates 
Bumps the eslint group in /tools/eslint with 7 updates:

| Package | From | To |
| --- | --- | --- |
| `@babel/core` | `7.24.9` | `7.25.2` |
| `@babel/eslint-parser` | `7.25.0` | `7.25.1` |
| `@babel/plugin-syntax-import-attributes` | `7.24.7` | `7.25.6` |
| `@stylistic/eslint-plugin-js` | `2.4.0` | `2.7.2` |
| `eslint` | `9.8.0` | `9.9.1` |
| `eslint-plugin-jsdoc` | `48.8.3` | `50.2.2` |
| `globals` | `15.8.0` | `15.9.0` |

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54821
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-10-04 10:20:09 +02:00
Chengzhong Wu c8b7a645ae Revert "build: upgrade clang-format to v18" 
This reverts commit c3e1c31baa.

PR-URL: https://github.com/nodejs/node/pull/54994
Refs: https://github.com/nodejs/node/pull/53957
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-10-04 10:20:08 +02:00
Aviv Keller e1f36d0da8 meta: remove unneeded ignore rules from ruff 
PR-URL: https://github.com/nodejs/node/pull/54360
Reviewed-By: Christian Clauss <cclauss@me.com>
 2024-10-04 10:20:07 +02:00
Node.js GitHub Bot 676d0a09a0 tools: update github_reporter to 1.7.1 
PR-URL: https://github.com/nodejs/node/pull/54951
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-10-04 10:20:03 +02:00
Aviv Keller 9a075279ec build: upgrade clang-format to v18 
PR-URL: https://github.com/nodejs/node/pull/53957
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-17 11:18:27 -03:00
Stefan Stojanovic e38e305a35 build,win: enable clang-cl compilation 
This uses the backported ICU fix needed for compiling with ClangCL.

Refs: https://github.com/nodejs/node/pull/54502
Fixes: https://github.com/nodejs/node/issues/34201
PR-URL: https://github.com/nodejs/node/pull/54655
Refs: https://github.com/nodejs/node/issues/52809
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
 2024-09-16 10:39:37 -03:00
Rafael Gonzaga 608a611132 tools: add readability/fn_size to filter 
PR-URL: https://github.com/nodejs/node/pull/54744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-09-12 11:06:47 +02:00
Aviv Keller 6200cf4fb6 build: don't store eslint locally 
PR-URL: https://github.com/nodejs/node/pull/54231
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-09-12 11:06:43 +02:00
Antoine du Hamel 93fab49099 tools: add util scripts to land and rebase PRs 
PR-URL: https://github.com/nodejs/node/pull/54656
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2024-09-12 11:06:43 +02:00
Rafael Gonzaga d6df542ff8 tools: remove readability/fn_size rule 
PR-URL: https://github.com/nodejs/node/pull/54663
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-09-12 11:06:38 +02:00
Joyee Cheung db80eac496 vm: introduce vanilla contexts via vm.constants.DONT_CONTEXTIFY 
This implements a flavor of vm.createContext() and friends
that creates a context without contextifying its global object.
This is suitable when users want to freeze the context (impossible
when the global is contextified i.e. has interceptors installed)
or speed up the global access if they don't need the interceptor
behavior.

```js
const vm = require('node:vm');

const context = vm.createContext(vm.constants.DONT_CONTEXTIFY);

// In contexts with contextified global objects, this is false.
// In vanilla contexts this is true.
console.log(vm.runInContext('globalThis', context) === context);

// In contexts with contextified global objects, this would throw,
// but in vanilla contexts freezing the global object works.
vm.runInContext('Object.freeze(globalThis);', context);

// In contexts with contextified global objects, freezing throws
// and won't be effective. In vanilla contexts, freezing works
// and prevents scripts from accidentally leaking globals.
try {
  vm.runInContext('globalThis.foo = 1; foo;', context);
} catch(e) {
  console.log(e); // Uncaught ReferenceError: foo is not defined
}

console.log(context.Array);  // [Function: Array]
```

PR-URL: https://github.com/nodejs/node/pull/54394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2024-08-30 15:52:16 -03:00
Stefan Stojanovic 33a6b3c7a9 deps: backport ICU-22787 to fix ClangCL on Windows 
- Floating patch for ICU 75.x

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-22787
Backport of: https://github.com/unicode-org/icu/pull/3023

PR-URL: https://github.com/nodejs/node/pull/54502
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-08-30 15:52:14 -03:00
Aviv Keller 38798140c4 tools: remove unused python files 
PR-URL: https://github.com/nodejs/node/pull/53928
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-08-30 15:52:13 -03:00
Marco Ippolito da6c61def8 tools: add swc license 
PR-URL: https://github.com/nodejs/node/pull/54462
Fixes: https://github.com/nodejs/amaro/issues/49
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2024-08-30 15:52:11 -03:00
Michaël Zasso c640a2f24c build: always disable strict aliasing 
V8 relies on it.

PR-URL: https://github.com/nodejs/node/pull/54339
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-21 17:49:20 -03:00
Aviv Keller df428adb6c tools: remove header from c-ares license 
PR-URL: https://github.com/nodejs/node/pull/54335
Refs: https://github.com/c-ares/c-ares/commit/595cf2133488d2e02c6389577a1b511971dba1ba
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2024-08-19 11:34:48 -03:00
Marco Ippolito b659fc0f2b tools: add find pyenv path on windows 
PR-URL: https://github.com/nodejs/node/pull/54314
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2024-08-14 08:37:04 +02:00
Michael Dawson b93c6d9f38 tools: make undici updater build wasm from src 
- modify updater to include all files required to rebuild
  wasm from what's stored in the deps/undici directory
- modify updater to build wasm from source while updating

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/54128
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2024-08-14 08:15:27 +02:00
Antoine du Hamel 3835131559 tools: add workflow to ensure README lists are in sync with gh teams 
PR-URL: https://github.com/nodejs/node/pull/53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-14 08:14:58 +02:00
Node.js GitHub Bot 8b35f0e601 tools: update eslint to 9.8.0 
PR-URL: https://github.com/nodejs/node/pull/54073
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-14 08:14:45 +02:00
Chengzhong Wu f755d31bec node-api: add property keys benchmark 
PR-URL: https://github.com/nodejs/node/pull/54012
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-08-05 11:15:46 -03:00
Marco Ippolito 92439fc160 module: add --experimental-strip-types 
PR-URL: https://github.com/nodejs/node/pull/53725
Refs: https://github.com/nodejs/loaders/issues/217
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
 2024-08-05 11:15:43 -03:00
Chengzhong Wu bfbed0afd5 build: fix conflict gyp configs 
Gyp generated build files can be built in either Release/Debug mode.

- make: single directory, two configurations by cli:
  `make -C out BUILDTYPE=Release` and `make -C out BUILDTYPE=Debug`.
- msbuild: single directory, two configurations by cli:
  `msbuild node.sln /p:Configuration=Release` and
  `msbuild node.sln /p:Configuration=Debug`.
- ninja: two directories in `out/`, build with
  `ninja -C out/Release` or `ninja -C out/Debug`.

Variables that changes with either Release or Debug configuration
should be defined in a configuration level, instead of the root level.
This fixes generating invalid build files.

Additionally, `v8_gypfiles/toolchain.gypi` duplicates defines in
`v8_gypfiles/features.gypi`. Remove the duplications in
`toolchains.gypi`

PR-URL: https://github.com/nodejs/node/pull/53605
Fixes: https://github.com/nodejs/node/issues/53446
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-05 11:15:42 -03:00
Aviv Keller 20a8c96c41 meta: remove license for hljs 
PR-URL: https://github.com/nodejs/node/pull/53970
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-08-05 11:15:42 -03:00
Richard Lau 2a62d6ca57 build, tools: drop leading / from r2dir 
The script is commented as removing `/home/dist/` part but the `cut`
command is off by one and end up including the `/` character (so that
the resulting string starts with `/`). When this is substituted into
`s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with
`//` (one from the template and one from the `r2dir`) which appears
to cause Cloudflare to create an extra top level `/` directory in the
bucket.

PR-URL: https://github.com/nodejs/node/pull/53951
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-05 11:15:42 -03:00
Aviv Keller 04d203a233 doc: update boxstarter README 
PR-URL: https://github.com/nodejs/node/pull/53785
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-05 11:15:41 -03:00
Michaël Zasso 9c7b009f47 build,tools: simplify upload of shasum signatures 
Use the same prompt for uploads to the web host and Cloudflare R2.

PR-URL: https://github.com/nodejs/node/pull/53892
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-07-28 09:51:32 +02:00