BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-14 10:26:26 -04:00
Code Issues Packages Projects Releases Wiki Activity
32,284 Commits 236 Branches 964 Tags
2425589262fbe8c05caead80653e02a707bc4b4e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jiawen Geng 6f9cbcf6a6 src: fix v8 api deprecation 
PR-URL: https://github.com/nodejs/node/pull/35700
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2020-11-15 16:47:50 +01:00
Jiawen Geng 6200176ef0 deps: fix V8 build issue with inline methods 
PR-URL: https://github.com/nodejs/node/pull/35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-11-15 16:47:23 +01:00
Jiawen Geng 48ed72df97 tools: add msvc /P output to .gitignore 
PR-URL: https://github.com/nodejs/node/pull/35735
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-10-30 01:47:23 +00:00
Jiawen Geng 3c23af4cb7 deps: fix V8 build issue with inline methods 
PR-URL: https://github.com/nodejs/node/pull/35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-10-18 20:17:20 +02:00
gengjiawen c6b96895cc meta: enable wasi for CODEOWNERS 
PR-URL: https://github.com/nodejs/node/pull/34889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2020-08-26 00:53:55 +00:00
gengjiawen a7477704c4 quic: prefer modernize-make-unique 
PR-URL: https://github.com/nodejs/node/pull/34692
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-08-11 13:51:44 +00:00
gengjiawen f32114441c test: fix wrong method call 
PR-URL: https://github.com/nodejs/node/pull/34629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-08-08 10:39:42 +00:00
gengjiawen df17fcdc71 build: enable build for node-v8 push 
PR-URL: https://github.com/nodejs/node/pull/34634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2020-08-06 01:56:58 +00:00
gengjiawen 7a5fbafe96 quic: fix build for macOS 
PR-URL: https://github.com/nodejs/node/pull/34336
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-28 00:38:21 +00:00
gengjiawen ccbd1d5efa build: add quic to github action 
PR-URL: https://github.com/nodejs/node/pull/34336
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-28 00:38:14 +00:00
gengjiawen fbc38ee134 quic: clear clang warning 
PR-URL: https://github.com/nodejs/node/pull/34335
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-16 00:27:24 +02:00
Jiawen Geng 87933b5885 deps: V8: fix compilation on VS2017 
PR-URL: https://github.com/nodejs/node/pull/33579
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
 2020-07-13 14:42:16 +02:00
gengjiawen 68634d2592 quic: remove redundant cast 
PR-URL: https://github.com/nodejs/node/pull/34086
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
 2020-06-30 10:22:50 -07:00
gengjiawen 8ef86a920c quic: fix clang warning 
PR-URL: https://github.com/nodejs/node/pull/33963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-22 08:47:01 -07:00
gengjiawen 326a79ebb9 test: fix typo in test-quic-client-empty-preferred-address.js 
PR-URL: https://github.com/nodejs/node/pull/33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-22 12:07:14 +00:00
gengjiawen 74cd70e568 test: fix typo in common/index.js 
PR-URL: https://github.com/nodejs/node/pull/33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-22 12:07:11 +00:00
gengjiawen 25413b003c src: improve indention for upd_wrap.cc 
PR-URL: https://github.com/nodejs/node/pull/33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-22 12:07:09 +00:00
gengjiawen 09330fc155 quic: fix clang-tidy performance-faster-string-find issue 
PR-URL: https://github.com/nodejs/node/pull/33975
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-22 12:02:39 +00:00
gengjiawen 9743624c0b quic: fix typo in comments 
PR-URL: https://github.com/nodejs/node/pull/33975
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-06-22 12:02:35 +00:00
gengjiawen 81f6dd66fe build: fix node.gyp config 
PR-URL: https://github.com/nodejs/node/pull/33685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-06-02 10:42:04 +02:00
Jiawen Geng 4ad26923f4 src: refactor Reallocate since it introduced in upstream v8 
PR-URL: https://github.com/nodejs/node/pull/33402
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2020-05-14 14:37:58 +00:00
gengjiawen b82d72c199 report: fix stderr matching for fatal error 
PR-URL: https://github.com/nodejs/node/pull/32699
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
 2020-04-09 06:45:48 +00:00
gengjiawen 9c00af0716 doc: add ASAN build instructions 
PR-URL: https://github.com/nodejs/node/pull/32436
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
 2020-04-01 02:54:30 +00:00
gengjiawen d19a2c33b3 src: migrate measureMemory to new v8 api 
PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2020-03-18 16:37:20 -07:00
gengjiawen 6dca708699 src: refactor to more safe method 
PR-URL: https://github.com/nodejs/node/pull/32087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-03-12 16:55:53 +01:00
gengjiawen 3ec4b21b1c build: add asan check in Github action 
PR-URL: https://github.com/nodejs/node/pull/31902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2020-03-03 10:04:22 +00:00
gengjiawen 13c05cd10c doc: add glossary.md 
PR-URL: https://github.com/nodejs/node/pull/27517
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
 2020-02-14 03:26:18 +00:00
gengjiawen a42dcbeb43 tools: add clang-tidy rule in src 
PR-URL: https://github.com/nodejs/node/pull/26840
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-01-11 18:20:54 -08:00
gengjiawen 60026c7d9d src: add build Github Action 
PR-URL: https://github.com/nodejs/node/pull/31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2020-01-10 01:03:56 +00:00
gengjiawen 85ef944f63 win: change to use Python in install tool 
PR-URL: https://github.com/nodejs/node/pull/31221
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-01-08 06:20:35 -08:00
gengjiawen 660c4337ba src: delete redundant method in node_dir.h 
PR-URL: https://github.com/nodejs/node/pull/30747
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-12-03 23:21:18 +01:00
gengjiawen 1d0c3e3188 src: remove redundant cast in node_dir.cc 
PR-URL: https://github.com/nodejs/node/pull/30747
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-12-03 23:21:14 +01:00
gengjiawen 6c4cf862d0 src: remove unused variable in node_dir.cc 
PR-URL: https://github.com/nodejs/node/pull/30267
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-11-30 08:39:08 +00:00
gengjiawen 7ae13c360b deps: update nghttp2 to 1.40.0 
PR-URL: https://github.com/nodejs/node/pull/30493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-11-18 15:45:52 +01:00
gengjiawen ed2c3ca6e2 build: add workaround for WSL 
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/30221
Fixes: https://github.com/nodejs/node/issues/30189
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-11-04 18:04:12 +01:00
gengjiawen a49b20d324 inspector: use const for contextGroupId 
PR-URL: https://github.com/nodejs/node/pull/29076
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2019-08-13 04:26:26 +02:00
gengjiawen 447947aef4 deps: update nghttp2 to 1.39.1 
PR-URL: https://github.com/nodejs/node/pull/28448
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-07-21 21:22:17 -07:00
gengjiawen 83c1e173ea src: remove redundant return 
PR-URL: https://github.com/nodejs/node/pull/28189
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-07-02 16:08:33 +08:00
gengjiawen 4e09fd7276 build: change ASM compiler url to https 
PR-URL: https://github.com/nodejs/node/pull/28189
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-07-02 16:08:29 +08:00
gengjiawen b0f75818f3 doc: add gengjiawen to collaborators 
PR-URL: https://github.com/nodejs/node/pull/28322
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-06-20 20:33:31 +08:00
gengjiawen 4e32ce0703 inspector: mark profile type const 
PR-URL: https://github.com/nodejs/node/pull/27712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-05-19 23:39:08 +02:00
gengjiawen 79a016a246 inspector: fix typo 
PR-URL: https://github.com/nodejs/node/pull/27712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-05-19 23:39:06 +02:00
gengjiawen 97815bd6e9 lib: fix typo in pre_execution.js 
PR-URL: https://github.com/nodejs/node/pull/27649
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-05-13 16:17:42 -07:00
gengjiawen 1d31c6833d src: remove extra semicolons after macros 
PR-URL: https://github.com/nodejs/node/pull/27579
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-05-12 20:56:31 +08:00
gengjiawen 56ab82e910 src: extract common macro to util.h 
PR-URL: https://github.com/nodejs/node/pull/27512
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-05-11 17:49:52 +08:00
gengjiawen 07e0395a81 src: refactor deprecated UVException usage in pipe-wrap.cc 
PR-URL: https://github.com/nodejs/node/pull/27562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-05-10 17:36:27 +08:00
gengjiawen 3b48ce6ccf src: fix typos 
PR-URL: https://github.com/nodejs/node/pull/27580
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-05-09 06:31:02 +02:00
gengjiawen 8c94d5eccd src: make deleted function public in node_native_module.h 
PR-URL: https://github.com/nodejs/node/pull/27509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-05-06 05:26:45 +02:00
gengjiawen 64a25b8417 src: make deleted function public in node_main_instance.h 
PR-URL: https://github.com/nodejs/node/pull/27509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-05-06 05:26:32 +02:00
gengjiawen f8cf9f96dd test: better output for test-report-uv-handles.js 
PR-URL: https://github.com/nodejs/node/pull/27479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-05-01 22:36:02 +02:00
gengjiawen 97ee1c99e2 report: use const reference in node_report.cc 
PR-URL: https://github.com/nodejs/node/pull/27479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-05-01 22:36:00 +02:00
gengjiawen 38f3526f27 report: print common items first for readability 
PR-URL: https://github.com/nodejs/node/pull/27367
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-27 12:04:36 +02:00
gengjiawen f4c77f9118 src: refactor deprecated UVException in node_file.cc 
PR-URL: https://github.com/nodejs/node/pull/27280
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-27 15:15:41 +08:00
gengjiawen 5fe4d5966f src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI 
PR-URL: https://github.com/nodejs/node/pull/27279
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-26 08:14:04 +02:00
gengjiawen 51079db826 src: apply clang-tidy rule modernize-use-equals-default 
PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-24 13:32:43 -04:00
gengjiawen 2161690024 deps: update nghttp2 to 1.38.0 
PR-URL: https://github.com/nodejs/node/pull/27295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
 2019-04-22 22:44:15 +08:00
gengjiawen 8eaf31181a src: apply modernize-use-nullptr in node_win32_etw_provider.cc 
PR-URL: https://github.com/nodejs/node/pull/27263
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-22 08:45:25 -04:00
gengjiawen 758191033f src: fix performance-faster-string-find in node_report.cc 
PR-URL: https://github.com/nodejs/node/pull/27262
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-19 11:10:55 +08:00
gengjiawen 1e7823dd4e src: remove redundant call in node_options-inl.h 
PR-URL: https://github.com/nodejs/node/pull/26959
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2019-04-16 03:56:31 +02:00
gengjiawen 73471236d8 src: remove unimplemented method in TracingAgent 
PR-URL: https://github.com/nodejs/node/pull/26959
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2019-04-16 03:56:30 +02:00
gengjiawen fe963149f6 repl: add welcome message 
PR-URL: https://github.com/nodejs/node/pull/25947
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2019-04-16 03:37:03 +02:00
gengjiawen ee7daf76c0 src: remove redundant string initialization 
PR-URL: https://github.com/nodejs/node/pull/27152
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-11 11:15:07 -04:00
gengjiawen 845a6214f8 src: use macro instead of magic number for fd 
PR-URL: https://github.com/nodejs/node/pull/27152
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-11 11:15:01 -04:00
gengjiawen 93df085386 test: fix this scope bug in test-stream2-writable.js 
PR-URL: https://github.com/nodejs/node/pull/27111
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-08 22:40:15 +08:00
gengjiawen d0e2650d03 src: add NOLINT to js_native_.* 
* add filter to not lint NOLINT rules

PR-URL: https://github.com/nodejs/node/pull/26884
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-05 08:59:00 -04:00
gengjiawen d711b97aa5 src: apply clang-tidy rule bugprone-incorrect-roundings 
PR-URL: https://github.com/nodejs/node/pull/26885
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-03 12:19:44 -04:00
gengjiawen 5c2ee4ee8d deps: update nghttp2 to 1.37.0 
PR-URL: https://github.com/nodejs/node/pull/26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2019-04-03 22:18:17 +08:00
gengjiawen 4d2739453d src: replace c-style cast 
PR-URL: https://github.com/nodejs/node/pull/26888
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-02 14:15:53 -04:00
gengjiawen 1859769a1b doc: change code lang and update it with latest Node.js 
PR-URL: https://github.com/nodejs/node/pull/26987
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-03-31 22:20:34 +03:00
gengjiawen 2506ab5f39 benchmark: tidy up eslint ignore in foreach-bench.js 
PR-URL: https://github.com/nodejs/node/pull/26925
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-03-29 06:26:26 +01:00
gengjiawen 0b57175813 doc: change links to https in benchmark guide 
PR-URL: https://github.com/nodejs/node/pull/26925
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-03-29 06:26:23 +01:00
gengjiawen 8d99ba6754 benchmark: remove unused field in class BenchmarkProgress 
PR-URL: https://github.com/nodejs/node/pull/26925
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-03-29 06:26:11 +01:00
gengjiawen 230f1f2aa4 src: delete useless code in cares_wrap.cc 
PR-URL: https://github.com/nodejs/node/pull/26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 07:37:37 +01:00
gengjiawen 78ae094ed0 src: fix task release in cares_wrap.cc 
PR-URL: https://github.com/nodejs/node/pull/26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 07:37:34 +01:00
gengjiawen 3440cf6a27 src: use deleted function for class BaseObject 
PR-URL: https://github.com/nodejs/node/pull/26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 07:37:30 +01:00
gengjiawen 0601f16a47 src: delete unused field in class ModuleWrap 
PR-URL: https://github.com/nodejs/node/pull/26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 07:37:27 +01:00
gengjiawen 9addfefd84 src: tidy up include headers in env.cc 
PR-URL: https://github.com/nodejs/node/pull/26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 07:37:24 +01:00
gengjiawen 1b10f0d63c src: delete unreachable code in heap_utils.cc 
PR-URL: https://github.com/nodejs/node/pull/26815
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-28 07:37:13 +01:00
gengjiawen 8bc7d2a5be src: fix data type when using uv_get_total_memory() 
PR-URL: https://github.com/nodejs/node/pull/26886
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-03-28 05:34:01 +01:00
gengjiawen 975bc897d6 src: add include guard for trace_event_common.h 
PR-URL: https://github.com/nodejs/node/pull/26883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-26 17:54:09 -04:00
gengjiawen 8209caec39 tools: remove eslint rule no-let-in-for-declaration 
PR-URL: https://github.com/nodejs/node/pull/26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-03-26 09:46:41 -07:00
gengjiawen c757cb1b98 src: apply clang-tidy readability-delete-null-pointer 
PR-URL: https://github.com/nodejs/node/pull/26813
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-03-22 18:35:43 -04:00
gengjiawen 86e0296631 src: apply clang-tidy performance-faster-string-find 
PR-URL: https://github.com/nodejs/node/pull/26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-03-22 18:14:37 -04:00
gengjiawen 11f8024d99 benchmark: replace deprecated and eliminate var in buffer-from.js 
PR-URL: https://github.com/nodejs/node/pull/26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-03-21 09:09:28 +01:00
gengjiawen f091d4e840 src: apply clang-tidy rule modernize-use-emplace 
PR-URL: https://github.com/nodejs/node/pull/26564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2019-03-21 07:23:44 +01:00
gengjiawen 4e08daabc8 benchmark: use gfm for clarity 
PR-URL: https://github.com/nodejs/node/pull/26710
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-03-19 20:55:51 +02:00
gengjiawen 1f1914c9d4 http2: delete unused enum in node_http2.h 
PR-URL: https://github.com/nodejs/node/pull/26704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-03-19 21:36:12 +08:00
gengjiawen cf51ee4dcf src: elevate v8 namespaces for PropertyAttribute 
PR-URL: https://github.com/nodejs/node/pull/26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-03-18 20:22:13 +08:00
gengjiawen 0a00933921 src: remove unused variable in class InspectorSocketServer 
PR-URL: https://github.com/nodejs/node/pull/26633
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
 2019-03-18 05:57:57 +01:00
gengjiawen dace489099 src: use deleted function instead of private function in class AsyncWrap 
PR-URL: https://github.com/nodejs/node/pull/26634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-17 21:58:27 -04:00
gengjiawen b215bf9dac src: inline macro DISALLOW_COPY_AND_ASSIGN 
PR-URL: https://github.com/nodejs/node/pull/26634
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-03-17 21:58:22 -04:00
gengjiawen 169b7f1f3b lib: make lowerProto scope more clear 
PR-URL: https://github.com/nodejs/node/pull/26562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-03-15 10:23:15 +01:00
gengjiawen ccdaa434b8 repl: remove redundant initialization 
PR-URL: https://github.com/nodejs/node/pull/26562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-03-15 10:23:12 +01:00
gengjiawen 2788fd6b98 http: delay ret declaration in method _flushOutput 
PR-URL: https://github.com/nodejs/node/pull/26562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-03-15 10:23:02 +01:00
gengjiawen 024842f8f4 repl: eliminate var in function _memory 
PR-URL: https://github.com/nodejs/node/pull/26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2019-03-13 16:32:04 +01:00
gengjiawen 2c1a8c85d2 repl: simplify regex expression 
PR-URL: https://github.com/nodejs/node/pull/26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2019-03-13 16:32:03 +01:00
gengjiawen a26e9a8a57 repl: remove redundant escape 
PR-URL: https://github.com/nodejs/node/pull/26496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2019-03-13 16:32:02 +01:00
gengjiawen b7568e1b27 lib: refactor deprecated function in readline.js 
PR-URL: https://github.com/nodejs/node/pull/26494
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-03-13 16:27:20 +01:00
gengjiawen a4d4e9d721 cluster: refactor empty for in round_robin_handle.js 
PR-URL: https://github.com/nodejs/node/pull/26560
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-03-13 07:11:08 +01:00
gengjiawen e6fa50e953 test: fix test case in test-http2-respond-file-304.js 
PR-URL: https://github.com/nodejs/node/pull/26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-03-13 05:56:48 +01:00