wbt
246227f4bc
fs: fix default length parameter for fs.read
...
Currently, specifying an `offset` without a `length`
throws an `ERR_OUT_OF_RANGE` error.
This commit provides a more sensible default.
This change should only affect cases
where no length is specified and a nonzero offset is,
which are currently throwing errors.
PR-URL: https://github.com/nodejs/node/pull/40349
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-19 18:22:46 +01:00
Antoine du Hamel
5d4da62514
tools: lint deprecation codes
...
Add a rule to make sure deprecation codes are in order.
PR-URL: https://github.com/nodejs/node/pull/41992
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-19 18:14:09 +01:00
Antoine du Hamel
3a1a440802
esm: improve fetch_module test coverage and remove hack
...
PR-URL: https://github.com/nodejs/node/pull/41947
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2022-02-19 16:35:46 +00:00
Rich Trott
dde2f78887
test: remove test-stdout-close-catch flaky designation
...
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.
Refs: https://github.com/nodejs/node/issues/28803
PR-URL: https://github.com/nodejs/node/pull/42045
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-19 05:13:22 +00:00
npm-robot
406ffd2613
deps: upgrade npm to 8.5.1
...
PR-URL: https://github.com/nodejs/node/pull/42039
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-19 03:11:58 +00:00
Jacob Smith
8843381d9f
esm: remove erroneous context.parentURL property passed to load hook
...
PR-URL: https://github.com/nodejs/node/pull/41975
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-18 18:55:58 +00:00
Antoine du Hamel
6700b5c9e1
tools: fix bugs in prefer-primordials linter rule
...
The ESLint rule would repport false positive if code is using an
identifier that happens to have the same name as a primordials member.
PR-URL: https://github.com/nodejs/node/pull/42010
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-18 18:42:02 +00:00
Michaël Zasso
68c4b8d56d
lib: add FormData global when fetch is enabled
...
PR-URL: https://github.com/nodejs/node/pull/41956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-18 15:46:32 +00:00
Michaël Zasso
ffe7dd1ad1
test: check that fetch globals are disabled by default
...
PR-URL: https://github.com/nodejs/node/pull/42015
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-02-18 15:46:22 +00:00
Michaël Zasso
5348552b93
build: cancel running CI jobs when a PR is updated
...
Refs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value
PR-URL: https://github.com/nodejs/node/pull/42017
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-18 15:46:12 +00:00
Nick Schonning
d274d63de2
doc: use openpgp.org for keyserver examples
...
The sks-keyservers.net is no longer listed by DNS
PR-URL: https://github.com/nodejs/node/pull/39227
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-18 13:54:15 +00:00
Antoine du Hamel
6e56badf18
worker: fix typo in debug statement
...
PR-URL: https://github.com/nodejs/node/pull/42011
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-18 11:37:45 +00:00
Antoine du Hamel
2ff61fd1cd
tools: add timers functions to the list of restricted globals
...
PR-URL: https://github.com/nodejs/node/pull/42013
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-18 11:37:36 +00:00
Antoine du Hamel
3aab9860d7
tools,lib: remove global and Intl from the list of globals
...
Refs: https://github.com/nodejs/node/pull/38230
Refs: https://github.com/nodejs/node/pull/38419
PR-URL: https://github.com/nodejs/node/pull/42014
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-18 11:37:26 +00:00
Yoshiki Kurihara
82f6b0c25b
test: improve vm test coverage
...
PR-URL: https://github.com/nodejs/node/pull/41847
Refs: https://coverage.nodejs.org/coverage-cd5689eed3be54a5/lib/vm.js.html#L364
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2022-02-18 02:51:14 +00:00
Rich Trott
5c9ea80fa7
tools: reduce list of globals in ESLint config
...
Remove globals already known by ESLint.
PR-URL: https://github.com/nodejs/node/pull/41996
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
2022-02-18 01:38:39 +00:00
Tobias Nießen
bd0474974a
crypto: check result of BIO_new in X509ToObject
...
Match other call sites of BIO_new(BIO_s_mem()) and CHECK the result of
the call.
Refs: https://github.com/nodejs/node/commit/fb3a9cd0d8e8cf5f3120012a28643230b31c1f83
PR-URL: https://github.com/nodejs/node/pull/41979
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-17 23:11:54 +00:00
Tobias Nießen
19370b3176
crypto: rename X509_NAME_FLAGS
...
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with
the naming conventions we use for constexpr values, to distinguish it
from OpenSSL's built-in X509 constants, and to clarify what specific
X509 name flags the constant represents.
PR-URL: https://github.com/nodejs/node/pull/42001
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-17 23:11:46 +00:00
Darshan Sen
5edad38328
src,buffer: evaluate THROW_AND_RETURN_IF_OOB() expression only once
...
There's no need to evaluate the expression passed into the macro more
than once.
Fixes: https://github.com/nodejs/node/issues/41935
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/41945
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2022-02-18 00:05:42 +01:00
Michael Dawson
6db686710e
build: increase operations and test tag
...
- increase the operations as 1 was too small to do
anything
- add an additional tag that must be present before
the action will run. I will manually add that tag
to some feature requests to be able to test
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42038
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-17 16:39:55 -05:00
Michael Dawson
b9a460e6eb
build: allow manual run of feature request action
...
add "workflow_dispatch:" so that action can be run
manuallyl for debugging.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42037
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-02-17 20:19:39 +00:00
Michael Dawson
3fbc10d7f7
build: add action to close stale feature requests
...
Implement the prodecure outlined in
https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/41981
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-17 14:29:54 -05:00
Xuguang Mei
7d75e3f542
debugger: add debugger alias for exec(expr)
...
https://github.com/nodejs/node/issues/41794
PR-URL: https://github.com/nodejs/node/pull/41907
Reviewed-By: Jan Krems <jan.krems@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-17 19:23:20 +00:00
Mestery
4829f85233
meta: use plain emojis instead of escape sequences
...
Refs: https://github.com/nodejs/node/issues/41987
PR-URL: https://github.com/nodejs/node/pull/41989
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-17 15:13:01 +00:00
Derek Wolpert
4a690c43b8
doc: adjust a/an word usage
...
PR-URL: https://github.com/nodejs/node/pull/41915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-17 14:59:41 +00:00
Ben Noordhuis
9caceb28aa
test: run webmessaging/broadcastchannel WPT
...
Refs: https://github.com/nodejs/node/issues/38803
PR-URL: https://github.com/nodejs/node/pull/41962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-17 13:22:51 +00:00
Mestery
fdab137e64
lib: stop installing webcrypto if no_browser_globals is true
...
Refs: https://github.com/nodejs/node/pull/41969#issuecomment-1039448684
PR-URL: https://github.com/nodejs/node/pull/41971
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-17 07:04:39 +00:00
Sean Quinlan
26f9a91cc9
lib: allow respondWithNewView on byob auto allocated streams
...
Fixes: https://github.com/nodejs/node/issues/41886
PR-URL: https://github.com/nodejs/node/pull/41887
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-02-16 22:28:56 +00:00
Benjamin Gruenbaum
0a722973cb
events: set default handler value
...
Event handler like BroadcastChannel.onmessage and AbortSignal.onabort
have a default value of `null` but we return `undefined`.
Return `null` and add a test.
PR-URL: https://github.com/nodejs/node/pull/41970
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-16 19:36:20 +00:00
Darshan Sen
a82c1a1da7
lib: stop installing fetch if no_browser_globals is true
...
Fixes: https://github.com/nodejs/node/issues/41816
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/41969
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-02-16 16:53:43 +00:00
Michaël Zasso
34cf563add
build: prevent concurrent CI and CQ workflow runs
...
Use concurrency groups to prevent new runs from being started while a
previous job is already running. This can happen when a lot of unrelated
jobs are pending because of runner exhaustion.
PR-URL: https://github.com/nodejs/node/pull/42016
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-16 16:37:29 +00:00
Ray
680f3a5e9b
doc: remove extra <td>
...
PR-URL: https://github.com/nodejs/node/pull/42006
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-16 13:58:03 +00:00
Antoine du Hamel
551ca6877c
lib: restrict usage of fetch related globals in core internals
...
PR-URL: https://github.com/nodejs/node/pull/41957
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2022-02-16 14:22:59 +01:00
Rich Trott
835cdd537b
tools: update remark-preset-lint-node to 3.3.1
...
PR-URL: https://github.com/nodejs/node/pull/41999
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-16 12:44:06 +01:00
Michaël Zasso
dace5a804e
deps: update undici to 3e267ece5f
...
PR-URL: https://github.com/nodejs/node/pull/41955
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-16 00:23:48 +00:00
T•Ø•R•Ü•S
a4568f07d3
doc: capitalize valgrind
...
PR-URL: https://github.com/nodejs/node/pull/41986
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-15 21:44:31 +00:00
Antoine du Hamel
daf8a468d5
doc: fix deprecation number
...
Refs: https://github.com/nodejs/node/pull/41872
Refs: https://github.com/nodejs/node/pull/41896
PR-URL: https://github.com/nodejs/node/pull/41990
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-02-15 19:55:56 +01:00
Richard Lau
bbd7cf7257
test: fix names of tests marked flaky on IBM i
...
Correct the names of two tests that have been marked `FLAKY` on IBM i
so they will actually be marked as such by the test runner.
Refs: https://github.com/nodejs/node/pull/41812
Refs: https://github.com/nodejs/node/issues/39683
PR-URL: https://github.com/nodejs/node/pull/41984
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2022-02-15 15:19:56 +00:00
akhil marsonya
c685e4ae00
doc: add marsonya to collaborators
...
Fixes: https://github.com/nodejs/node/issues/41781
PR-URL: https://github.com/nodejs/node/pull/41991
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-15 14:43:30 +00:00
Luigi Pinca
495825bc18
tools: update ESLint to 8.9.0
...
PR-URL: https://github.com/nodejs/node/pull/41973
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-02-15 05:17:13 -08:00
Rich Trott
5b8b924995
test: fix typographical error
...
"Timeouted" to "Timed out"
PR-URL: https://github.com/nodejs/node/pull/41983
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-15 12:46:47 +00:00
Marcos Bjoerkelund
cee626d0f5
fs: support copy of relative links with cp and cpSync
...
Fixes: https://github.com/nodejs/node/issues/41693
PR-URL: https://github.com/nodejs/node/pull/41819
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-15 12:14:04 +00:00
Yash Ladha
337e70ddb7
doc: deprecate notice for process methods
...
Documentation of deprecation notice `_getActiveRequestsInfo` and
`_getActiveHandlesInfo` since they are internal usage and can be removed
in future releases.
PR-URL: https://github.com/nodejs/node/pull/41587
Refs: https://github.com/nodejs/node/pull/40813
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mary Marchini <oss@mmarchini.me >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-15 13:02:39 +01:00
alexcfyung and Gaby Baghdadi
e0fa7e0608
build: use zoslib_include_dir provided by node-gyp
...
The path is based on the zoslib gyp path passed to configure.py
via --static-zoslib-gyp arg.
PR-URL: https://github.com/nodejs/node/pull/41713
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-15 12:51:52 +01:00
Xuguang Mei
ee38bbd4cf
doc: fix bug in readable.unshift code example
...
PR-URL: https://github.com/nodejs/node/pull/41944
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-15 12:01:36 +01:00
Rich Trott
d17be0fbe5
build: move tool updates workflow runtime a day later
...
Refs: https://github.com/nodejs/node/pull/41973#issuecomment-1039780665
PR-URL: https://github.com/nodejs/node/pull/41982
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-02-15 10:50:33 +00:00
Xuguang Mei
9fb7ac3bbd
stream: need to cleanup event listeners if last stream is readable
...
fix: https://github.com/nodejs/node/issues/35452
PR-URL: https://github.com/nodejs/node/pull/41954
Fixes: https://github.com/nodejs/node/issues/35452
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-02-15 10:15:14 +00:00
Node.js GitHub Bot
cc505a505a
tools: update lint-md-dependencies to rollup@2.67.2
...
PR-URL: https://github.com/nodejs/node/pull/41941
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-14 17:53:37 -08:00
Rich Trott
8d908c14a6
meta: update AUTHORS and .mailmap
...
Update .mailmap entries and AUTHORS file.
PR-URL: https://github.com/nodejs/node/pull/41953
Refs: https://github.com/nodejs/node/pull/41952
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-02-14 19:29:59 +00:00
Mestery
4c4bd1c6db
build: extend yamllint configuration
...
This makes the configuration of yamllint stricter.
For example, single quote is imposed and only when necessary.
PR-URL: https://github.com/nodejs/node/pull/41756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2022-02-14 19:09:26 +01:00